From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id IJVWCESdV2PxcQEAbAwnHQ (envelope-from ) for ; Tue, 25 Oct 2022 10:24:36 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id cJ2KCESdV2PNbwAA9RJhRA (envelope-from ) for ; Tue, 25 Oct 2022 10:24:36 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D1C6A1F769 for ; Tue, 25 Oct 2022 10:24:35 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1onF36-0000lN-2D; Tue, 25 Oct 2022 04:12:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1onDth-00069W-IJ for emacs-orgmode@gnu.org; Tue, 25 Oct 2022 02:58:51 -0400 Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1onDtd-00060F-GG for emacs-orgmode@gnu.org; Tue, 25 Oct 2022 02:58:48 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id DFE1B240105 for ; Tue, 25 Oct 2022 08:58:42 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1666681122; bh=L3yN+6y2G8JcioWo1aG9KJAsd0y5UaFQPUzph5XY+Z0=; h=From:To:Cc:Subject:Date:From; b=frYhdWmfvCHNnnR98uUAylug/H6YfVrBr6LAZeRQjlBVZ5F7EO27789w975BYTpw2 ZXW2NuHtPB0gYwaCQ/b+3sh8SKtZSLWDZHfnib6OdCtBQQwZ5Aluw6MTOCe5NalAiT xG4LlOBb//enzLFgOaMpdLRMYNGuZlINqvbq+d6OPMh8pjbIxjVHFloc8j+hvufN1X vfQmeB1a3qH86cV+iy8PZAtZQVCIe1/vbiCLQK42DadsK1Ksi13qXdjcpbVbgCZEuM tgXMVOUZKp9IiT302UxSD1p4JBik32U2bvv0FKCyA9G8LILzoioJRYKWUun5oBDQWQ EaFNCvvpF6/OA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4MxN813Kr4z6tqr; Tue, 25 Oct 2022 08:58:41 +0200 (CEST) From: Ihor Radchenko To: Mikhail Skorzhisnkii Cc: Ihor Radchenko , Org Mode Subject: Re: [PATCH] ox-icalendar.el: customizable vevent summary prefix In-Reply-To: <878rl6wcbv.fsf@eml.cc> References: <0a1b98af1974ec260c4074df056715e237c08fce.camel@eml.cc> <871r1zawhp.fsf@nicolasgoaziou.fr> <8451fcc20c68d9863a4613df5a1cd5dbba0a77cd.camel@eml.cc> <87h72xn44k.fsf@localhost> <25163bf9-2455-4790-b258-84e766813de3@www.fastmail.com> <87ilndl9jx.fsf@localhost> <87o7w1j0su.fsf@eml.cc> <87v8q8obqs.fsf@localhost> <87y1ux3awf.fsf@eml.cc> <875yhypgop.fsf@localhost> <871qslsjv2.fsf@eml.cc> <874jxgety7.fsf@localhost> <878rl6wcbv.fsf@eml.cc> Date: Tue, 25 Oct 2022 06:59:25 +0000 Message-ID: <87lep4tmlu.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=185.67.36.66; envelope-from=yantar92@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Emacs-orgmode" Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1666686276; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=7Zh/BzFCiyDrRAnB/Kj93OprmIsEBQNI4SX0Rq561CI=; b=poAkbQiRREfs3iwYkWwK5SJVFdFoolwq+I3++4Qedv1aKcjp+H6Gl2o8e/0/J9TC6bD85d M60DafPLUjbVLAYP3/c68rZXblHwmqgTL1loHb/354koctTA1wXZe88DB4OmTykCdSSXDD zXQJj1PxIlV6A6G92LlDoi12WzAsro4ltqQMr2daJEyOVD15WHAUDw4nI7eBfwgE0VZ4pC JgDfA0rIEsMm4bEWT5xUTDKzUV5Wj96nTDLDsxYBAu2euAxMy5YjQL4mwdNMjF6JjC0y33 OaqN4h5esW9+AYOAtqGhCXvJyizBnKDCn32cQ8RY11rF5s868sRp75swgKyE/A== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1666686276; a=rsa-sha256; cv=none; b=IgR/2z4tf1F7Ke+5BSVo9hJiBaCFDYBJgfic8/BXPbq0sWHyoH1MRccimiwleadNW088JV uv6VtTpJTs+fmdEUuCNpARK7TPVtdkay24HvHeKf+PVZnepMkV8Y7RP2TUojpwM0Tblvb4 0/LKZ6chxo/Hq8UbQGXHIuN/XhUm9jacUinkPoOFq5Lsb1GYcs2TRB6F3GL4Sy3OoJ4Gem OdJRFVeBsCgpV9IOhXzgAm9KVBQMzmsCc/35w5e1fO39VrLp1/S9i5PqdmcaX4EaOWb0nD ZJCKwFGPKeh22ygB6uk2cIwuy8bjAX2hi7N0h4nPll46slV3PBt7dG3K8baHLQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=frYhdWmf; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.61 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=frYhdWmf; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: D1C6A1F769 X-Spam-Score: -3.61 X-Migadu-Scanner: scn1.migadu.com X-TUID: e2XepNQMRDuF Mikhail Skorzhisnkii writes: > Hi, Ihor, > > Sorry for the delay with fixes, took some time before I got time to finis= h this. Thanks for your review and looking forward for the next iteration. = See new version in the attachment. Comments are inline. Thanks! Applied onto main with minor amendments (typos). https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=3Dd4e7bcb4b= d87afbcb08a013111ebc976e3cf3b58 https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=3D55767b792= ee7dce41e43e6a48d48813dd9ad7f7c https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=3Dc3aa6a6d4= 3fd621bf82c4510c7a63dca7768e6dd >>> (defcustom org-outline-path-complete-in-steps t >>> =E2=80=9CNon-nil means complete the outline path in hierarchical ste= ps. >>> @@ -319,6 +320,11 @@ converted to a headline before refiling.=E2=80=9D >>> (push (list (and (buffer-file-name (buffer-base-buffer)) >>> (file-truename (buffer-file-name (bu= ffer-base-buffer)))) >>> f nil nil) tgs)) >>> + (when (eq org-refile-use-outline-path =E2=80=99title) >>> + (push (list (or (org-get-title) >>> + (and f (file-name-nondirectory f))) >>> + f nil nil) >>> + tgs)) >> >> We have very too many whens in this function. It will be more succinct >> to use a single (pcase org-refile-use-outline-path =E2=80=A6) instead. > > Yes. But then I will be refactoring quite a lot of (working) code that I = have not actually touching. > > I would prefer doing that in the separate patch. You=E2=80=99ve suggested= some changes in my patches which could be applied to some other places in = org-mode files I have seen. May be once we finish this discussion I would s= end a new series of patches with restyling? That would be great. >> We generally use `code' for Elisp symbols and `#+TITLE:' for verbatim >> non-code text. (This has not been consistently followed in etc/NEWS, but >> at least please change `#+TITLE' to `#+TITLE'). See >> doc/Documentation_Standards.org > > Ah, yes. There are many occasions in the ORG-NEWS where this is not follo= wed. Would you be interested in the patch fixing these irregularities? Yes. > And if you do, would you prefer to have a fixed-up commits for these ones= or just one big commit? I recently learned about existence of git absorb a= nd couldn=E2=80=99t recommend it enough. We do not modify git logs on savannah servers. Doing so would break user mirrors and could break commit links in the mailing list. >>> (if filetitle >>> - (org-clock-get-file-title file-name) >>> + (org-get-file-title file-name) >>> (file-name-nondirectory file-name)) >>> (if level? =E2=80=9D| =E2=80=9C =E2=80=9D=E2=80=9C) ;level c= olumn, maybe >>> (if timestamp =E2=80=9D| =E2=80=9C =E2=80=9D=E2=80=9C) ;timesta= mp column, maybe >> >> This may introduce a compiler warning. I suggest running make after >> applying your patch and fix possible compiler warnings. (I suspect that >> you may need to add declare-function on top of org-clock.el) > > Hm, I have tried it on the latest stable emacs (28.2) and it does not pro= duce me a warning. `make compile' was just clean. Could you please refer me= to the library/documentation why would I need to call `declare-function'? = This is something from cl library? If there is no warning, I was wrong. declare-function is used when we do not explicitly require the library containing that function but know for sure that the function will be defined on runtime. See 13.15 Telling the Compiler that a Function is Defined section of Elisp manual. --=20 Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at