From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id iH0zOjRISWVpTgEAG6o9tA:P1 (envelope-from ) for ; Mon, 06 Nov 2023 21:10:29 +0100 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id iH0zOjRISWVpTgEAG6o9tA (envelope-from ) for ; Mon, 06 Nov 2023 21:10:29 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3424811E6C for ; Mon, 6 Nov 2023 21:10:28 +0100 (CET) Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=IQReq3Bq; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1699301428; a=rsa-sha256; cv=none; b=ZaKCSI3wcxNK0uP4DedQiWUBEdDg/fq7U/TjRixMr0Z/p1Jy+uNFq1s4hemE4HBZ8UfaNT Qgdk6L1kfH+01gP/wfoUkSfNuCxxJlqpEVpXpjc0XDy9PHwqh5hOiJgfLK0+rkD3N3d7FC JKbuiYUBPgIuG3/qIwyrbkdnUntPm1nwqO2ig/G+Rt1FpXyOrxyY9/+FpR8IEDA9oDSxC4 MMaTvJDcWJb9bG/53hKs+5SZ6avkWSaCi01bvOOaMAJZHB7Qzdx2wqxVSeYrQv7pp5LyDQ SEefxJI1eId0dfb9JfYq/Sbxj0nSEL79UomClFexWdGglxtisSgRMXw5OJif5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1699301428; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=36Fohmsv8WxEyeaE1yHhTIfI65vo5H4E/SbQw9DHFt0=; b=Oq1tOwZ5POvAnGo+bm6OdLFBglKwFz5SN0now/EM2TMhqO+NJrae/SnuJFsiQEbudldX7T ECEk6VwkgVjTF6f6ClUgpac//3Z+Bu9eaIpBDmA6+jXZW39iD6vOydFnJIfAJ9Kj092qoG pR1iK2nkZNCK7Cm36tENWlb3mjyIyfEObAxDghfMuzojggU4Znp9qnpxuscTyMif7MSDpe PrRF3Ut3lq65jRKErx/fTpICHFWw66E7ne2o0hnb0Mm4PhIDeWe6U+eotZp23oj/qDJ8Dd jVn8IoGIpr0kG9WkKYD4Fksl1DGaoadWSupUJiFbyOm4EHHCN/W+lEPc62vi7w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=IQReq3Bq; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r05v1-0003Ba-34; Mon, 06 Nov 2023 15:09:55 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r05v0-0003BI-6k for emacs-orgmode@gnu.org; Mon, 06 Nov 2023 15:09:54 -0500 Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r05ux-0001Ea-RR for emacs-orgmode@gnu.org; Mon, 06 Nov 2023 15:09:53 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 932EE240027 for ; Mon, 6 Nov 2023 21:09:49 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1699301389; bh=L0P5hsrcUbzIvYq02Di+IQwQvudwh2+7NoiPKNPGXGM=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:From; b=IQReq3BqYyxFAbqpZ/hLVi7exg4yhS3UJ7nI8hZVgbEfZcT3gPACKiNzxL9urskt2 E8KfRn3lB8utOfEUgKZ9OPJYe7+V+KtDXIWEqd+J/JuzWPj+LBFwGmg0K6luHmcrWB g0724ryESxZWj3/M9+K0vaSiOHW0ndJLS+Qcr0h/H94QDpVIDI5TojII+GnkZc40f8 9T5sxmuEJqm2C+32YR9WAJsMVdA9k5/makarAnStagAn61XvCeuWQTq1zDPaUg8heo JIU6STHshKZKSBSg7IVGBo+fQuWLe4aGqRy9mXyC2VbsUjwaE7IXBBj6j+frLNBa9l LxeuMIr1ijmbA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4SPMrs0mRRz6tx0; Mon, 6 Nov 2023 21:09:49 +0100 (CET) From: Ihor Radchenko To: Jim Porter , emacs-devel@gnu.org Cc: emacs-orgmode@gnu.org Subject: Adding custom providers for thingatpt.el (was: [PATCH] Add support for 'thing-at-point' to get URL at point) In-Reply-To: References: Date: Mon, 06 Nov 2023 20:11:37 +0000 Message-ID: <87leba3ame.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.65; envelope-from=yantar92@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Scanner: mx11.migadu.com X-Spam-Score: -6.31 X-Migadu-Queue-Id: 3424811E6C X-Migadu-Spam-Score: -6.31 X-TUID: BpFYbd/Yk1Lb [ Branching to emacs-devel for further input from Emacs devs ] Jim Porter writes: > This is similar to Emacs bug#66752[1]. It would be nice if > "(thing-at-point 'url)" would return the URL when point is over an Org > link. With this, it's easier to write a function that copies (or browses > to) the URL at point without coding so many special cases. > ... > +(defun org--url-at-point () > + "`thing-at-point' provider function." > + (org-element-property :raw-link (org-element-context))) Supporting thingatpt.el is certainly welcome. However, I have some doubts about how mature thingatpt.el is. In particular, I am concerned whether `thing-at-point-provider-alist' is reliable enough in non-trivial scenarios like when given URL string is not matching some generic URL regexp. Looking into the source code of `bounds-of-thing-at-point', I see that for standard "things" (like url), `thing-at-point-bounds-of-url-at-point' is used unconditionally. In the case of Org links, we may have something like [[https://orgmode.org]] that will not match default URL regexp as is. AFAIU, there is no documented way to customize the behaviour of `bounds-of-thing-at-point' and `forward-thing'. I also have concerns about Org-specific part of the patch, but the above is far more important, and we need to discuss it before starting to consider anything for Org mode. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at