From: Ihor Radchenko <yantar92@posteo.net>
To: Kris Nelson <Kris@KristoferNelson.com>
Cc: Rens Oliemans <hallo@rensoliemans.nl>,
"emacs-orgmode@gnu.org" <emacs-orgmode@gnu.org>
Subject: Re: LOGBOOK drawer now being created with blank line afterwards
Date: Sun, 19 May 2024 11:48:19 +0000 [thread overview]
Message-ID: <87le463tvg.fsf@localhost> (raw)
In-Reply-To: <31465f70-3985-4e0e-aae7-d0fe59e4c69e@KristoferNelson.com>
Kris Nelson <Kris@KristoferNelson.com> writes:
> On 2024-05-17 05:22, Ihor Radchenko wrote:
>> Fixed, on main.
>> https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=288c7069c
>>
>> Thanks Kris for reporting, and thanks Rens for hunting down the cause!
> Thanks for the prompt fix, Ihor! I tested it out and confirmed I'm not
> seeing a blank space after the LOGBOOK anymore.
>
> However, I did notice that it now errors out when creating the LOGBOOK
> on a heading which is at the end of the buffer. The error is:
>
> Error in post-command-hook (org-add-log-note): (end-of-buffer)
> ...
> From 2c53fa24e2a7abfa73e070145365d89ad1197b8a Mon Sep 17 00:00:00 2001
> From: Kris Nelson <Kris@KristoferNelson.com>
> Date: Sat, 18 May 2024 12:16:06 -0600
> Subject: [PATCH] org-log-beginning: Fix error creating LOGBOOK drawer at end
> of buffer
Thanks!
Applied, onto main, adding TINYCHANGE cookie as you do not seem to have
FSF copyright assignment.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=c0b66bf9c
You are now added as an Org mode contributor:
https://git.sr.ht/~bzg/worg/commit/20d4f3f3
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
prev parent reply other threads:[~2024-05-19 11:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-14 20:56 LOGBOOK drawer now being created with blank line afterwards Kris Nelson
2024-05-15 8:38 ` Rens Oliemans
2024-05-16 7:48 ` Kris Nelson
2024-05-16 7:53 ` Ihor Radchenko
2024-05-17 11:22 ` Ihor Radchenko
2024-05-18 18:44 ` Kris Nelson
2024-05-19 11:48 ` Ihor Radchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87le463tvg.fsf@localhost \
--to=yantar92@posteo.net \
--cc=Kris@KristoferNelson.com \
--cc=emacs-orgmode@gnu.org \
--cc=hallo@rensoliemans.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).