From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bastien Subject: Re: Bug: ob-clojure tangling does not handle comments correctly [8.2.5h (8.2.5h-6-g8e1386-elpa @ /usr/local/Cellar/emacs/HEAD/share/emacs/24.3.50/lisp/org/)] Date: Thu, 06 Feb 2014 17:32:39 +0100 Message-ID: <87k3d8i4m0.fsf@bzg.ath.cx> References: <52F325CD.5060602@writequit.org> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:34029) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WBRsu-0005Eu-LD for emacs-orgmode@gnu.org; Thu, 06 Feb 2014 11:33:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WBRsp-0005gV-8h for emacs-orgmode@gnu.org; Thu, 06 Feb 2014 11:33:04 -0500 Received: from rs249.mailgun.us ([209.61.151.249]:50249) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WBRsp-0005gN-3W for emacs-orgmode@gnu.org; Thu, 06 Feb 2014 11:32:59 -0500 In-Reply-To: <52F325CD.5060602@writequit.org> (Lee Hinman's message of "Wed, 05 Feb 2014 23:03:57 -0700") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Lee Hinman Cc: emacs-orgmode@gnu.org Hi Lee, Lee Hinman writes: > When tangling a block like: > > #+BEGIN_SRC clojure :tangle foo.clj > (println "foo") > ;; My comment > #+END_SRC > > The tangled code looks like: > > (let [org-mode-print-catcher (java.io.StringWriter.)] > (clojure.pprint/with-pprint-dispatch clojure.pprint/code-dispatch > (clojure.pprint/pprint (do (println "foo") > ;; My comment) org-mode-print-catcher) (str org-mode-print-catcher))) > > Which is invalid because of the commented line (commenting out more than > intended). There needs to be an extra newline after the tangled > content/comment. Can you try with latest ob-clojure.el from the master branch? We fixed a few things recently, and the example works fine for me. Thanks! -- Bastien