From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bastien <bzg@gnu.org>
Subject: Re: [PATCH] org.el (org-offer-links-in-entry): Remove code
 duplication
Date: Tue, 06 May 2014 11:29:26 +0200
Message-ID: <87k39zmcw2.fsf@bzg.ath.cx>
References: <1398350168-18902-1-git-send-email-tarleb@moltkeplatz.de>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52582)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bounce+0e656e.a52ba-emacs-orgmode=gnu.org@bzg.fr>)
	id 1WhcPQ-0002IU-Jy
	for emacs-orgmode@gnu.org; Tue, 06 May 2014 06:15:42 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <bounce+0e656e.a52ba-emacs-orgmode=gnu.org@bzg.fr>)
	id 1WhcPI-0006ee-VE
	for emacs-orgmode@gnu.org; Tue, 06 May 2014 06:15:36 -0400
Received: from mail-s76.mailgun.info ([184.173.153.204]:50219)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bounce+0e656e.a52ba-emacs-orgmode=gnu.org@bzg.fr>)
	id 1WhcPI-0006df-F4
	for emacs-orgmode@gnu.org; Tue, 06 May 2014 06:15:28 -0400
In-Reply-To: <1398350168-18902-1-git-send-email-tarleb@moltkeplatz.de>
	(Albert	Krewinkel's message of "Thu, 24 Apr 2014 16:36:08 +0200")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Albert Krewinkel <tarleb@moltkeplatz.de>
Cc: emacs-orgmode@gnu.org

Hi Albert,

thanks for the patch.

Albert Krewinkel <tarleb@moltkeplatz.de> writes:

> * org.el (org-offer-links-in-entry): Use `org-any-link-re' to avoid
>   code duplication.

This is not really code duplication, as the output of `org-any-link-re'
is different from the output of the current sexp in the code.

That said, the change looks good anyway.  Can you double-check there
cannot be any problem with the value of `org-any-link-re'?

> The `re' variable defined in function `org-offer-links-in-entry' is
> string-equal to `org-any-link-re' and is hence replaced by the latter.
>
> This is a TINYCHANGE.

(TINYCHANGE should stand alone on the line.)

Thanks!

-- 
 Bastien