From: Tim Stewart <tim@stoo.org>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] org.el: Fix indentation in lists after blocks with special env
Date: Sun, 11 Jun 2017 21:52:49 -0400 [thread overview]
Message-ID: <87k24i3rbi.fsf@stoo.org> (raw)
In-Reply-To: <87y3tr8slz.fsf@stoo.org>
Tim Stewart <tim@stoo.org> writes:
> Hi,
>
> Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:
>
>> Hello,
>>
>> Tim Stewart <tim@stoo.org> writes:
>>
>>> * lisp/org.el (org--get-expected-indentation): Fix indentation within
>>> lists after blocks that support a special editing environment.
>>>
>>> Testing shows that the indentation within lists is incorrect after
>>> `example-block', `export-block', and `source-block'. The logic falls
>>> through and makes a recursive call to `org-get-indentation' which
>>> results in an indent to the same level as the last line of the block's
>>> contents.
>>
>> Thank you. Could you provide an ECM, however? I'm not able to reproduce
>> it so far.
>
> Huh. I just tried to minimally reproduce and was unable to do so. Then
> I tried my standard configuration (without this patch) and was still
> unable to reproduce! To keep my sanity, I'm telling myself this may
> have been fixed in the meantime.
>
> There were several others at my workplace experiencing the issue--I will
> have them remove the patch and retest in their environments. I
> apologize, I should have tried to provide an ECM from the beginning!
>
> Thank you, and I'll let you know what I find,
I checked and my coworkers checked and it seems this issue was, in fact,
resolved outside of my changes. I have not tracked down the change that
provided the actual fix.
Thanks,
-TimS
--
Tim Stewart
-----------
Mail: tim@stoo.org
Matrix: @tim:stoo.org
prev parent reply other threads:[~2017-06-12 1:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-20 3:41 [PATCH] org.el: Fix indentation in lists after blocks with special env Tim Stewart
2017-05-20 6:38 ` Nicolas Goaziou
2017-05-20 15:18 ` Tim Stewart
2017-06-12 1:52 ` Tim Stewart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k24i3rbi.fsf@stoo.org \
--to=tim@stoo.org \
--cc=emacs-orgmode@gnu.org \
--cc=mail@nicolasgoaziou.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).