From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcin Borkowski Subject: Re: How about lifting the limit of 35 tasks in org-clock-history? Date: Thu, 06 Sep 2018 16:11:01 +0200 Message-ID: <87k1nyhg22.fsf@mbork.pl> References: <87h8jbjczo.fsf@mbork.pl> <87pnxwvzij.fsf@nicolasgoaziou.fr> <87zhx0ymvc.fsf@mbork.pl> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:50323) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fxv1L-0000xp-7W for emacs-orgmode@gnu.org; Thu, 06 Sep 2018 10:12:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fxv1G-0005KH-83 for emacs-orgmode@gnu.org; Thu, 06 Sep 2018 10:12:31 -0400 Received: from mail.mojserwer.eu ([195.110.48.8]:36843) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fxv1F-00055M-Tn for emacs-orgmode@gnu.org; Thu, 06 Sep 2018 10:12:26 -0400 In-reply-to: <87zhx0ymvc.fsf@mbork.pl> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Nicolas Goaziou Cc: Org-Mode mailing list On 2018-09-02, at 16:50, Marcin Borkowski wrote: > On 2018-09-02, at 14:45, Nicolas Goaziou wrote: > >> Hello, >> >> Marcin Borkowski writes: >> >>> I attach a trivial patch fixing a very annoying cap on >>> org-clock-history. (I want to set org-clock-history to 120.) >> >> According to 7972356d092736af06282a09f008c2b5f938134d and >> 77f1f31c99f521751dc0b57f9923773e97644bb5, this limits selection to >> standard selection keys. >> >> If we want to allow more clock history, we need to remove the selection >> keys, and be sure we have something else to use. > > I decided to put a warning about this in the docstring in my patch. My > assumption was that this is enough. If a user wants to change the > default, he will most probably see the docstring and will have to > actively ignore the warning. > > I do not use the vanilla Org way of selecting tasks to clock from > history - I use org-mru-clock, for which the restriction doesn't make > sense. So we have something else to use, and it doesn't bother me that > I can't select older tasks with the original Org method. Hi Nicolas and others, any comments on this patch? Best, -- Marcin Borkowski http://mbork.pl