From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id +FJ1HJw1LmG0EAEAgWs5BA (envelope-from ) for ; Tue, 31 Aug 2021 15:58:52 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id 4C0CGJw1LmH6DQAAbx9fmQ (envelope-from ) for ; Tue, 31 Aug 2021 13:58:52 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D3C8315386 for ; Tue, 31 Aug 2021 15:58:51 +0200 (CEST) Received: from localhost ([::1]:41368 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mL4Hq-00081n-Nu for larch@yhetil.org; Tue, 31 Aug 2021 09:58:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58300) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mL4FC-00066D-Gu for emacs-orgmode@gnu.org; Tue, 31 Aug 2021 09:56:06 -0400 Received: from mail-pl1-x62e.google.com ([2607:f8b0:4864:20::62e]:33490) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mL4F6-0008Us-6s for emacs-orgmode@gnu.org; Tue, 31 Aug 2021 09:56:06 -0400 Received: by mail-pl1-x62e.google.com with SMTP id m4so10708960pll.0 for ; Tue, 31 Aug 2021 06:55:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:references:user-agent:in-reply-to :message-id:mime-version; bh=2EPLuM6mZGx8T8SxCmfo764jK2ZS73+1p8Rtpf1gz8c=; b=h56oSkw5w9wn0F5kIvzkPqPY5VZtplaTqVzuuaLGaqVSbAM5Rdm5ZWqJ68pc9ciq0K tY508oMAWToHW0QeuF5JaR3y+Z4yoKBvwmIrjRMZAmrwfZHuh9ehqO2vph4hVKbkf9J1 qg7Yg3uZi1KRCukwrTk8dGA3WxI4Bzz3LCKLY/HRtT2fRA3MhF7nH120PtOn+2nlmbdp 2+mIXKhKuuNp/keCO+IRcUTFWKSecb7m9yuATK8z5D3LzL8TxvxxiaTYzpXLZmZTMy+l Gg8/yzah6jiRgDlUgAFkn/gcuMFMCav6Tyyh1zNDyIEk6oPd/VyB+NvEMk59oIByUwCt tg3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:references:user-agent :in-reply-to:message-id:mime-version; bh=2EPLuM6mZGx8T8SxCmfo764jK2ZS73+1p8Rtpf1gz8c=; b=UbneqE/yNq6f5jmTck3554WsLP5aCBKbVElh+HV7k6TmpSkvxxoLYv0diBxcQQXNHE +p52V52vxzmicn1yUuMDAnNNgJZ9trq6TeFERW/X8PObFIiHTKm3zxYD60S5iXXZgqFF qSLIZEbXL6pE95qrqqKP5h7Hfe+hAnuAWc8uGCZzmIK4FkGdr8mJFiB8HF9eYSOVXuj5 PE+bXkH0vum6LFMmAGufxKw65v+nxQL9S0VupvAquaJoMFpKfa97tD7Csjq+CmWevnoj Mx4JN5a1OWJhEgy0YtPl6syLZoqRUqWwlzzpTFTwcw1duaxWQQQo4WsSfoXGQFFfiaCz G7jg== X-Gm-Message-State: AOAM531N3gulnp+fAjSBoyhxedUFnV7eHd1qqSOrD8yLyGu3YoEKK6AC Hd63LL7u8elhWrr7c3y8AWI= X-Google-Smtp-Source: ABdhPJyNaYwX9P6zGjnwto6nqYJFLgWi+H8Ke9sCZR9IXj8fjUq1pJ2lN+3zc8hLog1JqMnTgzaeQg== X-Received: by 2002:a17:90a:588f:: with SMTP id j15mr5757321pji.177.1630418158349; Tue, 31 Aug 2021 06:55:58 -0700 (PDT) Received: from localhost (61-245-128-160.3df580.per.nbn.aussiebb.net. [61.245.128.160]) by smtp.gmail.com with ESMTPSA id z3sm3025904pjn.43.2021.08.31.06.55.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Aug 2021 06:55:57 -0700 (PDT) From: Timothy To: Anders Johansson Subject: Re: [PATCH] Fix bug assuming canonical duration units in org-agenda-format-items Date: Tue, 31 Aug 2021 21:55:09 +0800 References: <87wnosb9rc.fsf@nicolasgoaziou.fr> User-agent: mu4e 1.6.5; emacs 28.0.50 In-reply-to: <87wnosb9rc.fsf@nicolasgoaziou.fr> Message-ID: <87k0k1oh05.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=2607:f8b0:4864:20::62e; envelope-from=tecosaur@gmail.com; helo=mail-pl1-x62e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, T_SPF_TEMPERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org, Nicolas Goaziou Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1630418331; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=2EPLuM6mZGx8T8SxCmfo764jK2ZS73+1p8Rtpf1gz8c=; b=WhQEz4GCuFS4P2HFcolr7gHHmZmv4hvC77RnVig5aCrS6Qa+RCvpivRV7hmNp8mQwVg03b 3FABR2cG2GnXsc41yHSAQodcuvtEWqQuW6Ve6iWPOwz2JtgrWEaRodRLlJcwEjUpshqc0U 5SsfrMJwT/KVhH93cjiSacmyYddOnFF4Xe0Tvc9trUQImInMW9Uo/2c8n/A5LE43Pxb33p dpHFexUzgqgYCL3q82uRpMV0kEFu/KB7nsxkIvuLb1w7HeUxHvlfonrI1UZnDHVtP4Jq1i pzK058u+YHzj6+qTnKOYIY0VQ0bwY0gPfw/RjoL7p2MJwYDkA+0QKTLKC10QXw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1630418331; a=rsa-sha256; cv=none; b=l2U29j/YpNjsAFux8W8UeE8qmzhuvdygA2nu0C9JTCRzQ/skFKgqrFmZaNTSr6W67deAQ2 6Ekkhec71q7hkNRHBle4p8salstOzgtBFp2hyrR1w40lCstDTMcbtagE900yHNEmHXngyj ZAqMjgybNUG1gkqAkuFvzDRV+04ZT9bYpOw7fCUfJhmhYbHrcx4YupJw36yqGyVIJD87py H3pJO0QKXjuzdDXqxWo0Kmh5afXJpTixsXJLd2nJc+JGClPUIfR//wq+PHOYeI6tOuxefd bbSBm3p9nPyUgf1RbI14rb6wWyC/9cWRATRk/Kr7TgDOH+leCG+CpJpH6y3Q8w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20161025 header.b=h56oSkw5; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: 1.18 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20161025 header.b=h56oSkw5; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: D3C8315386 X-Spam-Score: 1.18 X-Migadu-Scanner: scn0.migadu.com X-TUID: gCu3xCwv+45f --=-=-= Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Anders, Did you have any thoughts on Nicolas=E2=80=99 comments? Nicolas Goaziou writes: > Hello, > > Anders Johansson writes: > >> org-duration-from-minutes was called with canonical =3D t, but without >> providing a corresponding format only using the canonical units. This >> broke if the user=E2=80=99s org-duration-format used other than the cano= nical >> units. > > I think a proper fix would be to change `org-duration-from-minutes=E2=80= =99 so > it removes any unknown unit from what is provided from fmt or > `org-duration-format=E2=80=99, and defaults to (special . h:mm) if nothin= g is > left. > > WDYT? All the best, Timothy --=-=-=--