From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id CKDVBN+RqGKaGAEAbAwnHQ (envelope-from ) for ; Tue, 14 Jun 2022 15:49:19 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id kMGpBN+RqGJLIAEAauVa8A (envelope-from ) for ; Tue, 14 Jun 2022 15:49:19 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A73AE3D5AB for ; Tue, 14 Jun 2022 15:49:18 +0200 (CEST) Received: from localhost ([::1]:37950 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o16uz-0006s2-K6 for larch@yhetil.org; Tue, 14 Jun 2022 09:49:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42222) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o16tK-0005ky-JH for emacs-orgmode@gnu.org; Tue, 14 Jun 2022 09:47:35 -0400 Received: from mail-pj1-x102a.google.com ([2607:f8b0:4864:20::102a]:38826) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o16tI-0008SR-TF for emacs-orgmode@gnu.org; Tue, 14 Jun 2022 09:47:34 -0400 Received: by mail-pj1-x102a.google.com with SMTP id v11-20020a17090a4ecb00b001e2c5b837ccso11810924pjl.3 for ; Tue, 14 Jun 2022 06:47:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=J1a8AXxhDwzTS8wI7DsSceYeX1IhXG4i0KemjIRTRH0=; b=d6RkfngFjVdI0pRvBQvimMhUVJ+MUTH8trwzIAfSQEnGzIZ17z6ixqD0l9uuhTHI/S y2NMta+jm014UkLYuEoBISwJMhhIMyYNKpgMNXw0QKRjw/K0XgblwYJTdGm6CNtUgBjv OcAB553uGA1nKCccaU+Jus8bJTS+15Vr1jk+JOwQzM0O46Ww+j6hRXbLhMYg7AJwcrWN cH/XI+pZ0OwRgYX6bFx3iK+KesQU7+bgM7QALeC09syIG9GMCt2epV1GMRaU9Eobf9P6 HEi5DgpTA6NMrz+1d2pshEom2uAjtCFKhOG+ua8w2Zv5tpKdp+WDcoAdm67OyrHz02cD 193w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=J1a8AXxhDwzTS8wI7DsSceYeX1IhXG4i0KemjIRTRH0=; b=nJTrgay579vHG9hui/ST/uAFVjKHzlr29Ctf6vxJAvCd0WOqEOwUzKIJtsueac1Pp4 nGqugx95/VLeL+/IL11OHoI3HPjajBzpdI+hRlKuDSj7FCjx9ezvWEzJcWxLyg9EQMW/ W0O/8PN+sOdq+qbDpyZTqBvjEXORaxddwcmUvfBhKHpOy1Ipl4FccrgaPQhlSO4GAwbV Dr8BKdlHhYE960CzY7GrKfF95Ajaph73Hi8ZbyGNOKkZ5hXiEiOWTlWUudNKLHqY2Aas aGGEUSSEQ43NMXW+OdQa4bcrmzB3bdeEsrFSlOWMUHMSEwSX8N7RXJYcUEiunHFmIXbN Ql6Q== X-Gm-Message-State: AJIora/68P8+1sCO9Hl+TKSWZHs6idGl4/WLYcvyPy7EJ/5bALYaGmSP p3awWeqj2DATbHcK5rhiF3I= X-Google-Smtp-Source: AGRyM1t6wcwUWMvzHf6LcjwXCWc84hmMpd6+93qETyEjBj5c5w9pAz6pKFixkXp76soMWsGMzgQtsw== X-Received: by 2002:a17:90b:3c0b:b0:1ea:769d:4ab2 with SMTP id pb11-20020a17090b3c0b00b001ea769d4ab2mr4846436pjb.196.1655214451329; Tue, 14 Jun 2022 06:47:31 -0700 (PDT) Received: from localhost ([155.94.207.39]) by smtp.gmail.com with ESMTPSA id f4-20020a170902ab8400b00161a40b2135sm7189354plr.104.2022.06.14.06.47.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jun 2022 06:47:30 -0700 (PDT) From: Ihor Radchenko To: Ryan Scott Cc: numbchild@gmail.com, Greg Minshall , Timothy , emacs-orgmode@gnu.org Subject: Re: [PATCH] Re: New source block results option for attaching file to node In-Reply-To: References: <981938.1630590273@apollo2.minshall.org> <87czpqjqvw.fsf@localhost> <87zgkey55y.fsf@localhost> <8735i5u039.fsf@localhost> <87h74rq0ql.fsf@localhost> <87czffbc0r.fsf@localhost> <87sfo7q3xs.fsf@localhost> Date: Tue, 14 Jun 2022 21:48:40 +0800 Message-ID: <87k09jwe2v.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::102a; envelope-from=yantar92@gmail.com; helo=mail-pj1-x102a.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1655214558; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=J1a8AXxhDwzTS8wI7DsSceYeX1IhXG4i0KemjIRTRH0=; b=D+SjMT3VyYja8jliCw+YJvOgh949PS7lrl4Gmfoug9nZ6NhEXG6HFMU1dHlSobJOyNR32Z iShD30VveA34rfJYQd5VJO/9BLo9KGx7ssTQB4pYjgnvug3+22bI7Abgvbd/IiynoAY4Fl qd4KGLsOoTOnZo/bZY1tARadvY5bnjitS3Nah9dZSNrlFspQ1AxczFc3kN9CWUCjngRLGb 4iLwp5OIQVB6M+LVjNM8EfMXhDRWsvqRfkKvnCYzfalt3ATASLUqY6+v7HhUgSv15EznBV igVd7scX0+uU/B7tMZC1+mBniuLmpKjCVBUc4ZBJD7YxeXabME5jhQ20hslNbw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1655214558; a=rsa-sha256; cv=none; b=APQ9yrgf8xME496r7aZ5WeLdXrkR1weHE7RUzflS2j+q6YB3LdPsP/zWKzwdG9XbpYx5P1 /wAiGfKKKivdZGKCPFsbf1wVidkdpB+638o1zLfWpGP9dew/buGIvk53xtCYfFyqEPX8hd DlmyoXqWAezCjTz9ybUms6DpW8TcBC/MxiW7a61D1ZWMaepFJLp92jFzj4k174eOLQcCBp bodwkINuIK3DEcJrzljtLPNqg8qus0cjXRGz4h6P/8LoEQR4rszMwEcp+7B0x3OQUgT/Oj bv96CvmAhPABsv5/KQJQ6qKr4DFtTOhlkl/7ppuJILbIjaYi4xXuvWQbATGtBg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=d6RkfngF; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -1.99 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=d6RkfngF; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: A73AE3D5AB X-Spam-Score: -1.99 X-Migadu-Scanner: scn1.migadu.com X-TUID: zq2xOTh6VV2h Ryan Scott writes: > I put together a clean setup in docker for running the tests and believe > I've gotten to the source of the problem. > However I've thought that a few times now. Would you be interested to share it? It might be helpful for other people trying to develop on Windows. > This version of the patch has all tests passing. > The problem was in org-results-to-file and the attach dir detection. It > both had problems with an introduced assumption that the buffer-file-name > would be non-nil (causing several tests to fail) as well as being generally > overzealous in detecting file result paths as attachment links. Thanks! Applied onto main via 226119124 with several amendments. I have added some missing "." at the end of sentences, made sure that all sentences are separated by doube " " as required by our conventions and dropped `quoting' from non-symbols. Best, Ihor