emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Ihor Radchenko <yantar92@posteo.net>
To: Karthik Chikmagalur <karthikchikmagalur@gmail.com>
Cc: Visuwesh <visuweshm@gmail.com>, emacs-orgmode@gnu.org
Subject: Re: [PATCH] Add repeat-map for navigation commands
Date: Sun, 15 Sep 2024 12:54:13 +0000	[thread overview]
Message-ID: <87jzfd3wne.fsf@localhost> (raw)
In-Reply-To: <87zfogxpal.fsf@gmail.com>

Karthik Chikmagalur <karthikchikmagalur@gmail.com> writes:

> Do you think it makes sense to add repeat-maps for other next/previous
> commands in Org, such as org-next-link and org-previous-link?  I've been
> using this for a while (they don't use defvar-keymap as I wrote them a
> while ago):
>
> (defvar org-link-navigation-repeat-map
>   (let ((map (make-sparse-keymap)))
>     (define-key map (kbd "n") #'org-next-link)
>     (define-key map (kbd "p") #'org-previous-link)
>     (define-key map (kbd "v") #'org-link-preview) ;toggle preview for link at point
>     map))
>
> (map-keymap
>  (lambda (_ cmd)
>    (put cmd 'repeat-map 'org-link-navigation-repeat-map))
>  org-link-navigation-repeat-map)

Looks reasonable, yes.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>


  reply	other threads:[~2024-09-15 12:53 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-09 14:21 [PATCH] Add repeat-map for navigation commands Visuwesh
2024-09-09 16:53 ` Ihor Radchenko
2024-09-10  1:36   ` Karthik Chikmagalur
2024-09-15 12:54     ` Ihor Radchenko [this message]
2024-09-10  5:11   ` Visuwesh
2024-09-15 13:08     ` Ihor Radchenko
2024-09-16 12:29       ` Visuwesh
2024-09-22 11:48         ` Ihor Radchenko
2024-09-22 12:58           ` Visuwesh
2024-09-22 15:43             ` Ihor Radchenko
2024-10-06 11:42           ` Visuwesh
2024-10-12 17:56             ` Ihor Radchenko
2024-10-12 18:16               ` Visuwesh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87jzfd3wne.fsf@localhost \
    --to=yantar92@posteo.net \
    --cc=emacs-orgmode@gnu.org \
    --cc=karthikchikmagalur@gmail.com \
    --cc=visuweshm@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).