From mboxrd@z Thu Jan 1 00:00:00 1970 From: Richard Lawrence Subject: Bug: [PATCH] Tiny timezone bug in ox-icalendar [8.3.3 (release_8.3.3-2-g6bc48c @ /home/rwl/src/org-mode/lisp/)] Date: Thu, 21 Jan 2016 17:43:55 -0800 Message-ID: <87io2me6ck.fsf@aquinas.i-did-not-set--mail-host-address--so-tickle-me> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:54820) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aMQlF-0000ov-SD for emacs-orgmode@gnu.org; Thu, 21 Jan 2016 20:43:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aMQlB-0006ey-RA for emacs-orgmode@gnu.org; Thu, 21 Jan 2016 20:43:37 -0500 Received: from mail-oi0-x22e.google.com ([2607:f8b0:4003:c06::22e]:34184) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aMQlB-0006eu-KT for emacs-orgmode@gnu.org; Thu, 21 Jan 2016 20:43:33 -0500 Received: by mail-oi0-x22e.google.com with SMTP id k206so39148021oia.1 for ; Thu, 21 Jan 2016 17:43:32 -0800 (PST) Received: from aquinas (c-67-169-117-151.hsd1.ca.comcast.net. [67.169.117.151]) by smtp.gmail.com with ESMTPSA id l3sm1986850oeq.0.2016.01.21.17.43.30 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 21 Jan 2016 17:43:31 -0800 (PST) Received: from rwl by aquinas with local (Exim 4.84) (envelope-from ) id 1aMQlX-0008UP-LO for emacs-orgmode@gnu.org; Thu, 21 Jan 2016 17:43:55 -0800 List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org --=-=-= Content-Type: text/plain Hi all, I finally got annoyed enough to debug a problem with the timezone field in the .ics export of my agenda. Turns out the problem was simple: org-icalendar--vcalendar was being called with the wrong argument order in org-icalendar-export-current-agenda, so the timezone was going into the description field rather than the timezone field. Here's a patch that fixes that. Note that it should be applied to maint. I did not generate a commit against master, but I can if need be. Best, Richard --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-ox-icalendar-fix-timezone-export-bug.patch >From 410ba46791e2f4cf470f8727298c3faa5b717e56 Mon Sep 17 00:00:00 2001 From: Richard Lawrence Date: Thu, 21 Jan 2016 17:28:58 -0800 Subject: [PATCH] ox-icalendar: fix timezone export bug * ox-icalendar.el (org-icalendar-export-current-agenda): Correct argument order in call to org-icalendar--vcalendar (timezone should be third, description fourth). TINYCHANGE --- lisp/ox-icalendar.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/ox-icalendar.el b/lisp/ox-icalendar.el index be2f3e6..a7cb4fb 100644 --- a/lisp/ox-icalendar.el +++ b/lisp/ox-icalendar.el @@ -909,8 +909,8 @@ This function assumes major mode for current buffer is (org-icalendar--vcalendar org-icalendar-combined-name user-full-name - org-icalendar-combined-description (or (org-string-nw-p org-icalendar-timezone) (cadr (current-time-zone))) + org-icalendar-combined-description contents))) (run-hook-with-args 'org-icalendar-after-save-hook file))) -- 2.1.4 --=-=-=--