From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: org-attach-commit optional
Date: Thu, 11 Feb 2016 10:09:24 +0100
Message-ID: <87io1vy5ob.fsf@nicolasgoaziou.fr>
References: <87pow4rxzd.fsf@hecubus.retroj.net>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58632)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1aTnDf-0006mb-Ap
	for emacs-orgmode@gnu.org; Thu, 11 Feb 2016 04:07:24 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1aTnDe-0004Ky-EV
	for emacs-orgmode@gnu.org; Thu, 11 Feb 2016 04:07:23 -0500
Received: from relay4-d.mail.gandi.net ([2001:4b98:c:538::196]:60977)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1aTnDe-0004KG-80
	for emacs-orgmode@gnu.org; Thu, 11 Feb 2016 04:07:22 -0500
In-Reply-To: <87pow4rxzd.fsf@hecubus.retroj.net> (John J. Foerch's message of
	"Wed, 10 Feb 2016 17:39:50 -0500")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: John J Foerch <jjfoerch@earthlink.net>
Cc: emacs-orgmode@gnu.org

Hello,

John J Foerch <jjfoerch@earthlink.net> writes:

> I would like for org-attach's automatic committing of attachments to be
> easily disabled.  Something along the lines of the attached patch.
> Thoughts?

Thank you. A few stylistic comments follow.

> Subject: [PATCH] org-attach-attach: make use of git optional with variable
>  org-attach-commit

The commit message should be something along the lines:

  org-attach: Optionally make use of git

* lisp/org-attach.el (org-attach-commit): New variable.
(org-attach-attach): Use new variable.

You also need to add TINYCHANGE at the end of the commit message. On
this topic, please not that you are, with this patch, reaching the limit
of allowed changes without FSF assignment. You may want to consider
signing FSF papers.

> +(defcustom org-attach-commit t
> +  "If non-nil, attachments will be committed with git, if the org
> +file is in a git repository."
> +  :group 'org-attach
> +  :type 'boolean)

First line in docstring should be a sentence on its own, e.g.

    "Non-nil means attachements are to be committed with git.
  This can only happen if the Org file is in a git repository."

You should also add :version and :package-version keywords, e.g.,

  :version "25.1"
  :package-version '(Org . "9.0")


Regards,

-- 
Nicolas Goaziou