From mboxrd@z Thu Jan 1 00:00:00 1970 From: John J Foerch Subject: Re: org-attach-commit optional Date: Thu, 11 Feb 2016 10:46:39 -0500 Message-ID: <87io1vs10g.fsf@hecubus.retroj.net> References: <87pow4rxzd.fsf@hecubus.retroj.net> <87io1vy5ob.fsf@nicolasgoaziou.fr> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:59942) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aTtSH-00063d-9v for emacs-orgmode@gnu.org; Thu, 11 Feb 2016 10:46:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aTtSD-0004Zo-80 for emacs-orgmode@gnu.org; Thu, 11 Feb 2016 10:46:53 -0500 Received: from plane.gmane.org ([80.91.229.3]:50754) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aTtSC-0004Zh-Hn for emacs-orgmode@gnu.org; Thu, 11 Feb 2016 10:46:49 -0500 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1aTtS9-0006lo-O5 for emacs-orgmode@gnu.org; Thu, 11 Feb 2016 16:46:45 +0100 Received: from 152.160.144.141 ([152.160.144.141]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 11 Feb 2016 16:46:45 +0100 Received: from jjfoerch by 152.160.144.141 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 11 Feb 2016 16:46:45 +0100 List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org Nicolas Goaziou writes: > Hello, > > John J Foerch writes: > >> I would like for org-attach's automatic committing of attachments to be >> easily disabled. Something along the lines of the attached patch. >> Thoughts? > > Thank you. A few stylistic comments follow. > >> Subject: [PATCH] org-attach-attach: make use of git optional with variable >> org-attach-commit > > The commit message should be something along the lines: > > org-attach: Optionally make use of git > > * lisp/org-attach.el (org-attach-commit): New variable. > (org-attach-attach): Use new variable. > > You also need to add TINYCHANGE at the end of the commit message. On > this topic, please not that you are, with this patch, reaching the limit > of allowed changes without FSF assignment. You may want to consider > signing FSF papers. > >> +(defcustom org-attach-commit t >> + "If non-nil, attachments will be committed with git, if the org >> +file is in a git repository." >> + :group 'org-attach >> + :type 'boolean) > > First line in docstring should be a sentence on its own, e.g. > > "Non-nil means attachements are to be committed with git. > This can only happen if the Org file is in a git repository." > > You should also add :version and :package-version keywords, e.g., > > :version "25.1" > :package-version '(Org . "9.0") > > > Regards, Many thanks, Nicolas, I would be glad to do the paperwork, but as it's such a simple change, I have no objections to anybody else implementing this feature request in my place if they want to. I think it would save time. Need not use the patch I sent, which needs revision anyway - it was just a suggested implementation. Let me know if this works for this community, or whether it is preferred for me to go through the FSF process. Thank you, John Foerch