From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: Add minlevel parameter to column view parameters Date: Thu, 19 Oct 2017 21:33:42 +0200 Message-ID: <87infbszjd.fsf@nicolasgoaziou.fr> References: Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:56277) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e5GZe-0005Iu-IB for emacs-orgmode@gnu.org; Thu, 19 Oct 2017 15:33:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e5GZd-0001Kr-MZ for emacs-orgmode@gnu.org; Thu, 19 Oct 2017 15:33:46 -0400 Received: from relay3-d.mail.gandi.net ([2001:4b98:c:538::195]:33960) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1e5GZd-0001Il-Fz for emacs-orgmode@gnu.org; Thu, 19 Oct 2017 15:33:45 -0400 In-Reply-To: (Thomas Cordival's message of "Tue, 17 Oct 2017 14:26:16 +0200") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Thomas Cordival Cc: emacs-orgmode@gnu.org Hello, Thomas Cordival writes: > you will find attached a simple patch to add a new parameter to the > column view dynamic block: minlevel. Thank you! > + (if (and minlevel maxlevel) > + (format "LEVEL>=%d&LEVEL<=%d" minlevel maxlevel) > + (if minlevel > + (format "LEVEL>=%d" minlevel) > + (if maxlevel > + (format "LEVEL<=%d" maxlevel)) > + )) This could be refactored into a `cond'. > + ;; (and (or (not minlevel) (format "LEVEL>=%d" minlevel)) > + ;; (or (not maxlevel) (format "LEVEL<=%d" maxlevel))) This can be removed. Have you signed FSF papers? Otherwise, you need to insert TINCHANGE at the end of the commit message. Regards, -- Nicolas Goaziou