From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <emacs-orgmode-bounces+larch=yhetil.org@gnu.org>
Received: from mp11.migadu.com ([2001:41d0:2:bcc0::])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	by ms5.migadu.com with LMTPS
	id MDCRCWvJzGKwSgEAbAwnHQ
	(envelope-from <emacs-orgmode-bounces+larch=yhetil.org@gnu.org>)
	for <larch@yhetil.org>; Tue, 12 Jul 2022 03:07:55 +0200
Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	by mp11.migadu.com with LMTPS
	id wmK4CWvJzGIsbwEA9RJhRA
	(envelope-from <emacs-orgmode-bounces+larch=yhetil.org@gnu.org>)
	for <larch@yhetil.org>; Tue, 12 Jul 2022 03:07:55 +0200
Received: from lists.gnu.org (lists.gnu.org [209.51.188.17])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by aspmx1.migadu.com (Postfix) with ESMTPS id 9123817EBE
	for <larch@yhetil.org>; Tue, 12 Jul 2022 03:07:54 +0200 (CEST)
Received: from localhost ([::1]:43782 helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <emacs-orgmode-bounces+larch=yhetil.org@gnu.org>)
	id 1oB4NV-0006cZ-8q
	for larch@yhetil.org; Mon, 11 Jul 2022 21:07:53 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:55850)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <yantar92@gmail.com>)
 id 1oB4N3-0006cN-0h
 for emacs-orgmode@gnu.org; Mon, 11 Jul 2022 21:07:25 -0400
Received: from mail-pl1-x632.google.com ([2607:f8b0:4864:20::632]:41758)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <yantar92@gmail.com>)
 id 1oB4N1-000087-Ay
 for emacs-orgmode@gnu.org; Mon, 11 Jul 2022 21:07:24 -0400
Received: by mail-pl1-x632.google.com with SMTP id j12so5900071plj.8
 for <emacs-orgmode@gnu.org>; Mon, 11 Jul 2022 18:07:13 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
 h=from:to:cc:subject:in-reply-to:references:date:message-id
 :mime-version:content-transfer-encoding;
 bh=JwHAQdMDN7eQGTBWft2SNGT0CB+bv9jsQ3JUqRUdCYY=;
 b=jETZ4I4Y4JrH4WKeXOqIwhKNcXAx2Yt41wPjRskxwPbSTJAwoZm80UtJIS4rVqqtkK
 xe24HZl5mvzSTa667EXBCdLlmB4P8mUmnW3jeQjowRxiI/kr5XHIv5+j9aHkln6p6RYz
 kJfkJfInWgLr+MGEhTkCyEwdQGlD2EUMw0rMeV2yegHXNwNsR9He4f6sVHAgcJ7uzr2l
 Lv8Fa7jSfk/H2eih6/T9cEEqrW55ck9R8ysNwCgBxVT3Ccj8o5yjYh/EczQiYKXw/92k
 Vk8SAnraiwP81ZBmVVn0//7hjl78TVkin5zmw0janmIVjCU8zlgWUv4SngLPhErUX15p
 EBZg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date
 :message-id:mime-version:content-transfer-encoding;
 bh=JwHAQdMDN7eQGTBWft2SNGT0CB+bv9jsQ3JUqRUdCYY=;
 b=vIpwBU8pr7Bpb95C/3nsMiN+1rD3/evMCdb+tzBi7e1CRrDD9qfjjSc1CcN5ZXMj9H
 DUktVAswqNzjTPihrgC9As6p406yfMnm0reuQyedkab3WM21hCZTT7sJ6MswrwhSysWA
 27+r9aIl+gwW8imkYl2YgsBGz+DN16tmmdPOa4sm8sFMfyVRq6UrhWyOavwWF7cOX9zG
 4F1xoDQ/DbBGWZEB2vhOIyfi9q+M7j9H3enC1mfftCoE3VAfk1k7qyCEFTY/z3IqSU0I
 STk5ED4ie11Fvsrc4w/63e9iTs7FhOQ70eguyUlCvXQ8K0tct9wFpnHL/oiAlpY8hj0m
 KYNw==
X-Gm-Message-State: AJIora9H04CY21tBQ5zaqsJUXYeVl/DDU7O3D50ABpkh6RWO2kJFXH5V
 vaV5ZGKq+nM77xK3QPPw+KQ=
X-Google-Smtp-Source: AGRyM1uSO9P4bMDZSFZT+/TrFJ9fJn3+eBYSHaBI/LmlePtNPPMa3TtgY9A+WxE4ULwqgt7BcNysjQ==
X-Received: by 2002:a17:902:c7cb:b0:16b:dc5d:8959 with SMTP id
 r11-20020a170902c7cb00b0016bdc5d8959mr21388221pla.87.1657588032222; 
 Mon, 11 Jul 2022 18:07:12 -0700 (PDT)
Received: from localhost ([157.52.221.140]) by smtp.gmail.com with ESMTPSA id
 w185-20020a6362c2000000b0041292b732fdsm4843838pgb.38.2022.07.11.18.07.10
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Mon, 11 Jul 2022 18:07:11 -0700 (PDT)
From: Ihor Radchenko <yantar92@gmail.com>
To: Jack Kamm <jackkamm@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: Recent folding issues
In-Reply-To: <877d4jve13.fsf@gmail.com>
References: <877d4jve13.fsf@gmail.com>
Date: Tue, 12 Jul 2022 09:08:15 +0800
Message-ID: <87ilo36su8.fsf@localhost>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Received-SPF: pass client-ip=2607:f8b0:4864:20::632;
 envelope-from=yantar92@gmail.com; helo=mail-pl1-x632.google.com
X-Spam_score_int: -18
X-Spam_score: -1.9
X-Spam_bar: -
X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001,
 RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001,
 T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-BeenThere: emacs-orgmode@gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
 <mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
 <mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org
Sender: "Emacs-orgmode" <emacs-orgmode-bounces+larch=yhetil.org@gnu.org>
X-Migadu-Flow: FLOW_IN
X-Migadu-To: larch@yhetil.org
X-Migadu-Country: US
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org;
	s=key1; t=1657588074;
	h=from:from:sender:sender:reply-to:subject:subject:date:date:
	 message-id:message-id:to:to:cc:cc:mime-version:mime-version:
	 content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references:list-id:list-help:
	 list-unsubscribe:list-subscribe:list-post:dkim-signature;
	bh=JwHAQdMDN7eQGTBWft2SNGT0CB+bv9jsQ3JUqRUdCYY=;
	b=ZDskBSAmWgeZBfxP8AqLsLU/1I5Sqh8PGfC9N4gWvPu78wamNkUOZznSa0t1JJWsmIrYjs
	dPGjCEyT/y/F9jlRutEJvmPrs35SlkHWj4Zjt6ojByWUDY0iyFaUENKaGmDxG+QQsQOaA8
	3c5VKUjSFy2nUKNmm+EIKWHPxD2AeNXbvrRa4NPobIkxViMM7VbdkhtNurADoPucuwUxmk
	hgb3qfD3Q6n3zyuYbgQBx7qnRRxhpXSTjMakMph6TYWd0B0EQ4inJUKqAg/EhhorsnSR4X
	GhGwtGTowjeOk1p1faLATd5lX6htoonGRSHoiSacaA2rQM5xCBg4amILN7p6Pw==
ARC-Seal: i=1; s=key1; d=yhetil.org; t=1657588074; a=rsa-sha256; cv=none;
	b=e5rT5q+Ahw235LUP2Rvaqcm6zr7J+b/c5EEfqntm47bCwn70HLJxV/ChjNAZv+A5HIuZPE
	HiNr2+sU/znMwdkbBp1ge8NKPOn7/zkisArReBLaG4dJ+7WK5bB4r+913g1TxwHER3/Ga6
	92UW0XiDGnyIh3jI65jebaXaA7SmK0VZggZ6u2KGWRTtKECmZ9KrRMtXHdGfVO7OW/IGfU
	MVdt4IM+Qo2A7THICxj9/1BQc4nVylHw1bWMKZRhvZz9QufynQ4o3GHDw9gGUkEKLgbCbx
	bV7OaWK814XeEBUNik90O3tOzGuKQSeLvGL+B8NpujoCGb7RV0xXvUhNbkke7A==
ARC-Authentication-Results: i=1;
	aspmx1.migadu.com;
	dkim=pass header.d=gmail.com header.s=20210112 header.b=jETZ4I4Y;
	dmarc=pass (policy=none) header.from=gmail.com;
	spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"
X-Migadu-Spam-Score: -3.45
Authentication-Results: aspmx1.migadu.com;
	dkim=pass header.d=gmail.com header.s=20210112 header.b=jETZ4I4Y;
	dmarc=pass (policy=none) header.from=gmail.com;
	spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"
X-Migadu-Queue-Id: 9123817EBE
X-Spam-Score: -3.45
X-Migadu-Scanner: scn1.migadu.com
X-TUID: LowFgg7I62EB

Jack Kamm <jackkamm@gmail.com> writes:

> I started noticing a couple issues with folding, after updating my
> org-mode in recent months:

May you provide the output of M-x org-version?

> 1. Inserting text below or above a folded headline will cause it to
> unfold. I am not sure if this is an intentional change, but I find the
> new behavior confusing -- usually I am trying to enter a new headline,
> and the unfolding causes me to lose my context and forget what level I
> wanted my new headline to be.

I cannot reproduce. Please, update your Org to the latest version, try
to reproduce, and provide the detailed steps required to obtain the
confusing behaviour you are seeing.
See https://orgmode.org/manual/Feedback.html

> 2. When folded, I frequently found multiple headlines to be displayed on
> the same line, like so:
>
> * Headline 1...
> * Headline 2...* Headline 3...
> * Headline 4
>
> Hitting Shift-Tab a few times (org-global-cycle) usually fixed the
> problem.

Again, I cannot reproduce. If you can reliably obtain this erroneous
behaviour, please give us the information how to reproduce it. Then, we
will be able to fix it.

> After reading ORG-NEWS, I found out about org-fold-core-style, and have
> set it to 'overlays, which solved both of my problems.
>
> However, this makes me wonder whether it should be the default
> value. The help for it says:
>
>> Can be either =E2=80=98text-properties=E2=80=99 or =E2=80=98overlays=E2=
=80=99.
>> The former is faster on large files, while the latter is generally
>> less error-prone.
>
> Since the latter is less error-prone, shouldn't it be the default? And
> then a user can switch the value if they have really large files and
> need better performance. It's great that performance is being improved
> for large files, but I'm not sure this is ready to be the default yet.

I now clarified the docstring of org-fold-core-style.
"Error-prone" there refers to third-party packages that are relying on
the old implementation detail of folding.

Note that this feature is not a part of the stable Org release. It is
the development branch. We are trying our best to avoid bugs, but bugs
are pretty hard to avoid when introducing major changes like this.

Of course, we will fix the reported bugs given that enough information
is provided to reproduce them.

So, no, 'overlays should not be the default. You may also check out
https://blog.tecosaur.com/tmio/2022-05-31-folding.html

Best,
Ihor