From: Ihor Radchenko <yantar92@posteo.net>
To: Marcin Borkowski <mbork@mbork.pl>
Cc: Org-Mode mailing list <emacs-orgmode@gnu.org>
Subject: Re: What is a week?
Date: Mon, 10 Apr 2023 07:46:38 +0000 [thread overview]
Message-ID: <87ile4yyap.fsf@localhost> (raw)
In-Reply-To: <87fs981izf.fsf@mbork.pl>
Marcin Borkowski <mbork@mbork.pl> writes:
>> Assume it's Sunday. I create a clock table with :wstart 0 and
>> thisweek - and apparently my clock table starts 7 days ago.
>>
>> Now it's Monday. I create a clock table with :wstart 1 and thisweek -
>> and my clock table starts today.
>>
>> What is the logic behind it?
>
> To clarify: I understand that the reason is the `if' from this line from
> `org-clock.el':
>
> (setq diff (+ (* -7 shift) (if (= dow 0) (- 7 ws) (- dow ws)))
>
> (introduced ~10 years ago!). But why is it coded this way?
The commit goes like
0bca49801eac749b6adf39b176b9455566faac85
Author: Bastien Guerry <bzg@altern.org>
org-clock.el: Implement a new parameter :wstart to define the week start day
- (setq diff (+ (* -7 shift) (if (= dow 0) 6 (1- dow)))
+ (setq diff (+ (* -7 shift) (if (= dow 0) (- 7 ws) (- dow ws)))
I am not sure if there is any particular reason.
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
next prev parent reply other threads:[~2023-04-10 7:45 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-10 3:35 What is a week? Marcin Borkowski
2023-04-10 4:03 ` Marcin Borkowski
2023-04-10 6:04 ` Jude DaShiell
2023-04-10 7:46 ` Ihor Radchenko [this message]
2023-04-10 11:51 ` Max Nikulin
2023-04-10 12:07 ` Tim Landscheidt
2023-04-11 10:08 ` Ihor Radchenko
2023-04-24 15:47 ` Max Nikulin
2023-04-11 10:09 ` Ihor Radchenko
2023-04-11 11:34 ` Max Nikulin
2023-04-11 14:21 ` Marcin Borkowski
2023-04-23 17:57 ` Ihor Radchenko
2023-04-23 19:06 ` Marcin Borkowski
2023-04-23 19:18 ` Ihor Radchenko
2023-04-24 4:13 ` Marcin Borkowski
2023-04-24 6:26 ` Ihor Radchenko
2023-04-24 19:44 ` Marcin Borkowski
2023-04-24 20:05 ` Ihor Radchenko
2023-08-06 18:29 ` Bastien Guerry
2023-04-25 14:43 ` [PATCH] org-clock.el: Fix week start != 1 Max Nikulin
2023-05-07 8:06 ` Ihor Radchenko
2023-08-06 18:27 ` What is a week? Bastien
2023-04-24 15:13 ` Max Nikulin
2023-04-24 19:26 ` Marcin Borkowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ile4yyap.fsf@localhost \
--to=yantar92@posteo.net \
--cc=emacs-orgmode@gnu.org \
--cc=mbork@mbork.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).