[BUG] org-latex-packages-alist type specification [9.6.3 (release_9.6.3-2-gf2949d @ /usr/local/share/emacs/29.0.90/lisp/org/)]

[BUG] org-latex-packages-alist type specification [9.6.3 (release_9.6.3-2-gf2949d @ /usr/local/share/emacs/29.0.90/lisp/org/)]

[Gustavo Barros]

Hi All,

I'm testing here the new pretest for Emacs 29, and I noticed a small
problem in the type specification of the `org-latex-packages-alist'
defcustom.

The docstring states that each element of the alist is composed of up
to four elements, but the type specification comprises just the first
three.

So, if you use the new `setopt' to set it, and the variable includes
something like `("AUTO"      "babel"     t ("pdflatex"))', you get a
warning somewhat like:

#+begin_example
Warning (emacs): Value ‘(("final" "microtype" nil) ("" "soul" t) (""
"booktabs" nil) ("AUTO" "babel" t ("pdflatex")) ("autostyle"
"csquotes" nil) "\\MakeAutoQuote{“}{”}" ("" "enumitem" nil)
"\\setlistdepth{8}" "\\renewlist{itemize}{itemize}{8}"
"\\setlist[itemize,1,5]{label=\\textbullet}"
"\\setlist[itemize,2,6]{label=$\\circ$}"
"\\setlist[itemize,3,7]{label=\\textasteriskcentered}"
"\\setlist[itemize,4,8]{label={\\normalfont\\bfseries
\\textendash}}")’ does not match type (repeat (choice (list :tag
options/package pair (string :tag options) (string :tag package)
(boolean :tag Snippet)) (string :tag A line of LaTeX)))
#+end_example

Some testing here shows the offending entry is the one with the fourth
element, that of `babel'.

Best regards,
Gustavo.


Emacs  : GNU Emacs 29.0.90 (build 2, x86_64-pc-linux-gnu, GTK+ Version
3.24.33, cairo version 1.16.0)
 of 2023-04-10
Package: Org mode version 9.6.3 (release_9.6.3-2-gf2949d @
/usr/local/share/emacs/29.0.90/lisp/org/)

Re: [BUG] org-latex-packages-alist type specification [9.6.3 (release_9.6.3-2-gf2949d @ /usr/local/share/emacs/29.0.90/lisp/org/)]

[Ruijie Yu via General discussions about Org-mode.]

[-- Attachment #1: Type: text/plain, Size: 416 bytes --]


Gustavo Barros <gusbrs.2016@gmail.com> writes:

> Hi All,
>
> I'm testing here the new pretest for Emacs 29, and I noticed a small
> problem in the type specification of the `org-latex-packages-alist'
> defcustom.
>
> The docstring states that each element of the alist is composed of up
> to four elements, but the type specification comprises just the first
> three.

Does this work in your `setopt' expression?


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-lisp-org.el-org-latex-packages-alist-fixed-type-defi.patch --]
[-- Type: text/x-patch, Size: 769 bytes --]

From 0be8702357ddf699c5ff1814a5fa57a6443b10de Mon Sep 17 00:00:00 2001
From: Ruijie Yu <ruijie@netyu.xyz>
Date: Thu, 13 Apr 2023 13:14:36 +0800
Subject: [PATCH] * lisp/org.el org-latex-packages-alist: fixed type definition

---
 lisp/org.el | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lisp/org.el b/lisp/org.el
index 26d2a8610..5bad16fd9 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -3490,7 +3490,8 @@ Make sure that you only list packages here which:
 	   (list :tag "options/package pair"
 		 (string :tag "options")
 		 (string :tag "package")
-		 (boolean :tag "Snippet"))
+		 (boolean :tag "snippet")
+                 (repeat :tag "compilers" string))
 	   (string :tag "A line of LaTeX"))))
 
 (defgroup org-appearance nil
-- 
2.40.0


[-- Attachment #3: Type: text/plain, Size: 16 bytes --]


-- 
Best,


RY

Re: [BUG] org-latex-packages-alist type specification [9.6.3 (release_9.6.3-2-gf2949d @ /usr/local/share/emacs/29.0.90/lisp/org/)]

[Ihor Radchenko]

Ruijie Yu via "General discussions about Org-mode."
<emacs-orgmode@gnu.org> writes:

> From 0be8702357ddf699c5ff1814a5fa57a6443b10de Mon Sep 17 00:00:00 2001
> From: Ruijie Yu <ruijie@netyu.xyz>
> Date: Thu, 13 Apr 2023 13:14:36 +0800
> Subject: [PATCH] * lisp/org.el org-latex-packages-alist: fixed type definition

Thanks!
May I know if you got any reply about your FSF assignment?

> ---
>  lisp/org.el | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/lisp/org.el b/lisp/org.el
> index 26d2a8610..5bad16fd9 100644
> --- a/lisp/org.el
> +++ b/lisp/org.el
> @@ -3490,7 +3490,8 @@ Make sure that you only list packages here which:
>  	   (list :tag "options/package pair"
>  		 (string :tag "options")
>  		 (string :tag "package")
> -		 (boolean :tag "Snippet"))
> +		 (boolean :tag "snippet")
> +                 (repeat :tag "compilers" string))

Compiler list may also be nil.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

Re: [BUG] org-latex-packages-alist type specification [9.6.3 (release_9.6.3-2-gf2949d @ /usr/local/share/emacs/29.0.90/lisp/org/)]

[Ruijie Yu via General discussions about Org-mode.]

> On Apr 13, 2023, at 19:23, Ihor Radchenko <yantar92@posteo.net> wrote:
> 
> Ruijie Yu via "General discussions about Org-mode."
> <emacs-orgmode@gnu.org> writes:
> 
>> From 0be8702357ddf699c5ff1814a5fa57a6443b10de Mon Sep 17 00:00:00 2001
>> From: Ruijie Yu <ruijie@netyu.xyz>
>> Date: Thu, 13 Apr 2023 13:14:36 +0800
>> Subject: [PATCH] * lisp/org.el org-latex-packages-alist: fixed type definition
> 
> Thanks!
> May I know if you got any reply about your FSF assignment?

Yes, it is now complete.  I presume you want to check with Bastien, so I took the liberty of CC’ing him myself. 

>> ---
>> lisp/org.el | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>> diff --git a/lisp/org.el b/lisp/org.el
>> index 26d2a8610..5bad16fd9 100644
>> --- a/lisp/org.el
>> +++ b/lisp/org.el
>> @@ -3490,7 +3490,8 @@ Make sure that you only list packages here which:
>>      (list :tag "options/package pair"
>>        (string :tag "options")
>>        (string :tag "package")
>> -         (boolean :tag "Snippet"))
>> +         (boolean :tag "snippet")
>> +                 (repeat :tag "compilers" string))
> 
> Compiler list may also be nil.

This should be covered by the repeat case?  Unless you want to be explicit about this, in which case you can wrap it in a choice, whose first choice being (const :tag “description” nil), and the second choice being the repeat case.  Can’t change the patch myself because I don’t have access to a computer ATM. 

> -- 
> Ihor Radchenko // yantar92,
> Org mode contributor,
> Learn more about Org mode at <https://orgmode.org/>.
> Support Org development at <https://liberapay.com/org-mode>,
> or support my work at <https://liberapay.com/yantar92>

--
Best,


RY

Re: [BUG] org-latex-packages-alist type specification [9.6.3 (release_9.6.3-2-gf2949d @ /usr/local/share/emacs/29.0.90/lisp/org/)]

[Bastien Guerry]

Ruijie Yu <ruijie@netyu.xyz> writes:

>> On Apr 13, 2023, at 19:23, Ihor Radchenko <yantar92@posteo.net> wrote:
>> 
>> May I know if you got any reply about your FSF assignment?
>
> Yes, it is now complete.  I presume you want to check with Bastien,
> so I took the liberty of CC’ing him myself. 

I confirm the FSF copyright assignment is okay.

-- 
 Bastien Guerry

Re: [BUG] org-latex-packages-alist type specification [9.6.3 (release_9.6.3-2-gf2949d @ /usr/local/share/emacs/29.0.90/lisp/org/)]

[Ihor Radchenko]

Bastien Guerry <bzg@gnu.org> writes:

> I confirm the FSF copyright assignment is okay.

Recorded: https://git.sr.ht/~bzg/worg/commit/2c5757dd

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

Re: [BUG] org-latex-packages-alist type specification [9.6.3 (release_9.6.3-2-gf2949d @ /usr/local/share/emacs/29.0.90/lisp/org/)]

[Ihor Radchenko]

Ruijie Yu <ruijie@netyu.xyz> writes:

>> Compiler list may also be nil.
>
> This should be covered by the repeat case?  Unless you want to be explicit about this, in which case you can wrap it in a choice, whose first choice being (const :tag “description” nil), and the second choice being the repeat case. 

Yes, explicit tag will be better.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

Re: [BUG] org-latex-packages-alist type specification [9.6.3 (release_9.6.3-2-gf2949d @ /usr/local/share/emacs/29.0.90/lisp/org/)]

[Ruijie Yu via General discussions about Org-mode.]

[-- Attachment #1: Type: text/plain, Size: 561 bytes --]


Ihor Radchenko <yantar92@posteo.net> writes:

> Ruijie Yu <ruijie@netyu.xyz> writes:
>
>>> Compiler list may also be nil.
>>
>> This should be covered by the repeat case?  Unless you want to be explicit
>> about this, in which case you can wrap it in a choice, whose first choice
>> being (const :tag “description” nil), and the second choice being the repeat
>> case.
>
> Yes, explicit tag will be better.

Updated and rebased (cleanly) onto current main.  Note that I moved the
type into a new line to keep everything below 66 columns.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-lisp-org.el-org-latex-packages-alist-fixed-type-defi.patch --]
[-- Type: text/x-patch, Size: 1252 bytes --]

From cd9bc0751c8ab5b9a733cfbad3230d73d9642af0 Mon Sep 17 00:00:00 2001
From: Ruijie Yu <ruijie@netyu.xyz>
Date: Thu, 13 Apr 2023 13:14:36 +0800
Subject: [PATCH] * lisp/org.el org-latex-packages-alist: fixed type definition

---
 lisp/org.el | 18 +++++++++++-------
 1 file changed, 11 insertions(+), 7 deletions(-)

diff --git a/lisp/org.el b/lisp/org.el
index 463b4f594..bef5d0ca4 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -3485,13 +3485,17 @@ Make sure that you only list packages here which:
   :group 'org-export-latex
   :set 'org-set-packages-alist
   :get 'org-get-packages-alist
-  :type '(repeat
-	  (choice
-	   (list :tag "options/package pair"
-		 (string :tag "options")
-		 (string :tag "package")
-		 (boolean :tag "Snippet"))
-	   (string :tag "A line of LaTeX"))))
+  :type
+  '(repeat
+    (choice
+     (list :tag "options/package pair"
+           (string :tag "options")
+           (string :tag "package")
+           (boolean :tag "snippet")
+           (choice
+            (const :tag "All compilers include this package" nil)
+            (repeat :tag "Only include from these compilers" string)))
+     (string :tag "A line of LaTeX"))))
 
 (defgroup org-appearance nil
   "Settings for Org mode appearance."
-- 
2.40.0


[-- Attachment #3: Type: text/plain, Size: 128 bytes --]


-- 
Best,


RY

[Please note that this mail might go to spam due to some
misconfiguration in my mail server -- will fix soon.]

Re: [BUG] org-latex-packages-alist type specification [9.6.3 (release_9.6.3-2-gf2949d @ /usr/local/share/emacs/29.0.90/lisp/org/)]

[Ihor Radchenko]

Ruijie Yu <ruijie@netyu.xyz> writes:

> Subject: [PATCH] * lisp/org.el org-latex-packages-alist: fixed type definition

Applied, onto bugfix.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=14dccff8b

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

Re: [BUG] org-latex-packages-alist type specification [9.6.3 (release_9.6.3-2-gf2949d @ /usr/local/share/emacs/29.0.90/lisp/org/)]

[Gustavo Barros]

On Sat, 22 Apr 2023 at 10:27, Ihor Radchenko <yantar92@posteo.net> wrote:
>
> Ruijie Yu <ruijie@netyu.xyz> writes:
>
> > Subject: [PATCH] * lisp/org.el org-latex-packages-alist: fixed type definition
>
> Applied, onto bugfix.
> https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=14dccff8b

Thank you all!