From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id +CYQNQ7L2GQKegAASxT56A (envelope-from ) for ; Sun, 13 Aug 2023 14:22:38 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id 0GTrNA7L2GSjjwAA9RJhRA (envelope-from ) for ; Sun, 13 Aug 2023 14:22:38 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7224F5606D for ; Sun, 13 Aug 2023 14:22:38 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=rnPyoLZo; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1691929358; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=u/swUszmmserocH/LG9JtPCJeR/suIhS5CxX3TdfVy8=; b=KBVNW2Ad+vIYnCb9qumR73wJiFmSsS0UScqwpSfIgLi7N0B9k8cGxlAu7dpeuhsyXLRVYD BuN1Hh28T2pRJZpkhcYulXppkShvYzWMzK2G5noXF+gprfovkP1eAMrLzu2qUB1lk+H2wZ V1DJNXQxEfBtav9R9tER7dPjwG65fUhCfIDe0h8bDS8rKPVR+tXwHPENyYN0YY8oD2sCZz aDPLXakR5vLxZxIbTb/e4MrAX+ZX6J6EdPaAsNt1PxuPpDgtoccoplfeppGPH3NKiBqds8 dYb5Z/9XY4Tg6IXbdCrsM2N94xTLRP8Us+on/WUyM+od5+e89EBUmU6fn3jFtQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=rnPyoLZo; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Seal: i=1; s=key1; d=yhetil.org; t=1691929358; a=rsa-sha256; cv=none; b=VC/aihOTjY8C3j1duP2ptV5kCPYjiKGIZHswUaBtj8k6saXU+VJRfDn0X2wy/MD12BD1Kc N2q9zJh8JB0MnRiIQF4l+WC1h3vJsGlKuAXCPzF/u/jzb3XWwNdd5sRBSbBWmlvOjq6n5F kEv4F5dKsJGympFnApNELEXMpG9ny1dDhhXCd+YIPOHUQgmICwk2+bY5RsWnQTetWYl97F yTYYPrMd8rQVweiX1OU90TMmL865EuqGy/O8zEr6zpWafR5gEMMWxy6HnhTpow0Jw8qM7M B8/Ehla6US6VnE/UEpH9j+I/txxENvYsH/U7HUB271DDZ9enmub+nq4ro60avw== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qVA6K-0007w7-VG; Sun, 13 Aug 2023 08:21:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qVA6I-0007vy-WC for emacs-orgmode@gnu.org; Sun, 13 Aug 2023 08:21:43 -0400 Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qVA6G-0003Xn-ND for emacs-orgmode@gnu.org; Sun, 13 Aug 2023 08:21:42 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 3518A240103 for ; Sun, 13 Aug 2023 14:21:36 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1691929297; bh=q6SbdgBrnpebAhzwnOQ2I7UvlGy7j192i54X09H+UKU=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version: Content-Transfer-Encoding:From; b=rnPyoLZo/zoGpg/EPN3LMJjMTFtEsuBbDB9sV6AHgcO5zv1AfpiGpyDjVtz3rvbbb VGt76P8mmwSgEFBDliTHBWrQ9nGI6vq8cvaT01UJWgPDak3m4jplzk4/fcusHLNWZ/ LEeswS6FS3MOo+MiVKdXIKupolyFvssFq/RhWPQVaHqTvX5bDiL1wAVBuTAj1eNKTx XsUGY/C51nRb+E6vKP9u5Ym9mMTjXePh+/Uk1zYv21HhKrtRAVYYbpej//GJ09ftU9 N21l88QVmyrJO0dNnAw5UURUY23ZvVgtlFdSKxJ8Vnp5JELMXm1AZ4h52U2QL0WiSs Gqas/K+8CZUXQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4RNxTp27v1z9rxN; Sun, 13 Aug 2023 14:21:33 +0200 (CEST) From: Ihor Radchenko To: "Valentin Herrmann via General discussions about Org-mode." Cc: Valentin Herrmann Subject: Re: [PATCH] org.el: Respect org-extend-today-until in timestamps with ++ In-Reply-To: <20230813091806.1435284-1-me@valentin-herrmann.de> References: <20230813091806.1435284-1-me@valentin-herrmann.de> Date: Sun, 13 Aug 2023 12:21:59 +0000 Message-ID: <87il9jf7yw.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=185.67.36.66; envelope-from=yantar92@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -53 X-Spam_score: -5.4 X-Spam_bar: ----- X-Spam_report: (-5.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=-1, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Queue-Id: 7224F5606D X-Migadu-Scanner: mx1.migadu.com X-Spam-Score: -7.11 X-Migadu-Spam-Score: -7.11 X-TUID: /Q43wN2GrIK3 Valentin Herrmann via "General discussions about Org-mode." writes: > * org.el (org-auto-repeat-maybe): Changed org-auto-repeat-maybe, so that > switching a repeating todo with a timestamp of the form <=E2=80=A6 ++=E2= =80=A6> respects > `org-extend-today-until'. Thanks, this would make sense. However, I have comments on your patch. > - (nshift 0)) > + (nshift 0) > + (time-to-extend (seconds-to-time (* 3600 org= -extend-today-until)))) This will return time since epoch: (format-time-string "%x %X" (seconds-to-time (* 3600 org-extend-today-until= ))) ;; =3D> "01/01/1970 06:00:00 AM" > (while (or (=3D nshift 0) > - (not (time-less-p nil time))) > + (not (time-less-p nil (time-add time-= to-extend time)))) And this compares "now" with year 1970. Will always return nil. It would make things easier if you added a test for this fix into `test-org/auto-repeat-maybe' in testing/lisp/test-org.el --=20 Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at