[PATCH] Fix broken links in worg (org-contrib/index.org)

[PATCH] Fix broken links in worg (org-contrib/index.org)

[François Allisson]

[-- Attachment #1: Type: text/plain, Size: 1178 bytes --]

Hello worgers,

I've noticed that all links to raw files (.el) on
http://orgmode.org/worg/org-contrib/index.html are broken. They used
to be pointers to repo.or.cz. The attached patch reactivates these
links with pointers to the new orgmode.org git repository.

This is my first patch (not to worg, but ever), and I'm still learning
how to use git and so on, so please tell me how I could make better
patches in the future.

BTW, org-contrib/index.org needs an update on a few additional
points:

- A few new contributions in contrib/lisp are not listed here.
- A few contributions passed into the core of org. This should be
  commented, together with link to the relevant sections in the
  documentation (org.texi), etc.
- A lost last version of org-refer-by-numbers.el
- A decision to take with links to raw-files that were removed from
  the org-mode git repository: either link them to legacy raw file
  from org-mode git, or remove these links
- and a few other tiny things...

I would happily take care of that, or help anyone in doing it. I
welcome any advice on that.

Thanks for all your job in org and worg,
A happy Org user,
François.

[-- Attachment #2: 0001-Fix-broken-links-on-worg-org-contrib-index.org.patch --]
[-- Type: text/x-diff, Size: 2027 bytes --]

From 8979cc24cefea89d227d13a27f4dfbf7e8f42dec Mon Sep 17 00:00:00 2001
From: François Allisson <francois@allisson.co>
Date: Sun, 8 Apr 2012 11:56:29 +0200
Subject: [PATCH] Fix broken links on worg/org-contrib/index.org

* worg/org-contrib/index.org: Added a repofile link definition with
pointer to the orgmode.org git repository, because most links to raw
(.el) files depended on that missing definition.

* worg/org-contrib/index.org: Fixed two additional links.
---
 org-contrib/index.org |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/org-contrib/index.org b/org-contrib/index.org
index e8e5467..35aa013 100644
--- a/org-contrib/index.org
+++ b/org-contrib/index.org
@@ -7,6 +7,7 @@
 #+EMAIL:      bzg AT altern DOT org
 #+LANGUAGE:   en
 #+CATEGORY:   worg
+#+LINK:       repofile http://orgmode.org/w/?p=org-mode.git;a=blob_plain;f=%s;hb=HEAD
 
 [[file:../index.org][{Back to Worg's index}]]
 
@@ -166,7 +167,7 @@ hopefully have some documentation.
   Written by /Reimar Finken/.
   [[repofile:contrib/lisp/org-git-link.el][Link to raw file]].
 
-- [[http://julien.danjou.info/google-weather-el.html][org-google-weather.el -- weather forecast in the agenda buffer]] ::
+- [[http://julien.danjou.info/software/google-weather.el][org-google-weather.el -- weather forecast in the agenda buffer]] ::
   Allow %%(org-google-weather "New York") sexps for displaying weather
   forecast in the agenda buffer.
   Written by /Julien Danjou/.
@@ -215,7 +216,7 @@ hopefully have some documentation.
   This approximates a WYSiWYG HTML mail editor from within Emacs, and
   can be useful for sending tables, fontified source code, and inline
   images in email.  Written by /Eric Schulte/.
-  [[repofile:lisp/org-mime.el][Link to raw file]].
+  [[repofile:contrib/lisp/org-mime.el][Link to raw file]].
 
 - /org-mtags.el/ -- support for some Muse-like tags in Org-mode ::
   This package allows you to write =<example>= and =<src>= and other
-- 
1.7.5.4

Re: [PATCH] Fix broken links in worg (org-contrib/index.org)

[Bernt Hansen]

François Allisson <francois@allisson.co> writes:

> Hello worgers,
>
> I've noticed that all links to raw files (.el) on
> http://orgmode.org/worg/org-contrib/index.html are broken. They used
> to be pointers to repo.or.cz. The attached patch reactivates these
> links with pointers to the new orgmode.org git repository.
>
> This is my first patch (not to worg, but ever), and I'm still learning
> how to use git and so on, so please tell me how I could make better
> patches in the future.
>

Hi François,

This patch looks great to me (although I didn't test it).  For worg
patches you can request commit access directly and just apply the patch
yourself.

I don't think we need changelog entries for worg patches (only for
org-mode source).  Please correct me if that's wrong.

Regards,
Bernt

Re: [PATCH] Fix broken links in worg (org-contrib/index.org)

[Bastien]

Hi François and Bernt,

Bernt Hansen <bernt@norang.ca> writes:

> This patch looks great to me (although I didn't test it).  For worg
> patches you can request commit access directly and just apply the patch
> yourself.

Yes -- François, please send me your public key in private (not the
otherway around...) and I'll give you push access to Worg.

> I don't think we need changelog entries for worg patches (only for
> org-mode source).  Please correct me if that's wrong.

Correct.  Detailed commit messages are always better, but we don't 
have to use an Emacs-ready ChangeLog format for this.

-- 
 Bastien

Re: [PATCH] Fix broken links in worg (org-contrib/index.org)

[François Allisson]

Le dimanche 08 avr 2012 à 10:54:49 (-0400), Bernt Hansen a écrit :
> François Allisson <francois@allisson.co> writes:
> 
> > Hello worgers,
> >
> > I've noticed that all links to raw files (.el) on
> > http://orgmode.org/worg/org-contrib/index.html are broken. They used
> > to be pointers to repo.or.cz. The attached patch reactivates these
> > links with pointers to the new orgmode.org git repository.
> >
> > This is my first patch (not to worg, but ever), and I'm still learning
> > how to use git and so on, so please tell me how I could make better
> > patches in the future.
> >
> 
> Hi François,
> 
> This patch looks great to me (although I didn't test it).  For worg
> patches you can request commit access directly and just apply the patch
> yourself.
> 

Hi Bernt,

Thanks for you answer. I've just asked for a push access.

Regards,
François.

> I don't think we need changelog entries for worg patches (only for
> org-mode source).  Please correct me if that's wrong.
> 
> Regards,
> Bernt
> 

Re: [PATCH] Fix broken links in worg (org-contrib/index.org)

[Bastien]

Hi François,

François Allisson <francois@allisson.co> writes:

> I've noticed that all links to raw files (.el) on
> http://orgmode.org/worg/org-contrib/index.html are broken. They used
> to be pointers to repo.or.cz. The attached patch reactivates these
> links with pointers to the new orgmode.org git repository.

Great, thanks a lot.  

> This is my first patch (not to worg, but ever), and I'm still learning
> how to use git and so on, so please tell me how I could make better
> patches in the future.

I applied this patch. 

> BTW, org-contrib/index.org needs an update on a few additional
> points:
>
> - A few new contributions in contrib/lisp are not listed here.
> - A few contributions passed into the core of org. This should be
>   commented, together with link to the relevant sections in the
>   documentation (org.texi), etc.
> - A lost last version of org-refer-by-numbers.el
> - A decision to take with links to raw-files that were removed from
>   the org-mode git repository: either link them to legacy raw file
>   from org-mode git, or remove these links

Let's use legacy raw files.

> - and a few other tiny things...
>
> I would happily take care of that, or help anyone in doing it. I
> welcome any advice on that.

Please go ahead -- it's nice to have someone taking care of this area!

Thanks again,

-- 
 Bastien

Re: [PATCH] Fix broken links in worg (org-contrib/index.org)

[François Allisson]

> Hi François,
> 
> François Allisson <francois@allisson.co> writes:
> 
> > I've noticed that all links to raw files (.el) on
> > http://orgmode.org/worg/org-contrib/index.html are broken. They used
> > to be pointers to repo.or.cz. The attached patch reactivates these
> > links with pointers to the new orgmode.org git repository.
> 
> Great, thanks a lot.  
> 
> > This is my first patch (not to worg, but ever), and I'm still learning
> > how to use git and so on, so please tell me how I could make better
> > patches in the future.
> 
> I applied this patch. 

Thanks Bastien!

> 
> > BTW, org-contrib/index.org needs an update on a few additional
> > points:
> >
> > - A few new contributions in contrib/lisp are not listed here.
> > - A few contributions passed into the core of org. This should be
> >   commented, together with link to the relevant sections in the
> >   documentation (org.texi), etc.
> > - A lost last version of org-refer-by-numbers.el
> > - A decision to take with links to raw-files that were removed from
> >   the org-mode git repository: either link them to legacy raw file
> >   from org-mode git, or remove these links
> 
> Let's use legacy raw files.

OK.

> 
> > - and a few other tiny things...
> >
> > I would happily take care of that, or help anyone in doing it. I
> > welcome any advice on that.
> 
> Please go ahead -- it's nice to have someone taking care of this area!

I'll take care of that very soon.
 -- François

> 
> Thanks again,
> 
> -- 
>  Bastien