Re: TeX-master: TeX-master is let-bound

[Christopher Schmidt <christopher@ch.ristopher.com>]

[-- Attachment #1: Type: text/plain, Size: 818 bytes --]

Christopher Schmidt <christopher@ch.ristopher.com> writes:
> The default value it t anyway.  The docstring suggests that this
> variable should be set via file variables.  I do not think org-mode
> should worry about AUCTeX.

Ping?

The default value of TeX-master is t.  Binding a symbol which might be
defvar'ed within the let-body does not work.  In fact, this might break
the Emacs instance, rendering any latex-mode buffer unusable.

To make a long story short, there is no excuse for the form in question.
Please remove it.  Everyone who messes with TeX-master should use
org-export-latex-final-hook to set TeX-master and/or add a local
variables list to the buffer.

    2013-01-24  Christopher Schmidt  <christopher@ch.ristopher.com>

            * org-latex.el (org-export-as-latex): Do not bind TeX-master.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-diff, Size: 949 bytes --]

--- a/lisp/org-latex.el
+++ b/lisp/org-latex.el
@@ -964,7 +964,6 @@ When PUB-DIR is set, use this as the publishing directory."
                   (concat filename ".tex")
                 filename)))
         (auto-insert nil); Avoid any auto-insert stuff for the new file
-        (TeX-master (boundp 'TeX-master))
         (buffer (if to-buffer
                     (if (eq to-buffer 'string)
                         (get-buffer-create "*Org LaTeX Export*")
@@ -1105,9 +1104,11 @@ When PUB-DIR is set, use this as the publishing directory."
     (or (eq (char-before) ?\n)
        (insert ?\n))

+    (when (and to-buffer
+               (not (derived-mode-p 'latex-mode)))
+      (latex-mode))
     (run-hooks 'org-export-latex-final-hook)
-    (if to-buffer
-	(unless (eq major-mode 'latex-mode) (latex-mode))
+    (unless to-buffer
       (save-buffer))
     (org-export-latex-fix-inputenc)
     (run-hooks 'org-export-latex-after-save-hook)

[-- Attachment #3: Type: text/plain, Size: 33 bytes --]


Thank you,

        Christopher