From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: three bugs/misfeatures in org-reveal (or is org-reveal the wrong
 way to reveal around point?)
Date: Sat, 17 Jan 2015 09:54:53 +0100
Message-ID: <87h9vpss6a.fsf@nicolasgoaziou.fr>
References: <CAJcAo8uBKSJgr22K=oYZKeBRFvTtjHL42fKHD_PE1W2rCOyMqA@mail.gmail.com>
	<CAJcAo8sS0h8E6eudkYCrtZpQ1Jz7KqX6ds8cEFqaeWEBshb5KQ@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41839)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1YCP8m-0003zZ-1u
	for emacs-orgmode@gnu.org; Sat, 17 Jan 2015 03:53:56 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1YCP8i-0007Gw-SC
	for emacs-orgmode@gnu.org; Sat, 17 Jan 2015 03:53:55 -0500
Received: from relay4-d.mail.gandi.net ([2001:4b98:c:538::196]:52889)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1YCP8i-0007GY-Ml
	for emacs-orgmode@gnu.org; Sat, 17 Jan 2015 03:53:52 -0500
In-Reply-To: <CAJcAo8sS0h8E6eudkYCrtZpQ1Jz7KqX6ds8cEFqaeWEBshb5KQ@mail.gmail.com>
	(Samuel Wales's message of "Fri, 16 Jan 2015 18:23:44 -0700")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Samuel Wales <samologist@gmail.com>
Cc: emacs-orgmode@gnu.org

Hello,

Samuel Wales <samologist@gmail.com> writes:

> i think i found one of the bugs in org.el's org-show-context.  is
> anybody willing to confirm and fix it?
>
> On 8/5/13, Samuel Wales <samologist@gmail.com> wrote:
>>   ;; bug 1: when point is in entry text, the first child of that
>>   ;; entry shows, but its siblings (i.e. the other children) do

Siblings are other headlines at the same level, not children.

>>   ;; not show, even though i have org-show-siblings and
>>   ;; org-show-hierarchy-above both set to t.
>
>     (when following-p
>       ;; Show next sibling, or heading below text
>       (save-excursion
> 	(and (if heading-p (org-goto-sibling) (outline-next-heading))
> 	     (org-flag-heading nil))))
>     (when siblings-p (org-show-siblings))
>
> the part in the save-excursion needs to check for siblings-p also.

I don't understand why it should. SIBLINGS-P means "show all siblings".
This is handled later in the function.


Regards,

-- 
Nicolas Goaziou