emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Kyle Meyer <kyle@kyleam.com>
To: Jan Malakhovski <oxij@oxij.org>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] make org-clock-time% respect org-effort-durations and related
Date: Sun, 25 Oct 2015 13:23:19 -0400	[thread overview]
Message-ID: <87h9le981k.fsf@kyleam.com> (raw)
In-Reply-To: <1445777293-13909-1-git-send-email-oxij@oxij.org> (Jan Malakhovski's message of "Sun, 25 Oct 2015 12:48:09 +0000")

Hello,

Jan Malakhovski <oxij@oxij.org> writes:

> Hi.
>
> The first patch here is a must, because it fixes a bug I stumble upoon
> daily. Middle two are just to make the names consistent. While doing
> all those changes I read quite a lot of code and the last patch adds a
> FIXME for a particularly ugly place I'm not sure how to fix (I think
> don't ever consciously use that code path and I'm not sure what it
> supposed to do).

Thanks for these patches, as well as the other series you sent [1].  I
haven't looked at the content in detail, but based on the diffstats,
these changes are touching enough lines to require copyright assignment
[2].  Also, please include a ChangeLog entry in the commit message [3].

Thanks again.

[1] http://thread.gmane.org/gmane.emacs.orgmode/102168
[2] http://orgmode.org/worg/org-contribute.html#orgheadline2
[3] http://orgmode.org/worg/org-contribute.html#orgheadline6

--
Kyle

      parent reply	other threads:[~2015-10-25 17:23 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-25 12:48 [PATCH] make org-clock-time% respect org-effort-durations and related Jan Malakhovski
2015-10-25 12:48 ` [PATCH 1/4] org-clock: make org-clock-time% respect org-effort-durations Jan Malakhovski
2015-10-25 12:48 ` [PATCH 2/4] org: move org-duration-string-to-minutes to a better place Jan Malakhovski
2015-10-25 12:48 ` [PATCH 3/4] rename org-duration-string-to-minutes to org-clocksum-string-to-minutes everywhere Jan Malakhovski
2015-10-25 12:48 ` [PATCH 4/4] org-colview: add a FIXME Jan Malakhovski
2015-10-25 17:23 ` Kyle Meyer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h9le981k.fsf@kyleam.com \
    --to=kyle@kyleam.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=oxij@oxij.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).