From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Thibault Marin <thibault.marin@gmx.com>
Cc: "emacs-orgmode@gnu.org" <emacs-orgmode@gnu.org>
Subject: Re: ob-lua
Date: Sat, 20 Aug 2016 18:02:13 +0200 [thread overview]
Message-ID: <87h9af1la2.fsf@saiph.selenimh> (raw)
In-Reply-To: <87bn0of273.fsf@dell-desktop.WORKGROUP> (Thibault Marin's message of "Sat, 20 Aug 2016 00:18:24 -0500")
Hello,
Thibault Marin <thibault.marin@gmx.com> writes:
> I was looking for lua support in source blocks and I came across this
> discussion:
> https://lists.gnu.org/archive/html/emacs-orgmode/2014-05/msg01149.html. It
> seems that this was never merged, but I am not sure why.
It looks like Bastien was waiting for a following patch, which never
happened.
> Trying to use the ob-lua.el file linked, it appears to be working for my task (I
> just need to be able to pass variables to a lua block). I only had to make a
> small change to the file to get it to work, as `org-babel-get-header' is no
> longer available:
>
> 132c132
> < (mapcar #'cdr (org-babel-get-header params :var))))
> ---
>> (remove nil (mapcar (lambda (x) (when (eq (car x) :var) (cdr x))) params))))
>
> There may be a better way to do it, but it seems to work.
In this case, `org-babel-get-header' should be replaced with
`org-babel--get-vars', per ORG-NEWS.
> So my question is: could this be considered for a merge? The code does
> not seem to support sessions, I am not sure if that should be
> a blocker.
It isn't a blocker, indeed. Could you send an updated patch? A set of
tests would be nice, too.
Thank you.
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2016-08-20 16:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-20 5:18 ob-lua Thibault Marin
2016-08-20 16:02 ` Nicolas Goaziou [this message]
2016-08-21 4:47 ` ob-lua Thibault Marin
2016-08-21 9:30 ` ob-lua Nicolas Goaziou
2016-08-22 2:38 ` ob-lua Thibault Marin
2016-08-22 9:28 ` ob-lua Nicolas Goaziou
2016-08-22 12:56 ` ob-lua Thibault Marin
2016-08-24 2:39 ` ob-lua Thibault Marin
2016-08-29 7:10 ` ob-lua Nicolas Goaziou
2016-08-31 3:36 ` ob-lua Thibault Marin
2016-09-01 16:40 ` ob-lua Nicolas Goaziou
2016-09-08 4:37 ` ob-lua Thibault Marin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h9af1la2.fsf@saiph.selenimh \
--to=mail@nicolasgoaziou.fr \
--cc=emacs-orgmode@gnu.org \
--cc=thibault.marin@gmx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).