From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adam Porter Subject: Re: Add org-bookmark-heading to Org proper? Date: Thu, 22 Sep 2016 18:40:22 -0500 Message-ID: <87h997zeop.fsf@alphapapa.net> References: <8760podmwr.fsf@alphapapa.net> <87lgyjk9rb.fsf@nicolasgoaziou.fr> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:35306) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bnDbr-0001Q2-UH for emacs-orgmode@gnu.org; Thu, 22 Sep 2016 19:40:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bnDbm-00066T-Vu for emacs-orgmode@gnu.org; Thu, 22 Sep 2016 19:40:54 -0400 Received: from [195.159.176.226] (port=60467 helo=blaine.gmane.org) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bnDbm-00066G-Of for emacs-orgmode@gnu.org; Thu, 22 Sep 2016 19:40:50 -0400 Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1bnDbY-0003ZR-Om for emacs-orgmode@gnu.org; Fri, 23 Sep 2016 01:40:36 +0200 List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: emacs-orgmode@gnu.org Nicolas Goaziou writes: Hi Nicholas, > I think Org could benefit from a shrunk version of this library, i.e., > `org-bookmark-make-record' and `org-bookmark-jump'. > > However I'm not convinced about `org-bookmark-jump-indirect' since this > variable complicates code and the same effect can be achieved easily > once the destination headline is reached. > > Besides, the helm part doesn't really belong to Org. IIUC, it is not > even needed if we drop support for `org-bookmark-jump-indirect', as > suggested above. Yes, the Helm-related code would certainly be left out. I could propose a patch to Thierry or make it a separate package on MELPA. The indirect feature could be left out as well, but I find it so useful that I think it might be worth including so that users can try it. It really transforms the way I use Org, especially in combination with some other functions I have that use indirect buffers when jumping to items from the agenda. It wouldn't need to be enabled by default, of course. But it's not strictly necessary, so I won't fight you on that if you want to leave it out. ;) > A few suggestions, after a cursory look: > > - please switch to lexical binding as all but one file in Org core, > > - it is "Org mode", not "org-mode" > > - `org-replace-links-in-string-with-desc' already exists, it is > (mis)called `org-link-display-format' > > - `assoc' -> `assq' when key is a symbol > > - if you create a marker, unset it once useless > > - first sentence in docstrings has to fit in the first line. Thanks for reading through the code and finding these. I'll go through them soon and prepare a patch (which I'll post after doing the copyright assignment). > Thank you for your work. No, thank you! :D