From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: [PATCH] org-sort: Read compare-func in interactive calls Date: Fri, 12 May 2017 09:10:37 +0200 Message-ID: <87h90q1rf6.fsf@nicolasgoaziou.fr> References: <871srz5mbr.fsf@kyleam.com> <20170509194750.8974-1-kyle@kyleam.com> <87tw4r12ww.fsf@nicolasgoaziou.fr> <8737cax2tm.fsf@kyleam.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:50816) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d94is-0004ov-PC for emacs-orgmode@gnu.org; Fri, 12 May 2017 03:10:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d94io-0001Ln-Pg for emacs-orgmode@gnu.org; Fri, 12 May 2017 03:10:46 -0400 Received: from relay7-d.mail.gandi.net ([217.70.183.200]:37914) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1d94io-0001LX-K1 for emacs-orgmode@gnu.org; Fri, 12 May 2017 03:10:42 -0400 In-Reply-To: <8737cax2tm.fsf@kyleam.com> (Kyle Meyer's message of "Thu, 11 May 2017 21:48:37 -0400") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Kyle Meyer Cc: Zhitao Gong , emacs-orgmode@gnu.org Hello, Kyle Meyer writes: > Yeah, in order to make org-sort-entries, org-sort-list, and > org-table-sort-lines behave the same way with respect to how they read > getkey-func and compare-func, I ignored the warning in > called-interactively-p's docstring that says it can be "brittle" if a > function is advised or being debugged. > > Instead of adding called-interactively-p to org-sort-entries and > org-sort-list, I initially looked at removing called-interactively-p > from org-table-sort-lines, but I think that would 1) require changing > its behavior for determining the sorting column, and 2) going against > org-table-sort-lines's docstring that says no prompting will take place > if called from Lisp. > > So I'm fine removing called-interactively-p from org-table-sort-lines, > but I'm not sure how it should behave, particularly with respect to the > column prompt. > > Thoughts? Couldn't we use (interactive "p") instead, as suggested in `called-interactively-p' docstring, in order to tell if we need to ask for a function or not? Regards, -- Nicolas Goaziou