Bug: Marking repeated tasks with two tags as DONE causes problems

Bug: Marking repeated tasks with two tags as DONE causes problems

[Josh Moller-Mara]

Hello,

I'm starting to encounter a strange, silent problem when switching the
state of a task with multiple tags. With the following minimal example:

#+STARTUP: logdone
#+STARTUP: logdrawer
* TODO Hello :hi:there:
  SCHEDULED: <2017-08-11 Fri .+1d>

Switching The "hello" task from "TODO" to "DONE" should keep the task as
"TODO", but schedule it in the future. Instead, the file ends up looking
like:

#STARTUP: logdone :hi:there:
#+STARTUP: logdrawer
* DONE Hello :hi:there:
  CLOSED: [2017-08-11 Fri 14:57] SCHEDULED: <2017-08-12 Sat .+1d>

Where the task is marked as "DONE", and weirdly tags are added in some
of the startup config at the beginning of the file.

I'm using

Emacs  : GNU Emacs 26.0.50.2 (x86_64-pc-linux-gnu, GTK+ Version 3.22.5)
 of 2017-01-18
Package: Org mode version 9.0.9 (release_9.0.9-746-g8fa6c0 @ /usr/local/share/emacs/site-lisp/org/)

There still seems to be a problem with org-toggle-tag, which is causing
this. I think it has to do with the "replace-match"
again. "org-split-string" doesn't save match data, so "replace-match"
replaces the wrong thing.

Best,
Josh

Re: Bug: Marking repeated tasks with two tags as DONE causes problems

[Colin Baxter]

Dear Josh,
>>>>> "Josh" == Josh Moller-Mara <jmm@cns.nyu.edu> writes:

    Josh> Hello,

    Josh> I'm starting to encounter a strange, silent problem when
    Josh> switching the state of a task with multiple tags. With the
    Josh> following minimal example:

    Josh> #+STARTUP: logdone #+STARTUP: logdrawer

    Josh> * TODO Hello :hi:there: SCHEDULED: <2017-08-11 Fri .+1d>

    Josh> Switching The "hello" task from "TODO" to "DONE" should keep
    Josh> the task as "TODO", but schedule it in the future. Instead,
    Josh> the file ends up looking like:

    Josh> #STARTUP: logdone :hi:there:

    Josh> #+STARTUP: logdrawer * DONE Hello :hi:there:

    Josh>   CLOSED: [2017-08-11 Fri 14:57] SCHEDULED: <2017-08-12 Sat
    Josh> .+1d>

    Josh> Where the task is marked as "DONE", and weirdly tags are added
    Josh> in some of the startup config at the beginning of the file.

This may be related somehow to the problem mentioned in the thread
"Change in appearance of org-todo-keywords". It's good to have your
minimal example.

Best wishes.

-- 
--
Colin Baxter
m43cap@yandex.com
GnuPG fingerprint: 68A8 799C 0230 16E7 BF68  2A27 BBFA 2492 91F5 41C8

Re: Bug: Marking repeated tasks with two tags as DONE causes problems

[Nicolas Goaziou]

Hello,

Colin Baxter <m43cap@yandex.com> writes:

> Dear Josh,
>>>>>> "Josh" == Josh Moller-Mara <jmm@cns.nyu.edu> writes:
>
>     Josh> Hello,
>
>     Josh> I'm starting to encounter a strange, silent problem when
>     Josh> switching the state of a task with multiple tags. With the
>     Josh> following minimal example:
>
>     Josh> #+STARTUP: logdone #+STARTUP: logdrawer
>
>     Josh> * TODO Hello :hi:there: SCHEDULED: <2017-08-11 Fri .+1d>
>
>     Josh> Switching The "hello" task from "TODO" to "DONE" should keep
>     Josh> the task as "TODO", but schedule it in the future. Instead,
>     Josh> the file ends up looking like:
>
>     Josh> #STARTUP: logdone :hi:there:
>
>     Josh> #+STARTUP: logdrawer * DONE Hello :hi:there:
>
>     Josh>   CLOSED: [2017-08-11 Fri 14:57] SCHEDULED: <2017-08-12 Sat
>     Josh> .+1d>
>
>     Josh> Where the task is marked as "DONE", and weirdly tags are added
>     Josh> in some of the startup config at the beginning of the file.
>
> This may be related somehow to the problem mentioned in the thread
> "Change in appearance of org-todo-keywords". It's good to have your
> minimal example.

I still cannot reproduce it.

Does the very recent 10b1cfb0317274a91500562a2872f2626160f079 fix this?

Regards,

-- 
Nicolas Goaziou

Re: Bug: Marking repeated tasks with two tags as DONE causes problems

[Josh Moller-Mara]

Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:

>
> I still cannot reproduce it.
>
> Does the very recent 10b1cfb0317274a91500562a2872f2626160f079 fix this?
>

Yup. That commit seems to fix it.

Thanks!

Best,
Josh

Re: Bug: Marking repeated tasks with two tags as DONE causes problems

[Colin Baxter]

>>>>> "Nicolas" == Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:

    Nicolas> I still cannot reproduce it.

    Nicolas> Does the very recent
    Nicolas> 10b1cfb0317274a91500562a2872f2626160f079 fix this?

Things seem ok for me too. I had a separate issue with empty tags
appearing in habits, which I discovered was due to my settings of the
variables org-habit-graph-column, org-habit-preceding-days,
org-habit-following-days being too far from the defaults of 40, 21, 7
respectively.

Thank you very much for all your efforts and time.

Best wishes,

Colin.

-- 
--
Colin Baxter
m43cap@yandex.com
GnuPG fingerprint: 68A8 799C 0230 16E7 BF68  2A27 BBFA 2492 91F5 41C8