emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: "Tony E. Bennett" <tony.e.bennett@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: org-open-line inconsistent treatment of marking characters '#' and '*'
Date: Sat, 12 Jan 2019 11:42:21 +0100	[thread overview]
Message-ID: <87h8eeyx6a.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <m27efcmptp.fsf@gmail.com> (Tony E. Bennett's message of "Thu, 10 Jan 2019 11:37:22 -0500")

Hello,

Tony E. Bennett <tony.e.bennett@gmail.com> writes:

> org-open-line replicates the table marking character '#' (if present) into
> the new table line but does not do the same for '*'.
>
> Since the semantics of '#' and '*' are so similar I expect them to be
> treated identically when opening a new table line.
>
> Within defun org-table-insert-row, changing this line:
>
>          ;; Fix the first field if necessary
>          (when (string-match "^[ \t]*| *[#$] *|" line)
>
> to:
>
>          ;; Fix the first field if necessary
>          (when (string-match "^[ \t]*| *[#*$] *|" line)
>
> gives the expected behavior.
>
> Can this be fixed?

OK, I applied the change in maint. However, I tend to think we should
not copy any special marker at all, since we don't check if we're in
a special column anyway.

Regards,

-- 
Nicolas Goaziou

  reply	other threads:[~2019-01-12 10:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-10 16:37 org-open-line inconsistent treatment of marking characters '#' and '*' Tony E. Bennett
2019-01-12 10:42 ` Nicolas Goaziou [this message]
2019-01-13  1:48   ` Tony E. Bennett
2019-01-13 11:11     ` Nicolas Goaziou
2019-01-13 15:12       ` Tony E. Bennett

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h8eeyx6a.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=emacs-orgmode@gnu.org \
    --cc=tony.e.bennett@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).