From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 8HtFK9P4lmOjYAEAbAwnHQ (envelope-from ) for ; Mon, 12 Dec 2022 10:48:03 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id qMorKtP4lmPCPwAAG6o9tA (envelope-from ) for ; Mon, 12 Dec 2022 10:48:03 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 64EE678CA for ; Mon, 12 Dec 2022 10:48:03 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p4fP9-00044G-8k; Mon, 12 Dec 2022 04:47:23 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4fP6-000444-SQ for emacs-orgmode@gnu.org; Mon, 12 Dec 2022 04:47:21 -0500 Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4fP4-0008Mi-Ng for emacs-orgmode@gnu.org; Mon, 12 Dec 2022 04:47:20 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 8EAFD240109 for ; Mon, 12 Dec 2022 10:47:16 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1670838436; bh=hSKZiusLXFaTTfTDMAG59M7K49baMrUgQBdy9EnTJzA=; h=From:To:Cc:Subject:Date:From; b=asrUaNp28kirtixvC06+QJnxSOztpO5Tn7FS9DLllg5UUrqX3pyV2HmNZzOe1IVP4 lZIkVnJpoSwRLsgKbJZ3Ke9aJ05wfKYhy7aaDqS4/3McapGX9664809+bV6nNZz4PP Qm0RRn3f7+PrZuW5nSpe6AuHKP42B3Pjsc6gw1tC89ikYaUV8xo+dFvmo/9EAJwVkg XNIOo6WMYCWI7USYQt5XNEThHGnHDSw01uxaf081ZnmMi758XM6qaSPQXH1HCyLA7N qli6CFHpkB1B7ntVvthPrqbyRXR0C1qReK2BBxFS392HWgWmP66lN8G2anMDXLHX0v RzTpeNLOvxv7w== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4NVxcL1pQhz9rxF; Mon, 12 Dec 2022 10:47:14 +0100 (CET) From: Ihor Radchenko To: Jeremie Juste , Bastien Cc: Greg Minshall , Johan =?utf-8?Q?Tol=C3=B6?= , emacs-orgmode@gnu.org, "Berry, Charles" Subject: Re: [BUG] ob-R.el: extra empty data.frame columns generated from plain lists after recent change [9.6 (release_9.6-3-ga4d38e @ /usr/share/emacs/30.0.50/lisp/org/)] In-Reply-To: <87k02yq7mz.fsf@gmail.com> References: <87wn77mdvk.fsf@toloe.se> <766358.1670208594@archlinux> <87wn74xjv7.fsf@gmail.com> <87bkofh0ir.fsf@localhost> <87sfhqudks.fsf@gmail.com> <87edtantzq.fsf@localhost> <87k02yq7mz.fsf@gmail.com> Date: Mon, 12 Dec 2022 09:47:13 +0000 Message-ID: <87h6y1hs2m.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.66; envelope-from=yantar92@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1670838483; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=QKcRqqD5+HYIhXOfgBaLENgr9m2LGOCZdS+Uixvq/ks=; b=IpavJlTj1ec6rbVaWW/ReQeKq8uKGtNcOMIB81KLKsZdNUi/AZcDm/Y+dgB0i37H7G5GTJ SmHLup3EWoNDMdYB/rMuWx670d/pay87EifGF8cXD3rIko0JtGJIZEF0Hf06LfnfLcRtnD QzjUOdGg0gk+RZg4p+vXv1vYsmZaA0Ozv8OQDWW7iQTIWNwbxUrNMnl7b/Hjjd06GbO+mS 55Fkmo9Gzsa1yEDIsIOh+MM3geIIapH2NJiJUSputBjXj4jYEKPJixEKPLqPHOpstCES2G oTQbx98TU8akWO6gDUErKUMUo8R8CJ1akzypLWfzJ/ncd5NWtPE/3d9rd9L/8Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=asrUaNp2; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Seal: i=1; s=key1; d=yhetil.org; t=1670838483; a=rsa-sha256; cv=none; b=GSN45c5Lwx9WcOnAdHsca2uHk/fjCMkiUUEsCkWunOr0ERx15lAXfSuAGfdlj2/DLfh0wp vFz5kIh+P3s1PBdmM3OerXZJYi7zL0Q5psSlug1py1pxXwE44V4rKEQN6UJ0iAN/WUOdva A+82klFtEZx2P+J1fLvxivhX0dJRamiUFhlXF0HKFU1xrcm02FavDWW7mE42aFUdbdbUlf urPYkHhZ8FGbqNrIMF1xhg8Q6x9Im99Bnb7wYYLa85gUtkXeTq9UR6IeAT5SHGPPUG70ka VYgdBI7GFEIXxKo2Ad/Eu/O2ToBYJ0yxckSBxkhi1Wa+b63WGAy1C0MUxS3uEQ== X-Migadu-Spam-Score: -11.15 X-Spam-Score: -11.15 X-Migadu-Queue-Id: 64EE678CA X-Migadu-Scanner: scn0.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=asrUaNp2; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net X-TUID: SmCUr+nqDfGM Jeremie Juste writes: > On Thursday, 8 Dec 2022 at 09:07, Ihor Radchenko wrote: > >> I am not sure if I like the approach you used in the commit. >> >> - (unless (listp (car value)) (setq value (list value))) >> + (unless (listp (car value)) (setq value (mapcar 'list value))) >> >> In the above, you are transforming (val1 val2 val3 ...) list into >> ((val1) (val2) (val3) ...). >> >> Does it make sense from the point of view of R code? >> AFAIU, the current ob-R implementation converts lists into R tables, >> which is not accurate? Would it make sense to convert Elisp lists into R >> lists directly? > > Many thanks for the feedback. At this point I don't know. On one hand you are > right on the other, this option is backward compatible, and the user can > always create an interface in R to suit his need. > > If there are more complaints about that in the future, I'll reconsider. Note that my NEWS entry may not be accurate for ob-R then: ** List references in source block variable assignments are now proper lists So, we may create confusion one way or another. Or I may need to put a special clause regarding ob-R into the NEWS item. Bastien, maybe you have something to say about this situation? -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at