From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bill Wishon Subject: Fix to property inheritance Date: Sat, 15 Dec 2012 22:24:30 -0800 Message-ID: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=f46d043be19e3f5c2704d0f2515a Return-path: Received: from eggs.gnu.org ([208.118.235.92]:52728) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tk7eK-0002dS-FV for emacs-orgmode@gnu.org; Sun, 16 Dec 2012 01:24:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tk7eJ-00013k-Dn for emacs-orgmode@gnu.org; Sun, 16 Dec 2012 01:24:32 -0500 Received: from mail-vc0-f169.google.com ([209.85.220.169]:65080) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tk7eJ-00013Y-9Q for emacs-orgmode@gnu.org; Sun, 16 Dec 2012 01:24:31 -0500 Received: by mail-vc0-f169.google.com with SMTP id gb23so6049540vcb.0 for ; Sat, 15 Dec 2012 22:24:30 -0800 (PST) List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode --f46d043be19e3f5c2704d0f2515a Content-Type: multipart/alternative; boundary=f46d043be19e3f5c2404d0f25158 --f46d043be19e3f5c2404d0f25158 Content-Type: text/plain; charset=ISO-8859-1 This is my first major org-mode contribution, and I'm new to git, so if there is something I haven't got quite right in terms of how to contribute please advise. org-entry-get with inherit set didn't work for sub-heading additions or overrides to properties found in parent headings as of Org-mode version 7.9.2 (release_7.9.2-738-g442b2a-git @ org-loaddefs.el can not be found!). An example test org-mode file is attached (modified from the testing/examples directory and also updated in my git repository). My public git repository info is: git clone git@bitbucket.org: mrvwman/wishon-org-mode.git branch name: fix-property-inheritance I've submitted my request to assign@gnu.org, but have not yet received a reply. Best, ~>Bill --f46d043be19e3f5c2404d0f25158 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
This is my first major org-mode contribution, and I'm new to git, = so if there is something I haven't got quite right in terms of how to c= ontribute please advise.

org-entry-get with inheri= t set didn't work for sub-heading additions or overrides to properties = found in parent headings as of Org-mode version 7.9.2 (release_7.9.2-738-g4= 42b2a-git @ org-loaddefs.el can not be found!). =A0

An example test org-mode file is attached (modified fro= m the testing/examples directory and also updated in my git repository).

My public git repository info is:=A0git clone git@bi= tbucket.org:mrvwman/wishon-org-mode.git
branch name: fix-property-inheritance


Best,
~>Bill
--f46d043be19e3f5c2404d0f25158-- --f46d043be19e3f5c2704d0f2515a Content-Type: application/octet-stream; name="my-property-inheritance.org" Content-Disposition: attachment; filename="my-property-inheritance.org" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hars79vg0 Iytwcm9wZXJ0eTogdmFyICBmb289MQojK3Byb3BlcnR5OiB2YXIrIGJhcj0yCgojK2JlZ2luX3Ny YyBlbWFjcy1saXNwCiAgKCsgZm9vIGJhcikKIytlbmRfc3JjCgojK2JlZ2luX3NyYyBlbWFjcy1s aXNwCiAgKG9yZy1lbnRyeS1nZXQgKHBvaW50KSAidmFyIiB0KQojK2VuZF9zcmMKCiogb3Zlcndy aXRpbmcgYSBmaWxlLXdpZGUgcHJvcGVydHkKICA6UFJPUEVSVElFUzoKICA6dmFyOiAgICAgIGZv bz03CiAgOkVORDoKCiMrYmVnaW5fc3JjIGVtYWNzLWxpc3AKICBmb28KIytlbmRfc3JjCgojK2Jl Z2luX3NyYyBlbWFjcy1saXNwCiAgKG9yZy1lbnRyeS1nZXQgKHBvaW50KSAidmFyIiB0KQojK2Vu ZF9zcmMKKiBhcHBlbmRpbmcgdG8gYSBmaWxlLXdpZGUgcHJvcGVydHkKICA6UFJPUEVSVElFUzoK ICA6dmFyKzogICAgICBiYXo9MwogIDpFTkQ6CgojK2JlZ2luX3NyYyBlbWFjcy1saXNwCiAgKCsg Zm9vIGJhciBiYXopCiMrZW5kX3NyYwoKIytiZWdpbl9zcmMgZW1hY3MtbGlzcAogIChvcmctZW50 cnktZ2V0IChwb2ludCkgInZhciIgdCkKIytlbmRfc3JjCiogaGllcmFyY2h5IHRlc3QKOlBST1BF UlRJRVM6Cjp2YXIrOiBib289Mi41CjpFTkQ6CioqIGFwcGVuZGluZyB0byBhIHBhcmVudCBwcm9w ZXJ0eQogIDpQUk9QRVJUSUVTOgogIDp2YXIrOiAgICAgIGJhej0zCiAgOkVORDoKClRoZSByZXN1 bHQgc2hvdWxkIGJlIDguNQp3aXRoIE9yZy1tb2RlIHZlcnNpb24gNy45LjIgdGhlIHJlc3VsdCBp cyB0aGF0IGJvbyBpcyB1bmRlZmluZWQuCiMrYmVnaW5fc3JjIGVtYWNzLWxpc3AKICAoKyBmb28g YmFyIGJvbyBiYXopCiMrZW5kX3NyYwoKVGhlIHJlc3VsdCBzaG91bGQgYmUgImZvbz0xIGJhcj0y IGJvbz0yLjUgYmF6PTMiCndpdGggT3JnLW1vZGUgdmVyc2lvbiA3LjkuMiB0aGUgcmVzdWx0IGlz ICJmb289MSBiYXI9MiBiYXo9MyIKIytiZWdpbl9zcmMgZW1hY3MtbGlzcAogIChvcmctZW50cnkt Z2V0IChwb2ludCkgInZhciIgdCkKIytlbmRfc3JjCgoqKiByZXNldHRpbmcgYSBwYXJlbnQgcHJv cGVydHkKICA6UFJPUEVSVElFUzoKICA6dmFyKzogICAgICAgbmlsCiAgOkVORDoKVGhlIHJlc3Vs dCBzaG91bGQgYmUgIm5pbCIKd2l0aCBPcmctbW9kZSB2ZXJzaW9uIDcuOS4yIHRoZSByZXN1bHQg aXMgYW4gZXJyb3IKIytiZWdpbl9zcmMgZW1hY3MtbGlzcAogIChvcmctZW50cnktZ2V0IChwb2lu dCkgInZhciIgdCB0KQojK2VuZF9zcmMKCioqKiBzZXR0aW5nIGEgbmV3IHByb3BlcnR5IHZhbHVl CjpQUk9QRVJUSUVTOgo6dmFyKzogYmF0PTQKOkVORDoKVGhlIHJlc3VsdCBzaG91bGQgYmUgImJh dD00Igp3aXRoIE9yZy1tb2RlIHZlcnNpb24gNy45LjIgdGhlIHJlc3VsdCBpcyAiZm9vPTEgYmFy PTIgYmF0PTQiCiMrYmVnaW5fc3JjIGVtYWNzLWxpc3AKICAob3JnLWVudHJ5LWdldCAocG9pbnQp ICJ2YXIiIHQpCiMrZW5kX3NyYwoK --f46d043be19e3f5c2704d0f2515a-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bastien Subject: Re: Fix to property inheritance Date: Mon, 24 Dec 2012 01:45:56 +0100 Message-ID: <87bodkwa4b.fsf@bzg.ath.cx> References: Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([208.118.235.92]:39826) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TmwB5-0000uV-FK for emacs-orgmode@gnu.org; Sun, 23 Dec 2012 19:46:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TmwB4-0004ev-9i for emacs-orgmode@gnu.org; Sun, 23 Dec 2012 19:45:59 -0500 Received: from mail-we0-f178.google.com ([74.125.82.178]:62397) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TmwB4-0004ep-38 for emacs-orgmode@gnu.org; Sun, 23 Dec 2012 19:45:58 -0500 Received: by mail-we0-f178.google.com with SMTP id x43so3007879wey.23 for ; Sun, 23 Dec 2012 16:45:57 -0800 (PST) In-Reply-To: (Bill Wishon's message of "Sat, 15 Dec 2012 22:24:30 -0800") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Bill Wishon Cc: emacs-orgmode Hi Bill, Bill Wishon writes: > This is my first major org-mode contribution, and I'm new to git, so > if there is something I haven't got quite right in terms of how to > contribute please advise. Thanks for contributing. > org-entry-get with inherit set didn't work for sub-heading additions > or overrides to properties found in parent headings as of Org-mode > version 7.9.2 (release_7.9.2-738-g442b2a-git @ org-loaddefs.el can > not be found!).   > > An example test org-mode file is attached (modified from the testing/ > examples directory and also updated in my git repository). Yes, I see the problem. > My public git repository info is: git clone git@bitbucket.org:mrvwman > /wishon-org-mode.git > branch name: fix-property-inheritance Unless this is a big serie of patches (e.g. >5) can you send the patch to the mailing list? We use a patchwork instance to store patches and be able to review them later. Make sure to read this : http://orgmode.org/worg/org-contribute.html#sec-4 > I've submitted my request to assign@gnu.org, but have not yet > received a reply. I've added you to Worg: http://orgmode.org/worg/org-contribute.html#sec-6-2 Thanks in advance for the patch! -- Bastien From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bastien Subject: Re: Fix to property inheritance Date: Tue, 25 Dec 2012 04:28:48 +0100 Message-ID: <87fw2uyfm7.fsf@bzg.ath.cx> References: Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([208.118.235.92]:38668) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TnLCK-0006yk-JR for emacs-orgmode@gnu.org; Mon, 24 Dec 2012 22:29:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TnLCI-0000Hg-4u for emacs-orgmode@gnu.org; Mon, 24 Dec 2012 22:28:56 -0500 Received: from mail-we0-f171.google.com ([74.125.82.171]:54349) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TnLCH-0000HV-Ub for emacs-orgmode@gnu.org; Mon, 24 Dec 2012 22:28:54 -0500 Received: by mail-we0-f171.google.com with SMTP id u3so3578706wey.16 for ; Mon, 24 Dec 2012 19:28:53 -0800 (PST) In-Reply-To: (Bill Wishon's message of "Sat, 15 Dec 2012 22:24:30 -0800") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Bill Wishon Cc: emacs-orgmode Hi Bill, Bill Wishon writes: > My public git repository info is: git clone git@bitbucket.org:mrvwman > /wishon-org-mode.git > branch name: fix-property-inheritance I could not clone this repository, apparently I don't have enough rights. Can you send a patch? Thanks, -- Bastien From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bill Wishon Subject: Re: Fix to property inheritance Date: Tue, 25 Dec 2012 17:00:08 -0800 Message-ID: References: <87fw2uyfm7.fsf@bzg.ath.cx> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=00235429cb209ec33c04d1b6f319 Return-path: Received: from eggs.gnu.org ([208.118.235.92]:37834) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TnfLz-0002OZ-Rv for emacs-orgmode@gnu.org; Tue, 25 Dec 2012 20:00:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TnfLw-0000YW-Ln for emacs-orgmode@gnu.org; Tue, 25 Dec 2012 20:00:15 -0500 Received: from mail-qc0-f178.google.com ([209.85.216.178]:47954) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TnfLw-0000V6-Hm for emacs-orgmode@gnu.org; Tue, 25 Dec 2012 20:00:12 -0500 Received: by mail-qc0-f178.google.com with SMTP id j34so4198490qco.37 for ; Tue, 25 Dec 2012 17:00:08 -0800 (PST) In-Reply-To: <87fw2uyfm7.fsf@bzg.ath.cx> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Bastien Cc: emacs-orgmode --00235429cb209ec33c04d1b6f319 Content-Type: text/plain; charset=ISO-8859-1 While I'm figuring out how to create the patch and email it in the right format (I don't think I can with gmail), I've tried to make my bitbucket.orgrepository as public as possible. Perhaps give it another shot in the meantime. https://bitbucket.org/mrvwman/wishon-org-mode.git ~>Bill On Mon, Dec 24, 2012 at 7:28 PM, Bastien wrote: > Hi Bill, > > Bill Wishon writes: > > > My public git repository info is: git clone git@bitbucket.org:mrvwman > > /wishon-org-mode.git > > branch name: fix-property-inheritance > > I could not clone this repository, apparently I don't have enough > rights. Can you send a patch? > > Thanks, > > -- > Bastien > --00235429cb209ec33c04d1b6f319 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable While I'm figuring out how to create the patch and email it in the righ= t format (I don't think I can with gmail), I've tried to make my bitbucket.org
repository as public as po= ssible. =A0Perhaps give it another shot in the meantime.


~>Bill

On Mon, Dec 24, 2012 at 7= :28 PM, Bastien <bzg@altern.org> wrote:
Hi Bill,

Bill Wishon <bill@wishon.org> = writes:

> My public git repository info is:=A0git clone = git@bitbucket.org:mrvwman
> /wishon-org-mode.git
> branch name: fix-property-inheritance

I could not clone this repository, apparently I don't have enough=
rights. =A0Can you send a patch?

Thanks,

--
=A0Bastien

--00235429cb209ec33c04d1b6f319-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bastien Subject: Re: Fix to property inheritance Date: Sun, 30 Dec 2012 11:39:37 +0100 Message-ID: <877gnzddsm.fsf@bzg.ath.cx> References: <87fw2uyfm7.fsf@bzg.ath.cx> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([208.118.235.92]:42381) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TpGIv-0002rw-VK for emacs-orgmode@gnu.org; Sun, 30 Dec 2012 05:39:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TpGIu-00041V-G4 for emacs-orgmode@gnu.org; Sun, 30 Dec 2012 05:39:41 -0500 Received: from mail-we0-f169.google.com ([74.125.82.169]:54155) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TpGIu-00041P-9m for emacs-orgmode@gnu.org; Sun, 30 Dec 2012 05:39:40 -0500 Received: by mail-we0-f169.google.com with SMTP id t49so5639241wey.14 for ; Sun, 30 Dec 2012 02:39:39 -0800 (PST) In-Reply-To: (Bill Wishon's message of "Tue, 25 Dec 2012 17:00:08 -0800") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Bill Wishon Cc: emacs-orgmode Hi Bill, Bill Wishon writes: > While I'm figuring out how to create the patch and email it in the > right format (I don't think I can with gmail), I've tried to make my > bitbucket.org repository as public as possible.  Perhaps give it > another shot in the meantime. > > https://bitbucket.org/mrvwman/wishon-org-mode.git I confirm I can pull the repo correctly, thanks. -- Bastien From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bastien Subject: Re: Fix to property inheritance Date: Mon, 07 Jan 2013 18:35:42 +0100 Message-ID: <877gnoc2g8.fsf@bzg.ath.cx> References: Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([208.118.235.92]:45433) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TsGkx-0002eu-Si for emacs-orgmode@gnu.org; Mon, 07 Jan 2013 12:45:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TsGkr-0006SS-IT for emacs-orgmode@gnu.org; Mon, 07 Jan 2013 12:45:03 -0500 Received: from mail-we0-f175.google.com ([74.125.82.175]:55462) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TsGkr-0006S4-Ch for emacs-orgmode@gnu.org; Mon, 07 Jan 2013 12:44:57 -0500 Received: by mail-we0-f175.google.com with SMTP id z53so10363354wey.20 for ; Mon, 07 Jan 2013 09:44:56 -0800 (PST) In-Reply-To: (Bill Wishon's message of "Sat, 15 Dec 2012 22:24:30 -0800") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Bill Wishon , schulte eric Cc: emacs-orgmode Hi Bill, sorry for the late (and probably disappointing) reply. Bill Wishon writes: > This is my first major org-mode contribution, and I'm new to git, so > if there is something I haven't got quite right in terms of how to > contribute please advise. > > org-entry-get with inherit set didn't work for sub-heading additions > or overrides to properties found in parent headings as of Org-mode > version 7.9.2 (release_7.9.2-738-g442b2a-git @ org-loaddefs.el can > not be found!).   > > An example test org-mode file is attached (modified from the testing/ > examples directory and also updated in my git repository). Thanks for providing such a file with tests and examples. As far as I understand, problems are for cumulative properties, right? Eric, do you have time to check Bill's tests and see what's wrong with cumulative properties and inheritance? I'm not familiar enough with this part of the code to *enjoy* fixing this :) As for the patch themselves... 1) I did not receive confirmation from the FSF copyright clerk that your assignment is processed -- let me know if it is; 2) Please shrink commit messages and code lines to < 75 characters when possible. See org.el: we avoid long lines. This is not only for code readability, but also - and importantly here - for patch readability... If I overlooked a bug about something else than cumulative props, please let me know and let's have a separate fix for it. Thanks! -- Bastien From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bill Wishon Subject: Re: Fix to property inheritance Date: Mon, 7 Jan 2013 11:57:33 -0800 Message-ID: References: <877gnoc2g8.fsf@bzg.ath.cx> Mime-Version: 1.0 (1.0) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Return-path: Received: from eggs.gnu.org ([208.118.235.92]:47270) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TsIpI-00067x-Ls for emacs-orgmode@gnu.org; Mon, 07 Jan 2013 14:57:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TsIpF-0002ek-QD for emacs-orgmode@gnu.org; Mon, 07 Jan 2013 14:57:40 -0500 Received: from mail-pa0-f41.google.com ([209.85.220.41]:49746) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TsIpF-0002ec-KD for emacs-orgmode@gnu.org; Mon, 07 Jan 2013 14:57:37 -0500 Received: by mail-pa0-f41.google.com with SMTP id bj3so10996476pad.28 for ; Mon, 07 Jan 2013 11:57:36 -0800 (PST) In-Reply-To: <877gnoc2g8.fsf@bzg.ath.cx> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Bastien Cc: emacs-orgmode , schulte eric Hi Bastien, I'll edit the code and commit messages so they're < 75 chars. I'll check in again to see where the FSF process is at. And yes this is about property inheritance with accumulation. ~>Bill On Jan 7, 2013, at 9:35 AM, Bastien wrote: > Hi Bill, > > sorry for the late (and probably disappointing) reply. > > Bill Wishon writes: > >> This is my first major org-mode contribution, and I'm new to git, so >> if there is something I haven't got quite right in terms of how to >> contribute please advise. >> >> org-entry-get with inherit set didn't work for sub-heading additions >> or overrides to properties found in parent headings as of Org-mode >> version 7.9.2 (release_7.9.2-738-g442b2a-git @ org-loaddefs.el can >> not be found!). >> >> An example test org-mode file is attached (modified from the testing/ >> examples directory and also updated in my git repository). > > Thanks for providing such a file with tests and examples. > > As far as I understand, problems are for cumulative properties, > right? > > Eric, do you have time to check Bill's tests and see what's > wrong with cumulative properties and inheritance? I'm not familiar > enough with this part of the code to *enjoy* fixing this :) > > As for the patch themselves... > > 1) I did not receive confirmation from the FSF copyright clerk that > your assignment is processed -- let me know if it is; > > 2) Please shrink commit messages and code lines to < 75 characters > when possible. See org.el: we avoid long lines. This is not only > for code readability, but also - and importantly here - for patch > readability... > > If I overlooked a bug about something else than cumulative props, > please let me know and let's have a separate fix for it. > > Thanks! > > -- > Bastien From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bastien Subject: Re: Fix to property inheritance Date: Mon, 07 Jan 2013 21:10:50 +0100 Message-ID: <877gno69f9.fsf@bzg.ath.cx> References: <877gnoc2g8.fsf@bzg.ath.cx> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([208.118.235.92]:50186) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TsJ26-0000ov-Mw for emacs-orgmode@gnu.org; Mon, 07 Jan 2013 15:10:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TsJ25-0006Uj-3U for emacs-orgmode@gnu.org; Mon, 07 Jan 2013 15:10:54 -0500 Received: from mail-wg0-f49.google.com ([74.125.82.49]:38545) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TsJ24-0006UN-KU for emacs-orgmode@gnu.org; Mon, 07 Jan 2013 15:10:52 -0500 Received: by mail-wg0-f49.google.com with SMTP id 15so9802315wgd.28 for ; Mon, 07 Jan 2013 12:10:52 -0800 (PST) In-Reply-To: (Bill Wishon's message of "Mon, 7 Jan 2013 11:57:33 -0800") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Bill Wishon Cc: emacs-orgmode , schulte eric Hi Bill, Bill Wishon writes: > I'll edit the code and commit messages so they're < 75 chars. > > I'll check in again to see where the FSF process is at. > > And yes this is about property inheritance with accumulation. Great, *thanks*! -- Bastien