From: Eric Schulte <schulte.eric@gmail.com>
To: Bastien <bzg@gnu.org>
Cc: Achim Gratz <Stromeko@nexgo.de>, emacs-orgmode@gnu.org
Subject: Re: org-babel: two confirmations for org/HTML "macro"?
Date: Fri, 12 Apr 2013 16:37:27 -0600 [thread overview]
Message-ID: <87fvyvcqzk.fsf@gmail.com> (raw)
In-Reply-To: 87d2u1v4rn.fsf@bzg.ath.cx
Bastien <bzg@gnu.org> writes:
> Hi Achim,
>
> Achim Gratz <Stromeko@nexgo.de> writes:
>
>> Bastien writes:
>>> (Sorry, I pushed a fix for the compiler warning that your patch also
>>> solves.)
>>
>> Not in master, though?
>
> Yes -- pushed this morning.
>
>>> Achim Gratz <Stromeko@nexgo.de> writes:
>>>
>>>> Since the test suite doesn't really test confirmation at all, it would
>>>> be nice if someone with a good variety of Babel calls could check if the
>>>> number of confirmations stay the same with and without the patch. I
>>>> don't think I have test cases that cover all possible combinations.
>>>
>>> Please let's go and apply this, that's the best way to have more
>>> people testing it. Thanks!
>>
>> Please wait for Eric to chime in.
>
> All right. Copying Eric for the heads-up.
>
After walking through this patch, it looks like it provides exactly the
correct behavior. Please go ahead and apply these changes.
Thanks Achim for the patch!
--
Eric Schulte
http://cs.unm.edu/~eschulte
next prev parent reply other threads:[~2013-04-12 22:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-28 9:35 org-babel: two confirmations for org/HTML "macro"? Stefan Vollmar
2013-04-10 12:53 ` Bastien
2013-04-10 18:43 ` Achim Gratz
2013-04-10 23:34 ` Bastien
2013-04-11 5:22 ` Achim Gratz
2013-04-11 8:41 ` Bastien
2013-04-12 22:37 ` Eric Schulte [this message]
2013-04-13 6:37 ` Achim Gratz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fvyvcqzk.fsf@gmail.com \
--to=schulte.eric@gmail.com \
--cc=Stromeko@nexgo.de \
--cc=bzg@gnu.org \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).