emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Matt Lundin <mdl@imapmail.org>
Cc: Org Mode <emacs-orgmode@gnu.org>
Subject: Re: [BUG] org clock history no longer loaded from org-clock-persist-file
Date: Wed, 06 Jan 2016 15:10:26 +0100	[thread overview]
Message-ID: <87fuyau7cd.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <8760z98inz.fsf@fastmail.fm> (Matt Lundin's message of "Mon, 04 Jan 2016 09:32:16 -0600")

Hello,

Matt Lundin <mdl@imapmail.org> writes:

> With the shift to lexical-binding in org-clock.el (commit
> 35bc1c8853c5cfe37930e3540a944a328af5198b), the function org-load-clock
> fails to load the stored data in org-clock-persist-file.
>
> These are the relevant setting in my .emacs:
>
> (setq org-clock-persist t)
> (setq org-clock-persist-file "~/data/org-clock-save.el")
> (org-clock-persistence-insinuate)
>
> Expected result: After calling the agenda for the first time, the
> variable org-clock-history is populated with data.
>
> Actual result: org-clock-history remains nil.
>
> As far as I can tell, the problem lies with the call to load-file (line
> 2986). Because of the lexical binding, the (setq stored-clock-history
> ....) statement stored in the org-clock-persist-file is evaluated but
> because of the lexical scoping it has no effect on the
> stored-clock-history in org-clock-load.

Fixed. Thank you for the detailed report.

Regards,

-- 
Nicolas Goaziou

      reply	other threads:[~2016-01-06 14:08 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-04 15:32 [BUG] org clock history no longer loaded from org-clock-persist-file Matt Lundin
2016-01-06 14:10 ` Nicolas Goaziou [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fuyau7cd.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=emacs-orgmode@gnu.org \
    --cc=mdl@imapmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).