unofficial mirror of emacs-orgmode@gnu.org
 help / color / mirror / Atom feed
* Bug: [PATCH] org-agenda: "Invalid face reference: t" errors [9.4 (release_9.4-49-g4b150d @ /home/n/.emacs.d/straight/build/org/)]
@ 2020-10-06  5:44 No Wayman
  2020-10-06 21:38 ` Samuel Wales
  2020-10-07  4:50 ` Kyle Meyer
  0 siblings, 2 replies; 3+ messages in thread
From: No Wayman @ 2020-10-06  5:44 UTC (permalink / raw)
  To: emacs-orgmode

[-- Attachment #1: Type: text/plain, Size: 878 bytes --]


I noticed recently that my message buffer was getting clobbered 
with thousands of Invalid face reference errors when moving point 
around an org-agenda buffer. e.g.:

> Invalid face reference: t [4519 times]

Git bisect points to commit 
7a12e149907b5921011710d869b7554c35859c89

> org.el (org-display-outline-path): Fix faces of the message
>
> * lisp/org.el (org-display-outline-path): Set :height as the
> default face height, and don't change other face attributes.
>
> See a3576543f for a previous fix, and this discussion:
> <https://orgmode.org/list/21ef0e94-e766-455c-a45c-fe30e316c121@Spark>

As a workaround, setting `org-agenda-show-outline-path' to nil 
prevents the errors.
I believe the face spec in the call to `add-face-text-property' in 
`org-display-outline-path' is incorrect.
The attached patch replaces it with an anonymous face, which works 
on my end.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: org-agenda-invalid-face-ref-fix --]
[-- Type: text/x-patch, Size: 943 bytes --]

From 4b150d7ca3f8d7d9fe30f6b562b35a5f4072e5e1 Mon Sep 17 00:00:00 2001
From: Nicholas Vollmer <iarchivedmywholelife@gmail.com>
Date: Tue, 6 Oct 2020 01:30:09 -0400
Subject: [PATCH] org.el (org-display-outline-path): Fix invalid face reference
 error

* lisp/org.el (org-display-outline-path): Use an anonymous face when
adding default :height to outline path
---
 lisp/org.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/org.el b/lisp/org.el
index 425e9391b..beb830b36 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -8057,7 +8057,7 @@ If JUST-RETURN-STRING is non-nil, return a string, don't display a message."
 	   (and file bfn (concat (file-name-nondirectory bfn) separator))
 	   separator))
     (add-face-text-property 0 (length res)
-			    `((t :height ,(face-attribute 'default :height)))
+			    `(:height ,(face-attribute 'default :height))
 			    nil res)
     (if just-return-string
 	res
-- 
2.28.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Bug: [PATCH] org-agenda: "Invalid face reference: t" errors [9.4 (release_9.4-49-g4b150d @ /home/n/.emacs.d/straight/build/org/)]
  2020-10-06  5:44 Bug: [PATCH] org-agenda: "Invalid face reference: t" errors [9.4 (release_9.4-49-g4b150d @ /home/n/.emacs.d/straight/build/org/)] No Wayman
@ 2020-10-06 21:38 ` Samuel Wales
  2020-10-07  4:50 ` Kyle Meyer
  1 sibling, 0 replies; 3+ messages in thread
From: Samuel Wales @ 2020-10-06 21:38 UTC (permalink / raw)
  To: No Wayman; +Cc: emacs-orgmode

i can confirm these errors in maint [didn't confirm the patch or
workaround].  thanks for debugging what i could not.


On 10/5/20, No Wayman <iarchivedmywholelife@gmail.com> wrote:
>
> I noticed recently that my message buffer was getting clobbered
> with thousands of Invalid face reference errors when moving point
> around an org-agenda buffer. e.g.:
>
>> Invalid face reference: t [4519 times]
>
> Git bisect points to commit
> 7a12e149907b5921011710d869b7554c35859c89
>
>> org.el (org-display-outline-path): Fix faces of the message
>>
>> * lisp/org.el (org-display-outline-path): Set :height as the
>> default face height, and don't change other face attributes.
>>
>> See a3576543f for a previous fix, and this discussion:
>> <https://orgmode.org/list/21ef0e94-e766-455c-a45c-fe30e316c121@Spark>
>
> As a workaround, setting `org-agenda-show-outline-path' to nil
> prevents the errors.
> I believe the face spec in the call to `add-face-text-property' in
> `org-display-outline-path' is incorrect.
> The attached patch replaces it with an anonymous face, which works
> on my end.
>
>


-- 
The Kafka Pandemic

Please learn what misopathy is.
https://thekafkapandemic.blogspot.com/2013/10/why-some-diseases-are-wronged.html


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Bug: [PATCH] org-agenda: "Invalid face reference: t" errors [9.4 (release_9.4-49-g4b150d @ /home/n/.emacs.d/straight/build/org/)]
  2020-10-06  5:44 Bug: [PATCH] org-agenda: "Invalid face reference: t" errors [9.4 (release_9.4-49-g4b150d @ /home/n/.emacs.d/straight/build/org/)] No Wayman
  2020-10-06 21:38 ` Samuel Wales
@ 2020-10-07  4:50 ` Kyle Meyer
  1 sibling, 0 replies; 3+ messages in thread
From: Kyle Meyer @ 2020-10-07  4:50 UTC (permalink / raw)
  To: No Wayman; +Cc: emacs-orgmode

No Wayman writes:

> I noticed recently that my message buffer was getting clobbered 
> with thousands of Invalid face reference errors when moving point 
> around an org-agenda buffer. e.g.:
>
>> Invalid face reference: t [4519 times]
[...]
> I believe the face spec in the call to `add-face-text-property' in 
> `org-display-outline-path' is incorrect.
> The attached patch replaces it with an anonymous face, which works 
> on my end.

Yeah, I'd guess the invalid (t ...) slipped in because of the
(DISPLAY . PLIST) used for defface.

Applied (f0902bf18), appending a period to your changelog description.

Thanks.


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-10-07  4:51 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-06  5:44 Bug: [PATCH] org-agenda: "Invalid face reference: t" errors [9.4 (release_9.4-49-g4b150d @ /home/n/.emacs.d/straight/build/org/)] No Wayman
2020-10-06 21:38 ` Samuel Wales
2020-10-07  4:50 ` Kyle Meyer

unofficial mirror of emacs-orgmode@gnu.org

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://yhetil.org/orgmode/0 orgmode/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 orgmode orgmode/ https://yhetil.org/orgmode \
		emacs-orgmode@gnu.org
	public-inbox-index orgmode

Example config snippet for mirrors.
Newsgroups are available over NNTP:
	nntp://news.yhetil.org/yhetil.emacs.orgmode
	nntp://news.gmane.io/gmane.emacs.orgmode


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git