From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id gIbWBCQvkmG4KwEAgWs5BA (envelope-from ) for ; Mon, 15 Nov 2021 10:57:56 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id GEiaACQvkmH+BgAAB5/wlQ (envelope-from ) for ; Mon, 15 Nov 2021 09:57:56 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A1A6C24AA0 for ; Mon, 15 Nov 2021 10:57:55 +0100 (CET) Received: from localhost ([::1]:51002 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mmYkL-0003EQ-UG for larch@yhetil.org; Mon, 15 Nov 2021 04:57:53 -0500 Received: from eggs.gnu.org ([209.51.188.92]:41090) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mmYjY-00037T-Eb for emacs-orgmode@gnu.org; Mon, 15 Nov 2021 04:57:04 -0500 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:50181) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mmYjV-0005I5-KZ for emacs-orgmode@gnu.org; Mon, 15 Nov 2021 04:57:03 -0500 Received: (Authenticated sender: admin@nicolasgoaziou.fr) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 280CE60009; Mon, 15 Nov 2021 09:56:57 +0000 (UTC) From: Nicolas Goaziou To: Ihor Radchenko Subject: Re: c47b535bb origin/main org-element: Remove dependency on =?utf-8?Q?=E2=80=98org-emphasis-regexp-components=E2=80=99?= References: <87o86mw86r.fsf@localhost> Date: Mon, 15 Nov 2021 10:56:49 +0100 In-Reply-To: <87o86mw86r.fsf@localhost> (Ihor Radchenko's message of "Mon, 15 Nov 2021 08:53:32 +0800") Message-ID: <87fsrxkahq.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=217.70.183.195; envelope-from=mail@nicolasgoaziou.fr; helo=relay3-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1636970275; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=IlUyVYm39PDmVDQQ0ThRnxHXjVtBGxv+NUBQUpT5z48=; b=Tld9VmOaXFWESiqgU0nKElDtz5A1tqxDgXnKcl0xEuzhZ+vxXjjfxDl49U+O2m7VlsoeEG PjLHrPHM3aG7z/NXNVlovMuY4344vVPd0QNjc1n1FIylvxWXcwFKeinD66OScghsnU24oo W2j48VC7Y+WYvQisWalKGKf2wZUa4IX+kbZbteCAWsjNZb+562pH0fMt2vF8e7EStTF4iL /X64D7fMIvTUoJPfyP+qfUp9N4KVaEP6Yo9AZVRDHFb76Rab1OnPuHAjJZzSQWEMGkqt3f SYs3UzdsEzx3gFo37Tzaja0yHBRkrxcznIsxWPY15FsW0zpyjd2T/VnzB+9sew== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1636970275; a=rsa-sha256; cv=none; b=dSOKQGoJwtyJgnuQc4CrtZR9HmD+uL0ej7dzFnC03B7cbiRCDdiOnU1qL4OHhSyEgj5lWS MZptyW69OlVMMMqp3VgpFcR7lZJGrTUbDEKxH8V19LQY8qvdb4gt4NZZOgwEbbdOgxNI48 ui4dAirg1F5Jjcb+kx2TlxUjLjpZzCYXJGy0winEmxqZkn6ka4zITqZnRIzNRrQmkVlx2U SccCllYBaz5qOsYf2KXa1tQCBp8fNbkOJiyOjFToMrU/NKBlrrWCQIS5Gd1U0A498OJZjo PkkSxYrhHIREf7wn3LvdrSUxMDRJqn8ffv1Iwa/iOce0wsicL0uYYeiCW4TOcg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -2.94 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: A1A6C24AA0 X-Spam-Score: -2.94 X-Migadu-Scanner: scn1.migadu.com X-TUID: +h0G4H9sIjH9 Hello, Ihor Radchenko writes: > This commit may cause random failures when > org-emphasis-regexp-components is changed by user. This is not supported anyway. > org-emph-re is calculated according to org-emphasis-regexp-components. > Changing org-emphasis-regexp-components can make "(when (looking-at > org-emph-re)" in parsers return nil. The emphasised text will still be > fontified, but not available in the parsed buffer. That=E2=80=99s exactly my point. The syntax is not meant to be configurable. I wrote a patch also removing =E2=80=98org-emph-re=E2=80=99 depedency from "org-element.el", but I was delayed. I just applied it. > Maybe we need to move the logic for org-emph-re from org.el to > org-element.el? =E2=80=98org-emph-re=E2=80=99 has some limitations which do not belong to s= yntax definition. There=E2=80=99s no point in adding it in "org-element.el". The grand scheme is to remove most "org.el" dependencies from "org-element.el", and move the others. > Also, there is org-emphasis-alist. It is even defcustom, but ignored by > org-element.el. This variable is a defcustom for the faces, not the markers. I.e., it is not meant to add, remove, or change emphasis markup, but rather alter how they appear. IMO, this should be removed altogether: it=E2=80=99s up to a theme to set such a thing. Regards, --=20 Nicolas Goaziou