From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id gF05B/157WJmdAAAbAwnHQ (envelope-from ) for ; Fri, 05 Aug 2022 22:13:49 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id 8ItQBv157WJV5QAAG6o9tA (envelope-from ) for ; Fri, 05 Aug 2022 22:13:49 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6A30229356 for ; Fri, 5 Aug 2022 22:13:48 +0200 (CEST) Received: from localhost ([::1]:56552 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oK3hb-0005F9-7c for larch@yhetil.org; Fri, 05 Aug 2022 16:13:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40532) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oK3gu-0005Em-P2 for emacs-orgmode@gnu.org; Fri, 05 Aug 2022 16:13:04 -0400 Received: from out1.migadu.com ([91.121.223.63]:21743) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oK3gs-00075d-4V for emacs-orgmode@gnu.org; Fri, 05 Aug 2022 16:13:04 -0400 References: <20220803190245.26056-1-joseph@breatheoutbreathe.in> <87zggjnudw.fsf@localhost> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=breatheoutbreathe.in; s=key1; t=1659730378; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Igux1ERMSqqiBj+kjsEmEvKx9cObaRpoklMTLeYug3E=; b=UNkv7ETiTGvRsecnT6AfBjlSWggLY6aC2gSCoy7mIuSb4ri8iALKyZi0lVS9aJ1bpcHVxb JlKTQ2OXRbYYmVhVaGSOZmpRfCRT5NegTcziJ/eQLaXh713nBsFDQzqNhxhmDSZVIHZxoN ihH3W5jsZHSIZxjjJ/ds73xsBUYb6og= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Joseph Turner To: Ihor Radchenko Cc: emacs-orgmode@gnu.org Subject: Re: [PATCH v2] lisp/ob-plantuml.el: Insert results in buffer Date: Fri, 05 Aug 2022 13:10:55 -0700 In-reply-to: <87zggjnudw.fsf@localhost> Message-ID: <87fsiajvp5.fsf@breatheoutbreathe.in> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=91.121.223.63; envelope-from=joseph@breatheoutbreathe.in; helo=out1.migadu.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1659730428; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=Igux1ERMSqqiBj+kjsEmEvKx9cObaRpoklMTLeYug3E=; b=maPevnrsICkOBT/oTgoLuJ6lb7Ze5Tuuq/ELA3To0F+DDw3PioPoip831O3xqcC62A76Wv 8nTVD04yqth2A/87vG7QlzHRhaPo88bNSMosz1r12AxqG69cN2XpIDiRVAXewFr4JY7gyf 8KKAc39OHR4sotxwpFmg+Ke380EIpj/7C/godyjRCR7Tc2Vl0xT0cfaXS25/hStgdzWmKd grtCLlnJd/CPtgO0yD44ob6xRaJaCmWNMhxGhwdoE1plzKR33zvTV8kUsHVTkUfthbzh8P 8l864Gfd1NOuw7CqSUs/62+wuhb6zP1LnCV/xfe4d57DGblfqtAmVzBN21I7HQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1659730428; a=rsa-sha256; cv=none; b=MPxfu3Gf5SbsYIKGYbfWWlzF0RfnU45/udRQURSZyDyi1wnoB0Kw499+FJli0rWDnCVDLg 0RSnqJnfJeJpuYIoOAJpgacUAKb2ZwnoOubOIdPXaKDC5cEbgtj03NliV9tyBSYOVni1CX W/wPCs8sCevlSAGdGRMk2/HJZrMuaCDTvrf5EFCuPQrwHYTznbG0/rzMIQta3i7zR4b8mP ybOErtfCoQ3ll2BhSZOaazuxP92ztXF3W5yt6c5k8qZngAuz0BLGZ0RTdqCMysm3YasPDh O01dOfFjSEt+ZDgPxfr4qSega6R5K1sJ56jE7DVi2qWqFecZrIoBoeiPnjvslA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=breatheoutbreathe.in header.s=key1 header.b=UNkv7ETi; dmarc=pass (policy=quarantine) header.from=breatheoutbreathe.in; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.80 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=breatheoutbreathe.in header.s=key1 header.b=UNkv7ETi; dmarc=pass (policy=quarantine) header.from=breatheoutbreathe.in; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 6A30229356 X-Spam-Score: -3.80 X-Migadu-Scanner: scn0.migadu.com X-TUID: x2t2L5i0nk2c Ihor Radchenko writes: > Let's take this opportunity and fix another omission in ob-plantuml. > :results may generally contain Elisp sexps to be evaluated and the whole > split-string busyness is not accurate. Please use :result-params list > instead of :results. Good catch! I will submit a v3 patch. Is this still a TINYCHANGE or shall I do a copyright assignment? > Also, can you please update the ob-plantuml documentation according to > the changes made. The current version is in > https://orgmode.org/worg/org-contrib/babel/languages/ob-doc-plantuml.html Gladly. Best, Joseph