From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id qEwSCEa2/GKIZgAAbAwnHQ (envelope-from ) for ; Wed, 17 Aug 2022 11:35:02 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id UHbIB0a2/GKYegAAauVa8A (envelope-from ) for ; Wed, 17 Aug 2022 11:35:02 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C6D8D1DA04 for ; Wed, 17 Aug 2022 11:35:01 +0200 (CEST) Received: from localhost ([::1]:55262 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oOFS0-0003W0-KI for larch@yhetil.org; Wed, 17 Aug 2022 05:35:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38226) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oOFQ5-0003U0-SA for Emacs-orgmode@gnu.org; Wed, 17 Aug 2022 05:33:02 -0400 Received: from mail-pg1-x535.google.com ([2607:f8b0:4864:20::535]:36747) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oOFQ4-0006C8-7H for Emacs-orgmode@gnu.org; Wed, 17 Aug 2022 05:33:01 -0400 Received: by mail-pg1-x535.google.com with SMTP id s206so11524238pgs.3 for ; Wed, 17 Aug 2022 02:32:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc; bh=ge+3FcqJ8KM1VUOpJkNJsx7TT47AnZryAkU4332/1uU=; b=etBxDQu5H+GbnpPeQhUd0+bPGTxz6esm+FoZBfF7DqPpCbtbVXHZnBejuxjhciPhkN HiHLdaY4QcuRiesIuQaTtlefz9oyRijTu/lB39OXF3dWsg80WgKLI4kzBjcxaaFexrGp qm0pICrH5d2z87Knb3QB0zCH1+lZAL4LZU7M0V3LupbNyka5+ATwxcqULnKbkPR5ONGH 1YGthqCBGOaIz8xQADD6OD1JCGNo//l4bXF8e1GAdUPotCDej4BsXh8nkmTjOx1GopRY FLTNY96Rm5DjUXj/ePlW7taYGVMB46jLLWq9/hvjzk+ARQaWcUUpYgOUFyWrM5fWkY4W TaXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc; bh=ge+3FcqJ8KM1VUOpJkNJsx7TT47AnZryAkU4332/1uU=; b=hZD6HcVdFDSdxjFAHAkcjVFFt3NyFk/zgua8paNzss0YUjRriJKIEwjn2wdYOw9Jms C27Nihu+EYM4aR3hs58J09qZjW4FCIXXON9sOLyaizRFKTSEs/U5x6p+wn6t6DdI7vHf jZTNUUHN8z4rXU69GTRhb6z8FPa26pLAFaS9TSDqRVogX/KiGojLL/jBlUCBDP/OMYoF /CHM1pi4mJnOt1qYhm/Mf6PW1D25Lk4VJnGUk5gQ+fU1qfDwTGf8onS720Dtju7WpZ+Y uw77Ed6X01m5Fp67DyBhzfL/AddS0DevVmZUCPSbG51uieNZASvyfqYoLpeOq27HFnqA WSCA== X-Gm-Message-State: ACgBeo0nmFO03cBMMq3rBf7JSH8JusO+92+7yvy2EJLrvdtnQTBHJP0z ZzCuRzfEwosVHHtWtE9AxtI= X-Google-Smtp-Source: AA6agR6h+T81vXwQC0mOLeax+qVY0WeW+GEzD8UwtKBbF2fCbKcEye9eV9AtzO1G4iFK9Yj8iYKU2w== X-Received: by 2002:a63:83c2:0:b0:429:a2aa:b651 with SMTP id h185-20020a6383c2000000b00429a2aab651mr6029553pge.500.1660728778539; Wed, 17 Aug 2022 02:32:58 -0700 (PDT) Received: from localhost ([115.154.175.57]) by smtp.gmail.com with ESMTPSA id u20-20020a62d454000000b00534c32592fasm6093720pfl.146.2022.08.17.02.32.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Aug 2022 02:32:57 -0700 (PDT) From: Ihor Radchenko To: Duy Nguyen Cc: Emacs-orgmode@gnu.org Subject: Re: [PATCH v2] Show org file title in org-clock clocktable In-Reply-To: References: <87edxk7etq.fsf@localhost> <87tu6g5qbp.fsf@localhost> Date: Wed, 17 Aug 2022 17:34:02 +0800 Message-ID: <87fshv1aet.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::535; envelope-from=yantar92@gmail.com; helo=mail-pg1-x535.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1660728901; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=ge+3FcqJ8KM1VUOpJkNJsx7TT47AnZryAkU4332/1uU=; b=iBKNIJO6O32E0q/tT8/0NKBzNopBDrhu0DsIcQpf7zGXQ5eNDzGrNqglctgQpdiVPZeEWH pljOfAk4JOodsIxALatAOluhL1XA+KeoHNdCY+Ma46FRUodCfTA8JlEAHWTVxPxWpQWm5b UoprWUKY/v1vqzaGy0x68LgIj0xDWpT6ECubTAXsR/fSn1CIDfhb5jsNRQHkFbC8UXJ3D6 ju8kF7D8oF13Qv8X1Ei4OjJPBUqG9nPOudpb7QuOiR3QsrYNxhCwnLGk8MrCQhBaGoOY/f j8JUAV3ygboOENohzAUu0fi4pBZ6Sbs95d6JFXqJTjAQxp3vyTYoGSpfZOOxwg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1660728901; a=rsa-sha256; cv=none; b=iKzKFoyRW4pJ/WPzO/4+BMqVvs/UdABKtWUHuoROIjjkt75XENffYsXKq/z6UGmHz2AJot ta9H9MvXT9gcKZ4qEDKMyGx59WPwyzzl9pEnH5M95IXyANVcYMEEDnUcmjjkqN74hWvnjv KfvQBldqJqYdd2ecatdVPI5n2VSyyCBzS26LcCNO0eDR1yuADF500kYsWOEVqXkJlXxuwY OkRpLRyYJelN9pW1rG07kUckhG86402WgjcZnXTNtFebfARoXmFT0j+E+CMIsd7NalZ2k2 O6thY6kB/6gJ/F8xffFaWiVZJUbyRjT4Vvfk1M+U9jN2WRfzi/rPheJKDYotpQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=etBxDQu5; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.66 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=etBxDQu5; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: C6D8D1DA04 X-Spam-Score: -3.66 X-Migadu-Scanner: scn0.migadu.com X-TUID: aRbx2V3THV9u Duy Nguyen writes: > Thank you once again for your comments Ihor. Please find attached a new > patch with your comments addressed. Thanks! > + (let ((macros (org-macro--collect-macros))) > + (let ((title (assoc-default "title" macros))) It is not a good idea to call internal function (with "--" in name) from a different file. Such functions are a subject of change without notice. `org-macro-templates' is always initialized when Org mode is active, and you can rely on its value. -- Ihor Radchenko, Org mode contributor, Learn more about Org mode at https://orgmode.org/. Support Org development at https://liberapay.com/org-mode, or support my work at https://liberapay.com/yantar92