From: Ihor Radchenko <yantar92@posteo.net>
To: Daniel Ziltener <dziltener@lyrion.ch>
Cc: emacs-orgmode@gnu.org
Subject: Re: [BUG] ob-scheme: geiser command has changed [9.6 (9.6-??-86c4635 @ /home/zilti/.emacs.d/.local/straight/build-27.2/org/)]
Date: Wed, 19 Oct 2022 04:21:01 +0000 [thread overview]
Message-ID: <87fsfkcuky.fsf@localhost> (raw)
In-Reply-To: <b0c62bc5-468a-31ce-2a42-c67c57117865@lyrion.ch>
[-- Attachment #1: Type: text/plain, Size: 296 bytes --]
Daniel Ziltener <dziltener@lyrion.ch> writes:
> The latest Geiser release 0.26 got rid of the "run-geiser" function. It
> is sufficient to just replace the call to "run-geiser" with "geiser"
> instead to make ob-scheme work again.
Thanks for reporting!
Can you try the attached (blind) patch?
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-ob-scheme-Use-new-function-name-geiser-instead-of-de.patch --]
[-- Type: text/x-patch, Size: 1819 bytes --]
From 2565c66ed06e30885ee884d52eac824e23d55707 Mon Sep 17 00:00:00 2001
Message-Id: <2565c66ed06e30885ee884d52eac824e23d55707.1666153213.git.yantar92@posteo.net>
From: Ihor Radchenko <yantar92@posteo.net>
Date: Wed, 19 Oct 2022 12:18:00 +0800
Subject: [PATCH] ob-scheme: Use new function name `geiser' instead of
deprecated `run-geiser'
* lisp/ob-scheme.el (geiser): Declare function.
(org-babel-scheme-get-repl): Use `geiser' when available.
Reported-by: Daniel Ziltener <dziltener@lyrion.ch>
Link: https://orgmode.org/list/b0c62bc5-468a-31ce-2a42-c67c57117865@lyrion.ch
---
lisp/ob-scheme.el | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/lisp/ob-scheme.el b/lisp/ob-scheme.el
index 8e3d48c32..00c50d63d 100644
--- a/lisp/ob-scheme.el
+++ b/lisp/ob-scheme.el
@@ -55,7 +55,11 @@ (defvar geiser-debug-jump-to-debug-p) ; Defined in geiser-debug.el
(defvar geiser-repl-use-other-window) ; Defined in geiser-repl.el
(defvar geiser-repl-window-allow-split) ; Defined in geiser-repl.el
+;; FIXME: `run-geiser' is obsolete since Geiser 0.26. `geiser' is the
+;; new name.
(declare-function run-geiser "ext:geiser-repl" (impl))
+(declare-function geiser "ext:geiser-repl" (impl))
+
(declare-function geiser-mode "ext:geiser-mode" ())
(declare-function geiser-eval-region "ext:geiser-mode"
(start end &optional and-go raw nomsg))
@@ -120,7 +124,10 @@ (defun org-babel-scheme-get-repl (impl name)
(let ((buffer (org-babel-scheme-get-session-buffer name)))
(or buffer
(progn
- (run-geiser impl)
+ (if (fboundp 'geiser)
+ (geiser impl)
+ ;; FIXME: Obsolete since Geiser 0.26.
+ (run-geiser impl))
(when name
(rename-buffer name t)
(org-babel-scheme-set-session-buffer name (current-buffer)))
--
2.35.1
[-- Attachment #3: Type: text/plain, Size: 225 bytes --]
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
next prev parent reply other threads:[~2022-10-19 4:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-18 19:41 [BUG] ob-scheme: geiser command has changed [9.6 (9.6-??-86c4635 @ /home/zilti/.emacs.d/.local/straight/build-27.2/org/)] Daniel Ziltener
2022-10-19 4:21 ` Ihor Radchenko [this message]
2022-11-13 12:30 ` Ihor Radchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fsfkcuky.fsf@localhost \
--to=yantar92@posteo.net \
--cc=dziltener@lyrion.ch \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).