From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id UAIvAYQYXmMozgAAbAwnHQ (envelope-from ) for ; Sun, 30 Oct 2022 07:24:04 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id EIb/AIQYXmOK1QAA9RJhRA (envelope-from ) for ; Sun, 30 Oct 2022 07:24:04 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B6EDDA301 for ; Sun, 30 Oct 2022 07:24:03 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1op1iv-0005zx-2i; Sun, 30 Oct 2022 02:23:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1op1it-0005zn-2L for emacs-orgmode@gnu.org; Sun, 30 Oct 2022 02:23:07 -0400 Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1op1ir-00078B-1c for emacs-orgmode@gnu.org; Sun, 30 Oct 2022 02:23:06 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 030AA240026 for ; Sun, 30 Oct 2022 07:23:01 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1667110983; bh=MaDXmhkFSBWBaC/NTKZpKVzXm2dR22lEkJpujdmaZ3Q=; h=From:To:Cc:Subject:Date:From; b=MaUGyRN2rdOkbefbzheQ3qqDiWyHt7bjgg2vDWP3o6s4+cwjSZ1YdCULcZBTQ1I7g yDc5cH+Zq9zrNH3G/zCSxM18xRgDW7/ogm8JRYgXoS61kbngOiGWUl7P3D4SaAMZ9+ r4FPAclhn2nHEcqwnuL/SD6Uxg//YYf67EdsBLKjuL/zw/1sJ70gsTH+V8QBmUGK2j aJ7BVQIAn+VrngMJ8LKRDKNcoV8/mKrqWx0MrrfZuC+2VHDHLPcDdA5grBDY0E/q/8 3AiwvZU79bmhUP2jZ70veEXoUd93rw1Spf+Ng2rvgqUpUUz5b9NZpa0xdR0HELfTQF 7sWdNe/ZqftMA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4N0R6X592rz9rxD; Sun, 30 Oct 2022 07:23:00 +0100 (CET) From: Ihor Radchenko To: Joseph Turner Cc: Ihor Radchenko , emacs-orgmode@gnu.org Subject: Re: [PATCH v2] lisp/ob-plantuml.el: Insert results in buffer In-Reply-To: <87fsiajvp5.fsf@breatheoutbreathe.in> References: <20220803190245.26056-1-joseph@breatheoutbreathe.in> <87zggjnudw.fsf@localhost> <87fsiajvp5.fsf@breatheoutbreathe.in> Date: Sun, 30 Oct 2022 06:23:44 +0000 Message-ID: <87fsf5aky7.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.65; envelope-from=yantar92@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Emacs-orgmode" Errors-To: emacs-orgmode-bounces+larch=yhetil.org+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1667111043; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=fZVVwXgVuzSi183yfhKD/FoR1JI2FULmPWzraSbNXws=; b=JroxASqfU7BLvjECmsBCkV2IKXJv46d6ok5WuPZZ4carWTgDrsj01f+8SMN4Qpp/crLneL uOfo2jNPlhklYJXKTCeaAp8MAL+m9CxItqxte4bxMDCaUvqcGOjGHGc8I0c6L53IxPidY8 SmM07rl/bCq47ALe3ZIPdhQf6biCbh4aOx0hLu2DOikOKgrZxDh21whfEX4gHR2sFq3MaI hOON8Meerv2IN/g0NDlJ0K9crebEeEdGy6tH5xqihQ5Y6yXcqMh//0+ybZKPOLReBIurCo wIRoZUG0YKobAvkmdJVb0m4RvELb+npqPvEnAs3ZR8XHvoPxoP50Kx51m5Hj8A== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1667111043; a=rsa-sha256; cv=none; b=r0pF/RcxyzaykWqXLFrkfpMbkBsusneS4zfUoVWT5myJYkyGMnMnxx2xjX6EaXm3tx3y8b K6oi41fj9uXBNiCvAsYXknxiiSUUwKV5bu4Oet+4LJFMUQONPviq2lF4dqYftPwbTLsOX4 +r3flquQfW6o+F5s0nZLMMVdunfIIVUasIEFU1JiCJwz/tbjzuqwLrHvd6u8SDsJeRLVkD LIuuBONO2l81MigSqE+54OH5tD8SoqbGuOhk0243G8GT0qdJ8vI9iNU55vOuYwai84+dty m14wapAsfPlCxyV5Bzm5Q1xcJY30jE5Qtp+CiaMaNBB7nEnEBGsNSUZHE37xtA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=MaUGyRN2; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.64 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=MaUGyRN2; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: B6EDDA301 X-Spam-Score: -3.64 X-Migadu-Scanner: scn1.migadu.com X-TUID: 20DxjES5o1mh Joseph Turner writes: > Ihor Radchenko writes: > >> Let's take this opportunity and fix another omission in ob-plantuml. >> :results may generally contain Elisp sexps to be evaluated and the whole >> split-string busyness is not accurate. Please use :result-params list >> instead of :results. > > Good catch! I will submit a v3 patch. Did you have a chance to work on the patch? -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at