From: Ihor Radchenko <yantar92@posteo.net>
To: Joseph Turner <joseph@breatheoutbreathe.in>
Cc: Ihor Radchenko <yantar92@gmail.com>, emacs-orgmode@gnu.org
Subject: Re: [PATCH v2] lisp/ob-plantuml.el: Insert results in buffer
Date: Sun, 30 Oct 2022 06:23:44 +0000 [thread overview]
Message-ID: <87fsf5aky7.fsf@localhost> (raw)
In-Reply-To: <87fsiajvp5.fsf@breatheoutbreathe.in>
Joseph Turner <joseph@breatheoutbreathe.in> writes:
> Ihor Radchenko <yantar92@gmail.com> writes:
>
>> Let's take this opportunity and fix another omission in ob-plantuml.
>> :results may generally contain Elisp sexps to be evaluated and the whole
>> split-string busyness is not accurate. Please use :result-params list
>> instead of :results.
>
> Good catch! I will submit a v3 patch.
Did you have a chance to work on the patch?
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
next prev parent reply other threads:[~2022-10-30 6:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-03 19:02 [PATCH v2] lisp/ob-plantuml.el: Insert results in buffer Joseph Turner
2022-08-05 5:15 ` Ihor Radchenko
2022-08-05 20:10 ` Joseph Turner
2022-08-06 8:19 ` Ihor Radchenko
2022-10-30 6:23 ` Ihor Radchenko [this message]
2022-10-31 6:02 ` Ihor Radchenko
2022-10-31 19:20 ` Joseph Turner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fsf5aky7.fsf@localhost \
--to=yantar92@posteo.net \
--cc=emacs-orgmode@gnu.org \
--cc=joseph@breatheoutbreathe.in \
--cc=yantar92@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).