* [BUG/FR] org-plot: replot on resize [9.7-pre (N/A @ /home/viz/lib/emacs/straight/build/org/)]
@ 2024-05-30 9:28 Visuwesh
2024-06-04 13:09 ` Ihor Radchenko
0 siblings, 1 reply; 8+ messages in thread
From: Visuwesh @ 2024-05-30 9:28 UTC (permalink / raw)
To: emacs-orgmode
Remember to cover the basics, that is, what you expected to happen and
what in fact did happen. You don't know how to make a good report? See
https://orgmode.org/manual/Feedback.html#Feedback
Your bug report will be posted to the Org mailing list.
------------------------------------------------------------------------
This is more of a FR than a bug but it would be nice to have working
replot-on-resize when the gnuplot terminal is qt, x11, etc. To have
this functional, the data-file needs to be not deleted.
Emacs : GNU Emacs 30.0.50 (build 8, x86_64-pc-linux-gnu, X toolkit, cairo version 1.18.0, Xaw scroll bars)
of 2024-05-07
Package: Org mode version 9.7-pre (N/A @ /home/viz/lib/emacs/straight/build/org/)
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [BUG/FR] org-plot: replot on resize [9.7-pre (N/A @ /home/viz/lib/emacs/straight/build/org/)]
2024-05-30 9:28 [BUG/FR] org-plot: replot on resize [9.7-pre (N/A @ /home/viz/lib/emacs/straight/build/org/)] Visuwesh
@ 2024-06-04 13:09 ` Ihor Radchenko
2024-06-13 7:08 ` Visuwesh
0 siblings, 1 reply; 8+ messages in thread
From: Ihor Radchenko @ 2024-06-04 13:09 UTC (permalink / raw)
To: Visuwesh; +Cc: emacs-orgmode
Visuwesh <visuweshm@gmail.com> writes:
> This is more of a FR than a bug but it would be nice to have working
> replot-on-resize when the gnuplot terminal is qt, x11, etc. To have
> this functional, the data-file needs to be not deleted.
It should be doable.
We can simply use `org-babel-temp-stable-file' and leave cleaning up to
`org-babel-remove-temporary-stable-directory'.
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [BUG/FR] org-plot: replot on resize [9.7-pre (N/A @ /home/viz/lib/emacs/straight/build/org/)]
2024-06-04 13:09 ` Ihor Radchenko
@ 2024-06-13 7:08 ` Visuwesh
2024-06-14 13:53 ` Ihor Radchenko
0 siblings, 1 reply; 8+ messages in thread
From: Visuwesh @ 2024-06-13 7:08 UTC (permalink / raw)
To: Ihor Radchenko; +Cc: emacs-orgmode
[செவ்வாய் ஜூன் 04, 2024] Ihor Radchenko wrote:
> Visuwesh <visuweshm@gmail.com> writes:
>
>> This is more of a FR than a bug but it would be nice to have working
>> replot-on-resize when the gnuplot terminal is qt, x11, etc. To have
>> this functional, the data-file needs to be not deleted.
>
> It should be doable.
> We can simply use `org-babel-temp-stable-file' and leave cleaning up to
> `org-babel-remove-temporary-stable-directory'.
The data writing functions themselves require a filename so the file
content cannot be used as DATA to org-babel-temp-stable-file. What
should be DATA instead? (list table params)?
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [BUG/FR] org-plot: replot on resize [9.7-pre (N/A @ /home/viz/lib/emacs/straight/build/org/)]
2024-06-13 7:08 ` Visuwesh
@ 2024-06-14 13:53 ` Ihor Radchenko
2024-06-15 4:56 ` Visuwesh
0 siblings, 1 reply; 8+ messages in thread
From: Ihor Radchenko @ 2024-06-14 13:53 UTC (permalink / raw)
To: Visuwesh; +Cc: emacs-orgmode
Visuwesh <visuweshm@gmail.com> writes:
>>> This is more of a FR than a bug but it would be nice to have working
>>> replot-on-resize when the gnuplot terminal is qt, x11, etc. To have
>>> this functional, the data-file needs to be not deleted.
>>
>> It should be doable.
>> We can simply use `org-babel-temp-stable-file' and leave cleaning up to
>> `org-babel-remove-temporary-stable-directory'.
>
> The data writing functions themselves require a filename so the file
> content cannot be used as DATA to org-babel-temp-stable-file. What
> should be DATA instead? (list table params)?
All the things that contribute to what is written to the data file:
;; Dump table to datafile
(let ((dump-func (plist-get type :data-dump)))
(if dump-func
(funcall dump-func table data-file num-cols params)
(org-plot/gnuplot-to-data table data-file params)))
So, you can set DATA to (list (or dump-func 'org-plot/gnuplot-to-data) table num-cols params)
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [BUG/FR] org-plot: replot on resize [9.7-pre (N/A @ /home/viz/lib/emacs/straight/build/org/)]
2024-06-14 13:53 ` Ihor Radchenko
@ 2024-06-15 4:56 ` Visuwesh
2024-06-15 13:37 ` Ihor Radchenko
0 siblings, 1 reply; 8+ messages in thread
From: Visuwesh @ 2024-06-15 4:56 UTC (permalink / raw)
To: Ihor Radchenko; +Cc: emacs-orgmode
[-- Attachment #1: Type: text/plain, Size: 1121 bytes --]
[வெள்ளி ஜூன் 14, 2024] Ihor Radchenko wrote:
> Visuwesh <visuweshm@gmail.com> writes:
>
>>>> This is more of a FR than a bug but it would be nice to have working
>>>> replot-on-resize when the gnuplot terminal is qt, x11, etc. To have
>>>> this functional, the data-file needs to be not deleted.
>>>
>>> It should be doable.
>>> We can simply use `org-babel-temp-stable-file' and leave cleaning up to
>>> `org-babel-remove-temporary-stable-directory'.
>>
>> The data writing functions themselves require a filename so the file
>> content cannot be used as DATA to org-babel-temp-stable-file. What
>> should be DATA instead? (list table params)?
>
> All the things that contribute to what is written to the data file:
>
> ;; Dump table to datafile
> (let ((dump-func (plist-get type :data-dump)))
> (if dump-func
> (funcall dump-func table data-file num-cols params)
> (org-plot/gnuplot-to-data table data-file params)))
>
> So, you can set DATA to (list (or dump-func 'org-plot/gnuplot-to-data) table num-cols params)
Done in the attached patch.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-org-plot-Make-data-file-stable-for-replot-on-resize.patch --]
[-- Type: text/x-diff, Size: 2367 bytes --]
From 0b81eb9da94cdf311bf54748b03d33a550d431cd Mon Sep 17 00:00:00 2001
From: Visuwesh <visuweshm@gmail.com>
Date: Sat, 15 Jun 2024 10:25:19 +0530
Subject: [PATCH] org-plot: Make data-file stable for replot-on-resize
* lisp/org-plot.el (org-plot/gnuplot): Use a stable data-file to make
replot-on-resize in GUI terminals work.
Reported-by: Visuwesh <visuweshm@gmail.com>
Link: https://orgmode.org/list/87mso7sl6g.fsf@gmail.com
---
lisp/org-plot.el | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/lisp/org-plot.el b/lisp/org-plot.el
index 283d993..8adfbc8 100644
--- a/lisp/org-plot.el
+++ b/lisp/org-plot.el
@@ -662,8 +662,7 @@ (defun org-plot/gnuplot (&optional params)
(looking-at "[[:space:]]*#\\+"))
(setf params (org-plot/collect-options params))))
;; collect table and table information
- (let* ((data-file (make-temp-file "org-plot"))
- (table (let ((tbl (save-excursion
+ (let* ((table (let ((tbl (save-excursion
(org-plot/goto-nearest-table)
(org-table-to-lisp))))
(when (pcase (plist-get params :transpose)
@@ -681,12 +680,11 @@ (defun org-plot/gnuplot (&optional params)
(nth 0 table))))
(type (assoc (plist-get params :plot-type)
org-plot/preset-plot-types))
- gnuplot-script)
+ gnuplot-script data-file)
(unless type
(user-error "Org-plot type `%s' is undefined" (plist-get params :plot-type)))
- (run-with-idle-timer 0.1 nil #'delete-file data-file)
(when (eq (cadr table) 'hline)
(setf params
(plist-put params :labels (car table))) ; headers to labels
@@ -696,7 +694,11 @@ (defun org-plot/gnuplot (&optional params)
(looking-at "[[:space:]]*#\\+"))
(setf params (org-plot/collect-options params))))
;; Dump table to datafile
- (let ((dump-func (plist-get type :data-dump)))
+ (let* ((dump-func (plist-get type :data-dump)))
+ (setq data-file (org-babel-temp-stable-file
+ (list (or dump-func 'org-plot/gnuplot-to-data)
+ table num-cols params)
+ "org-plot"))
(if dump-func
(funcall dump-func table data-file num-cols params)
(org-plot/gnuplot-to-data table data-file params)))
--
2.43.0
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [BUG/FR] org-plot: replot on resize [9.7-pre (N/A @ /home/viz/lib/emacs/straight/build/org/)]
2024-06-15 4:56 ` Visuwesh
@ 2024-06-15 13:37 ` Ihor Radchenko
2024-06-17 4:56 ` Visuwesh
0 siblings, 1 reply; 8+ messages in thread
From: Ihor Radchenko @ 2024-06-15 13:37 UTC (permalink / raw)
To: Visuwesh; +Cc: emacs-orgmode
Visuwesh <visuweshm@gmail.com> writes:
>> So, you can set DATA to (list (or dump-func 'org-plot/gnuplot-to-data) table num-cols params)
>
> Done in the attached patch.
Thanks!
> ;; Dump table to datafile
> - (let ((dump-func (plist-get type :data-dump)))
> + (let* ((dump-func (plist-get type :data-dump)))
Why let*?
> + (setq data-file (org-babel-temp-stable-file
> + (list (or dump-func 'org-plot/gnuplot-to-data)
> + table num-cols params)
> + "org-plot"))
Please add in-code comment explaining why we need `org-babel-temp-stable-file'.
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [BUG/FR] org-plot: replot on resize [9.7-pre (N/A @ /home/viz/lib/emacs/straight/build/org/)]
2024-06-15 13:37 ` Ihor Radchenko
@ 2024-06-17 4:56 ` Visuwesh
2024-06-17 17:10 ` Ihor Radchenko
0 siblings, 1 reply; 8+ messages in thread
From: Visuwesh @ 2024-06-17 4:56 UTC (permalink / raw)
To: Ihor Radchenko; +Cc: emacs-orgmode
[-- Attachment #1: Type: text/plain, Size: 843 bytes --]
[சனி ஜூன் 15, 2024] Ihor Radchenko wrote:
> Visuwesh <visuweshm@gmail.com> writes:
>
>>> So, you can set DATA to (list (or dump-func 'org-plot/gnuplot-to-data) table num-cols params)
>>
>> Done in the attached patch.
>
> Thanks!
>
>> ;; Dump table to datafile
>> - (let ((dump-func (plist-get type :data-dump)))
>> + (let* ((dump-func (plist-get type :data-dump)))
>
> Why let*?
Oops, leftover change from a previous iteration of the patch. Now
fixed.
>> + (setq data-file (org-babel-temp-stable-file
>> + (list (or dump-func 'org-plot/gnuplot-to-data)
>> + table num-cols params)
>> + "org-plot"))
>
> Please add in-code comment explaining why we need `org-babel-temp-stable-file'.
Now done.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-org-plot-Make-data-file-stable-for-replot-on-resize.patch --]
[-- Type: text/x-diff, Size: 2399 bytes --]
From a922946b3965e117dc3bbbe5a4f3c67dcc832d68 Mon Sep 17 00:00:00 2001
From: Visuwesh <visuweshm@gmail.com>
Date: Sat, 15 Jun 2024 10:25:19 +0530
Subject: [PATCH] org-plot: Make data-file stable for replot-on-resize
* lisp/org-plot.el (org-plot/gnuplot): Use a stable data-file to make
replot-on-resize in GUI terminals work.
Reported-by: Visuwesh <visuweshm@gmail.com>
Link: https://orgmode.org/list/87mso7sl6g.fsf@gmail.com
---
lisp/org-plot.el | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/lisp/org-plot.el b/lisp/org-plot.el
index 283d993..83483b2 100644
--- a/lisp/org-plot.el
+++ b/lisp/org-plot.el
@@ -662,8 +662,7 @@ (defun org-plot/gnuplot (&optional params)
(looking-at "[[:space:]]*#\\+"))
(setf params (org-plot/collect-options params))))
;; collect table and table information
- (let* ((data-file (make-temp-file "org-plot"))
- (table (let ((tbl (save-excursion
+ (let* ((table (let ((tbl (save-excursion
(org-plot/goto-nearest-table)
(org-table-to-lisp))))
(when (pcase (plist-get params :transpose)
@@ -681,12 +680,11 @@ (defun org-plot/gnuplot (&optional params)
(nth 0 table))))
(type (assoc (plist-get params :plot-type)
org-plot/preset-plot-types))
- gnuplot-script)
+ gnuplot-script data-file)
(unless type
(user-error "Org-plot type `%s' is undefined" (plist-get params :plot-type)))
- (run-with-idle-timer 0.1 nil #'delete-file data-file)
(when (eq (cadr table) 'hline)
(setf params
(plist-put params :labels (car table))) ; headers to labels
@@ -697,6 +695,12 @@ (defun org-plot/gnuplot (&optional params)
(setf params (org-plot/collect-options params))))
;; Dump table to datafile
(let ((dump-func (plist-get type :data-dump)))
+ ;; Use a stable temporary file to ensure that 'replot' upon
+ ;; resizing a GUI gnuplot terminal window works.
+ (setq data-file (org-babel-temp-stable-file
+ (list (or dump-func 'org-plot/gnuplot-to-data)
+ table num-cols params)
+ "org-plot"))
(if dump-func
(funcall dump-func table data-file num-cols params)
(org-plot/gnuplot-to-data table data-file params)))
--
2.43.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
end of thread, other threads:[~2024-06-17 17:09 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-30 9:28 [BUG/FR] org-plot: replot on resize [9.7-pre (N/A @ /home/viz/lib/emacs/straight/build/org/)] Visuwesh
2024-06-04 13:09 ` Ihor Radchenko
2024-06-13 7:08 ` Visuwesh
2024-06-14 13:53 ` Ihor Radchenko
2024-06-15 4:56 ` Visuwesh
2024-06-15 13:37 ` Ihor Radchenko
2024-06-17 4:56 ` Visuwesh
2024-06-17 17:10 ` Ihor Radchenko
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).