emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Ihor Radchenko <yantar92@posteo.net>
To: Max Nikulin <manikulin@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] org-protocol: Add void() to bookmarklets
Date: Sun, 22 Dec 2024 12:42:41 +0000	[thread overview]
Message-ID: <87frmf99dq.fsf@localhost> (raw)
In-Reply-To: <vjpitn$12cj$1@ciao.gmane.io>

Max Nikulin <manikulin@gmail.com> writes:

> A patch updating org-protocol.el comments, docstrings, and the manual is 
> attached.

Thanks!

> -javascript:location.href='org-protocol://store-link?' +
> -      new URLSearchParams({url:location.href, title:document.title});
> +javascript:void(location.href='org-protocol://store-link?' +
> +      new URLSearchParams({url:location.href, title:document.title}));
>  #+end_example

Another variant from reddit is

javascript:location.href='org-protocol://store-link?'+new URLSearchParams({url:location.href, title:document.title}); void(0);

https://old.reddit.com/r/emacs/comments/1h7ws1i/the_orgprotocol_bookmarklet_opens_a_blank_page/

Do you still prefer yours? I know close to nothing about JS.

Also, will the change work in older browsers? In non-Firefox?

-- 
Ihor Radchenko // yantar92,
Org mode maintainer,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>


  parent reply	other threads:[~2024-12-22 14:45 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-12  8:12 [BUG] Org-protocol bookmarklets in Firefox behaving badly after recent upgrade [9.6.15 (release_9.6.15 @ /usr/share/emacs/29.4/lisp/org/)] Rehan Deen
2024-12-12 10:34 ` Max Nikulin
2024-12-12 14:14   ` Max Nikulin
2024-12-12 18:47     ` Rehan Deen
2024-12-13 11:09       ` Max Nikulin
2024-12-16 16:01       ` [PATCH] org-protocol: Add void() to bookmarklets Max Nikulin
2024-12-16 16:40         ` Max Nikulin
2024-12-22 12:43           ` Ihor Radchenko
2024-12-22 12:42         ` Ihor Radchenko [this message]
2024-12-24 14:14           ` Max Nikulin
2024-12-24 14:23             ` Ihor Radchenko
     [not found]   ` <875xnp6qin.fsf@gmail.com>
2024-12-12 17:15     ` [BUG] Org-protocol bookmarklets in Firefox behaving badly after recent upgrade [9.6.15 (release_9.6.15 @ /usr/share/emacs/29.4/lisp/org/)] Rehan Deen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87frmf99dq.fsf@localhost \
    --to=yantar92@posteo.net \
    --cc=emacs-orgmode@gnu.org \
    --cc=manikulin@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).