From: Nicolas Goaziou <n.goaziou@gmail.com>
To: Bastien <bzg@gnu.org>
Cc: Christian Wittern <cwittern@gmail.com>,
emacs-orgmode@gnu.org, Eric Schulte <schulte.eric@gmail.com>
Subject: Re: Should comments break paragraphs?
Date: Wed, 17 Jul 2013 15:47:13 +0200 [thread overview]
Message-ID: <87ehaxjo2m.fsf@gmail.com> (raw)
In-Reply-To: <878v15jqdy.fsf@bzg.ath.cx> (Bastien's message of "Wed, 17 Jul 2013 14:57:13 +0200")
Bastien <bzg@gnu.org> writes:
> Nicolas Goaziou <n.goaziou@gmail.com> writes:
>> And the direction is wrong... Parsing shouldn't modify the buffer being
>> parsed, ever. But you can use a hook for that purpose.
>
> I didn't suggest that parsing should modify the before: I said "where
> comments are deleted before parsing and exporting".
>
> There should be an easy solution for that.
Yes, a hook, as I suggested:
(defun my-comment-removal (backend)
(delete-matching-lines "^[ \t]*#\\( \\|$\\)"))
(add-hook 'org-export-before-parsing-hook 'my-comment-removal)
I maintain it is dangerous to make it a default (or even make it easier
than that) because it will cause a discrepancy between the real buffer
contents and what is really parsed. It can create strange things,
really.
> I didn't suggest to redefine comments.
Of course you did. You said comments should be available anywhere but in
source blocks, didn't you? It isn't possible without redefining them in
Org.
>> You have to change every part of Org that
>> assumes there will be no comment in its way (lists, agenda, babel,
>> parser and probably more I can't think of).
>>
>> If it's an HTML/ODT export issue, it's far easier to patch the export
>> back-ends instead. 10 lines of code in each one, maybe.
>
> This is a general pre-export issue, it does not depend on the
> exporters themselves.
What you want here is to give comments a special meaning just before
export, even though they don't have it otherwise. As an example, you can
remove the comment here just before export:
text
# comment
text
but `org-element-at-point' will still see two paragraphs and a comment
between them nonetheless.
But, IIUC, the problem the OP wants to solve is different: he wants the
example above to be treated as a paragraph, not as two of them. In fact
this is more about paragraphs than comments (i.e. paragraphs definition
in targeted back-ends is different than Org's).
> So again, what prevents us to make it easy for users to treat comments
> as no-line before parsing and exporting?
It is already easy, see hook above. Nothing prevents you from making it
easier. But this is wrong.
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2013-07-17 13:47 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-15 18:48 Should comments break paragraphs? Kodi Arfer
2013-07-15 18:54 ` Nicolas Goaziou
2013-07-15 22:46 ` Christian Wittern
2013-07-16 6:53 ` Rainer M Krug
2013-07-16 6:59 ` Nicolas Goaziou
2013-07-16 7:09 ` Rainer M Krug
2013-07-16 7:40 ` Nicolas Goaziou
2013-07-16 8:09 ` Rainer M Krug
2013-07-16 8:19 ` Andreas Leha
2013-07-16 8:44 ` Nicolas Goaziou
2013-07-16 8:55 ` Andreas Leha
2013-07-16 17:08 ` Eric S Fraga
2013-07-16 8:26 ` Nicolas Goaziou
2013-07-16 8:21 ` Fabrice Popineau
2013-07-16 8:27 ` Fabrice Popineau
2013-07-16 15:46 ` Eric Schulte
2013-07-16 16:01 ` Nicolas Goaziou
2013-07-16 16:59 ` Eric Schulte
2013-07-16 17:51 ` Nicolas Goaziou
2013-07-17 5:28 ` Bastien
2013-07-17 7:17 ` Nicolas Goaziou
2013-07-17 8:15 ` Bastien
2013-07-17 9:00 ` Nicolas Goaziou
2013-07-17 12:57 ` Bastien
2013-07-17 13:21 ` Rainer M Krug
2013-07-17 13:52 ` Rasmus
2013-07-17 16:10 ` Eric S Fraga
2013-07-18 7:02 ` Christian Moe
2013-07-18 8:31 ` Eric Abrahamsen
2013-07-18 8:50 ` Rasmus
2013-07-18 9:50 ` Eric Abrahamsen
2013-07-18 8:47 ` Rasmus
2013-07-17 13:28 ` Eric Schulte
2013-07-17 14:30 ` Bastien
2013-07-17 13:47 ` Nicolas Goaziou [this message]
2013-07-17 18:48 ` Eric S Fraga
2013-07-17 19:04 ` Nicolas Goaziou
2013-07-17 20:18 ` Eric S Fraga
2013-07-17 7:11 ` Suvayu Ali
2013-07-17 12:54 ` Eric Schulte
2013-07-17 13:52 ` Nicolas Goaziou
2013-07-17 22:05 ` Andreas Leha
2013-07-17 22:11 ` Eric Schulte
2013-07-17 22:34 ` Andreas Leha
2013-07-18 11:23 ` Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ehaxjo2m.fsf@gmail.com \
--to=n.goaziou@gmail.com \
--cc=bzg@gnu.org \
--cc=cwittern@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=schulte.eric@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).