Bug: org-encrypt-entry fails [9.1.2 (9.1.2-elpa @ /Users/dmm/.emacs.d/elpa/org-20171004/)]

Bug: org-encrypt-entry fails [9.1.2 (9.1.2-elpa @ /Users/dmm/.emacs.d/elpa/org-20171004/)]

[David Maslen]

Remember to cover the basics, that is, what you expected to happen and
what in fact did happen.  You don't know how to make a good report?  See

     http://orgmode.org/manual/Feedback.html#Feedback

Your bug report will be posted to the Org mailing list.
------------------------------------------------------------------------

Hello,

I've used org-encrypt in the past, but with emacs25.3 on macos and the latest
melpa package it's no longer working.

The EPA package commands work, so I believe I have gpg configured
correctly.

For example;
m-x epa-encrypt-region using a password of 'test' works on the following;
-----BEGIN PGP MESSAGE-----

jA0EBwMCYfMM8STtN1Pe0jkBvSH5XRx9n0cvZXiPz7XpDA/1FUSypQ+y/TBwqjok
ZuzP/aNr8kS2+Aap09sxfurwASK7jNuDQEU=
=Gd3s
-----END PGP MESSAGE-----

However selecting an org heading such as;

* Test encryption                                                     :crypt:
test this

Then running 'm-x org-encrypt-entry' fails.

My intent is to use a symetric password, as I can with epa.




Emacs  : GNU Emacs 25.3.1 (x86_64-apple-darwin16.7.0, NS appkit-1504.83 Version 10.12.6 (Build 16G29))
 of 2017-09-28
Package: Org mode version 9.1.2 (9.1.2-elpa @ /Users/dmm/.emacs.d/elpa/org-20171004/)

current state:
==============
(setq
 org-journal-file-format "%Y%m%d.org"
 org-journal-mode-hook '(#[nil "\301\b\302\303\304$\207"
			   [org-journal-encrypt-on org-add-hook
			    org-journal-encryption-hook nil t]
			   5]
			 (lambda nil
			  (org-add-hook org-journal-encrypt-on
			   (quote org-journal-encryption-hook) nil t)
			  )
			 )
 org-tab-first-hook '(org-babel-hide-result-toggle-maybe org-babel-header-arg-expand)
 org-speed-command-hook '(org-speed-command-activate org-babel-speed-command-activate)
 org-download-screenshot-method "screencapture -i %s"
 org-trello-mode-on-hook '(orgtrello-controller-mode-on-hook-fn
			   #[nil
			     "\304\305\300!\203\v.\b\202\f.	!\210\306\n\307\310#\210\306\n\311\312#\210\306\n\313\314#\210\306\n\315\316#\210\317\v\320\b!\"\207"
			     [org-trello-current-prefix-keybinding
			      
			      org-trello-default-prefix-keybinding
			      
			      org-trello-mode-map
			      
			      orgtrello-log-no-log
			      
			      orgtrello-setup-install-local-prefix-mode-keybinding
			      
			      boundp
			      
			      define-key
			      
			      [remap org-end-of-line]
			      
			      orgtrello-buffer-end-of-line
			      
			      [remap org-return]
			      
			      orgtrello-buffer-org-return
			      
			      [remap org-ctrl-c-ret]
			      
			      orgtrello-buffer-org-ctrl-c-ret
			      
			      [remap org-archive-subtree]
			      
			      org-trello-archive-card orgtrello-log-msg orgtrello-setup-startup-message]
			     4]
			   )
 org-download-method 'attach
 org-occur-hook '(org-first-headline-recenter)
 org-trello-mode-off-hook '(orgtrello-controller-mode-off-hook-fn
			    #[nil
			      "\304\305\300!\203\v.\b\202\f.	!\210\306\n\307\310#\210\306\n\311\310#\210\306\n\312\310#\210\306\n\313\310#\210\314\v\315\"\207"
			      [org-trello-current-prefix-keybinding
			       
			       org-trello-default-prefix-keybinding
			       
			       org-trello-mode-map
			       
			       orgtrello-log-no-log
			       
			       orgtrello-setup-remove-local-prefix-mode-keybinding
			       
			       boundp
			       
			       define-key
			       
			       [remap org-end-of-line]
			       
			       nil
			       
			       [remap org-return]
			       
			       [remap org-ctrl-c-ret]
			       
			       [remap org-archive-subtree]
			       
			       orgtrello-log-msg "Wish you well, master."]
			      4]
			    )
 org-metaup-hook '(org-babel-load-in-session-maybe)
 org-html-format-drawer-function '(closure
				   (htmlize-buffer-places org-html-format-table-no-css
				    htmlize-css-name-prefix htmlize-output-type
				    htmlize-output-type htmlize-css-name-prefix t)
				   (_name contents) contents)
 org-log-done 'time
 org-latex-format-inlinetask-function 'org-latex-format-inlinetask-default-function
 org-confirm-shell-link-function 'yes-or-no-p
 org-image-actual-width 300
 org-ascii-format-inlinetask-function 'org-ascii-format-inlinetask-default

 org-return-follows-link t
 org-latex-format-headline-function 'org-latex-format-headline-default-function
 org-capture-templates '(("B" "Things I want to buy" entry
			  (file+headline "wanted.org" "things I want to buy")
			  "* %?\nEntered on %U\n  %i\n  %a")
			 ("a" "Appointment" entry (file "~/Dropbox/text/org/gcal.org")
			  "* %?\n\n%^T\n\n:PROPERTIES:\n\n:END:\n\n")
			 ("t" "Todo" entry (file+headline "refile.org" "Tasks to file")
			  "* TODO %?\n  %i\n  %a")
			 ("j" "Journal" entry (file+olp+datetree "~/org/journal.org")
			  "* %?\nEntered on %U\n  %i\n  %a")
			 ("i" "Idea" entry (file "~/Dropbox/text/org/refile.org") ""))
 org-after-todo-state-change-hook '(org-clock-out-if-current)
 org-latex-format-drawer-function '(closure (t) (_ contents) contents)
 org-odt-format-headline-function 'org-odt-format-headline-default-function
 org-from-is-user-regexp "\\<David Maslen\\>"
 org-src-mode-hook '(org-src-babel-configure-edit-buffer
		     org-src-mode-configure-edit-buffer)
 org-agenda-before-write-hook '(org-agenda-add-entry-text)
 org-babel-pre-tangle-hook '(save-buffer)
 org-mode-hook '((closure
		  (org-inlinetask-min-level buffer-face-mode-face org-struct-menu
		   org-last-state texmathp-why remember-data-file iswitchb-temp-buflist
		   calc-embedded-open-mode calc-embedded-open-formula
		   calc-embedded-close-formula align-mode-rules-list
		   org-export-registered-backends t)
		  nil
		  (add-hook (quote change-major-mode-hook) (quote org-show-block-all)
		   (quote append) (quote local))
		  )
		 (closure (*this* org-babel-confirm-evaluate-answer-no t) nil
		  (add-hook (quote change-major-mode-hook)
		   (quote org-babel-show-result-all) (quote append) (quote local))
		  )
		 worf-mode
		 (lambda nil
		  (let ((filename (buffer-file-name (current-buffer))))
		   (if (and filename (string= "trello" (file-name-extension filename)))
		    (progn (org-trello-mode)))
		   )
		  )
		 auto-fill-mode flyspell-mode
		 #[nil "\301\302\b\"\205	.\303 \207"
		   [org-trello-files -any\?
		    #[(name) "\302\b!	\230\207"
		      [name buffer-file-name expand-file-name] 2]
		    org-trello-mode]
		   3]
		 #[0 "\300\301\302\303\304$\207"
		   [add-hook change-major-mode-hook org-show-block-all append local] 5]
		 #[0 "\300\301\302\303\304$\207"
		   [add-hook change-major-mode-hook org-babel-show-result-all append
		    local]
		   5]
		 org-babel-result-hide-spec org-babel-hide-all-hashes
		 org-journal-update-auto-mode-alist)
 org-refile-targets '((nil :maxlevel . 3) (org-agenda-files :maxlevel . 2))
 org-bibtex-headline-format-function #[257 "\300.\236A\207" [:title] 3 "\n\n(fn ENTRY)"]
 org-outline-path-complete-in-steps nil
 org-archive-hook '(org-attach-archive-delete-maybe)
 org-ascii-format-drawer-function '(closure (t) (_name contents _width) contents)
 org-odt-format-inlinetask-function 'org-odt-format-inlinetask-default-function
 org-refile-use-outline-path t
 org-directory "~/Dropbox/text/org/"
 org-cycle-hook '(org-cycle-hide-archived-subtrees org-cycle-hide-drawers
		  org-cycle-show-empty-lines
		  org-optimize-window-after-visibility-change)
 org-tags-exclude-from-inheritance '("crypt")
 org-journal-dir "~/Dropbox/text/org/journal/"
 org-attach-directory "~/OneDrive/org-data"
 org-crypt-key nil
 org-download-annotate-function 'org-download-annotate-default
 org-capture-before-finalize-hook '(org-gcal--capture-post)

 org-confirm-elisp-link-function 'yes-or-no-p
 org-startup-with-inline-images t
 org-gcal-client-id "1095737257618-lat2l4f0mfbtasqv8568ip3eni326hcj.apps.googleusercontent.com"
 org-metadown-hook '(org-babel-pop-to-session-maybe)
 org-trello-current-prefix-keybinding "C-c o"
 org-odt-format-drawer-function '(closure
				  (hfy-user-sheet-assoc hfy-html-quote-regex
				   hfy-html-quote-map hfy-face-to-css
				   hfy-begin-span-handler hfy-end-span-handler
				   archive-zip-extract
				   nxml-auto-insert-xml-declaration-flag t)
				  (_name contents) contents)
 org-crypt-disable-auto-save t
 org-html-format-headline-function 'org-html-format-headline-default-function
 org-link-parameters '(("rmail" :follow org-rmail-open :store org-rmail-store-link)
		       ("mhe" :follow org-mhe-open :store org-mhe-store-link)
		       ("irc" :follow org-irc-visit :store org-irc-store-link)
		       ("info" :follow org-info-open :export org-info-export :store
			org-info-store-link)
		       ("gnus" :follow org-gnus-open :store org-gnus-store-link)
		       ("docview" :follow org-docview-open :export org-docview-export
			:store org-docview-store-link)
		       ("bibtex" :follow org-bibtex-open :store org-bibtex-store-link)
		       ("bbdb" :follow org-bbdb-open :export org-bbdb-export :complete
			org-bbdb-complete-link :store org-bbdb-store-link)
		       ("w3m" :store org-w3m-store-link) ("id" :follow org-id-open)
		       ("file+sys") ("file+emacs") ("doi" :follow org--open-doi-link)
		       ("elisp" :follow org--open-elisp-link)
		       ("file" :complete org-file-complete-link)
		       ("ftp" :follow (lambda (path) (browse-url (concat "ftp:" path))))
		       ("help" :follow org--open-help-link)
		       ("http" :follow
			(lambda (path) (browse-url (concat "http:" path))))
		       ("https" :follow
			(lambda (path) (browse-url (concat "https:" path))))
		       ("mailto" :follow
			(lambda (path) (browse-url (concat "mailto:" path))))
		       ("news" :follow
			(lambda (path) (browse-url (concat "news:" path))))
		       ("shell" :follow org--open-shell-link))
 org-reveal-start-hook '(org-decrypt-entry)
 org-html-format-inlinetask-function 'org-html-format-inlinetask-default-function
 org-agenda-files '("/Users/dmm/Dropbox/text/org/Howto-david.org"
		    "/Users/dmm/Dropbox/text/org/Untitled.org"
		    "/Users/dmm/Dropbox/text/org/agenda.org"
		    "/Users/dmm/Dropbox/text/org/emacs.org"
		    "/Users/dmm/Dropbox/text/org/eve.org"
		    "/Users/dmm/Dropbox/text/org/firefly.org"
		    "/Users/dmm/Dropbox/text/org/first.org"
		    "/Users/dmm/Dropbox/text/org/flagged.org"
		    "/Users/dmm/Dropbox/text/org/games.org"
		    "/Users/dmm/Dropbox/text/org/gtd.org"
		    "/Users/dmm/Dropbox/text/org/hardware.org"
		    "/Users/dmm/Dropbox/text/org/home.org"
		    "/Users/dmm/Dropbox/text/org/ivy-todo.org"
		    "/Users/dmm/Dropbox/text/org/journal.org"
		    "/Users/dmm/Dropbox/text/org/linux.org"
		    "/Users/dmm/Dropbox/text/org/org-ref.org"
		    "/Users/dmm/Dropbox/text/org/origin-contacts.org"
		    "/Users/dmm/Dropbox/text/org/origin-journal.org"
		    "/Users/dmm/Dropbox/text/org/origin-notes.org"
		    "/Users/dmm/Dropbox/text/org/origin-work.org"
		    "/Users/dmm/Dropbox/text/org/osx.org"
		    "/Users/dmm/Dropbox/text/org/refile.org"
		    "/Users/dmm/Dropbox/text/org/remember.org"
		    "/Users/dmm/Dropbox/text/org/second.org"
		    "/Users/dmm/Dropbox/text/org/secret.org"
		    "/Users/dmm/Dropbox/text/org/study.org"
		    "/Users/dmm/Dropbox/text/org/test.org"
		    "/Users/dmm/Dropbox/text/org/trello-org.org"
		    "/Users/dmm/Dropbox/text/org/trinity.org"
		    "/Users/dmm/Dropbox/text/org/ts412a.org"
		    "/Users/dmm/Dropbox/text/org/tv.org"
		    "/Users/dmm/Dropbox/text/org/vampyr-notes.org"
		    "/Users/dmm/Dropbox/text/org/vampyr.org"
		    "/Users/dmm/Dropbox/text/org/wanted.org"
		    "/Users/dmm/Dropbox/text/org/windows.org"
		    "/Users/dmm/Dropbox/text/org/work.org"
		    "/Users/dmm/Dropbox/text/org/journal/2015.org")
 org-clock-out-hook '(org-clock-remove-empty-clock-drawer)
 org-publish-project-alist '(("org-dropbox" :base-directory "~/Dropbox/text/org/pub/"
			      :base-extension "org" :publishing-directory
			      "~/Dropbox/text/public_html/" :recursive t
			      :publishing-function org-html-publish-to-html
			      :headline-levels 4 :auto-preamble t)
			     )
 )

Re: Bug: org-encrypt-entry fails [9.1.2 (9.1.2-elpa @ /Users/dmm/.emacs.d/elpa/org-20171004/)]

[Nicolas Goaziou]

Hello,

David Maslen <david.maslen@gmail.com> writes:

> The EPA package commands work, so I believe I have gpg configured
> correctly.
>
> For example;
> m-x epa-encrypt-region using a password of 'test' works on the following;
>
> test
> However selecting an org heading such as;
>
> * Test encryption                                                     :crypt:
> test this
>
> Then running 'm-x org-encrypt-entry' fails.

What is failing exactly?

Regards,

-- 
Nicolas Goaziou

Re: Bug: org-encrypt-entry fails [9.1.2 (9.1.2-elpa @ /Users/dmm/.emacs.d/elpa/org-20171004/)]

[Nicolas Goaziou]

Hello,

David Maslen <david.maslen@gmail.com> writes:

> In the example below the words “test this” are not replaced by encrypted
> text.
> My previous experience is that the entire contents of a org subheading
> structure marked with the :crypt: tag would be encrypted/decrypted by the
> related org function.

I cannot reproduce it. The text is properly replaced by encrypted text
here.

Regards,

-- 
Nicolas Goaziou                                                0x80A93738

Solved: Bug: org-encrypt-entry fails [9.1.2 (9.1.2-elpa @ /Users/dmm/.emacs.d/elpa/org-20171004/)]

[David Maslen]

Solved. 
Problem was that in graphical mode I saw no password prompt. Failed without a useful failure message.
Perhaps org-crypt could be improved to catch this situation?

Starting emacs in a terminal worked, as the password prompt was in the originating terminal window.
On a Mac, I tended to start emacs from the dock, so no terminal.

Solution was to follow the instruction in pinentry. 
I then added (pinenty-start) to my .emacs init file.
No org-encrypt-entry prompts for a password in the minibuffer.


pinentry is a built-in package.

     Status: Built-In.
    Version: 0.1
    Summary: GnuPG Pinentry server implementation
Other versions: 0.1 (gnu).


This package allows GnuPG passphrase to be prompted through the
minibuffer instead of graphical dialog.

To use, add "allow-emacs-pinentry" to "~/.gnupg/gpg-agent.conf",
reload the configuration with "gpgconf --reload gpg-agent", and
start the server with M-x pinentry-start.



> On 14 Oct 2017, at 3:33 am, Nicolas Goaziou <mail@nicolasgoaziou.fr> wrote:
> 
> Hello,
> 
> David Maslen <david.maslen@gmail.com> writes:
> 
>> In the example below the words “test this” are not replaced by encrypted
>> text.
>> My previous experience is that the entire contents of a org subheading
>> structure marked with the :crypt: tag would be encrypted/decrypted by the
>> related org function.
> 
> I cannot reproduce it. The text is properly replaced by encrypted text
> here.
> 
> Regards,
> 
> -- 
> Nicolas Goaziou                                                0x80A93738

Re: Solved: Bug: org-encrypt-entry fails [9.1.2 (9.1.2-elpa @ /Users/dmm/.emacs.d/elpa/org-20171004/)]

[Nicolas Goaziou]

Hello,

David Maslen <david.maslen@gmail.com> writes:

> Problem was that in graphical mode I saw no password prompt. Failed without a useful failure message.
> Perhaps org-crypt could be improved to catch this situation?

What would you suggest?

Regards,

-- 
Nicolas Goaziou

Re: Solved: Bug: org-encrypt-entry fails [9.1.2 (9.1.2-elpa @ /Users/dmm/.emacs.d/elpa/org-20171004/)]

[David Maslen]

I’m sorry I don’t know how to implement, or provide a patch, but I checked *messages* for a clue to what was going wrong.
I now think this isn’t an org issue, but the epa functions worked, and the org-encrypt (which I read uses epg) failed silently, so I reported here.

If the *messages* said something like “prompting for passphrase”, I’d have realised earlier that was not occurring.



> On 14 Oct 2017, at 7:33 pm, Nicolas Goaziou <mail@nicolasgoaziou.fr> wrote:
> 
> Hello,
> 
> David Maslen <david.maslen@gmail.com> writes:
> 
>> Problem was that in graphical mode I saw no password prompt. Failed without a useful failure message.
>> Perhaps org-crypt could be improved to catch this situation?
> 
> What would you suggest?
> 
> Regards,
> 
> -- 
> Nicolas Goaziou

Re: Solved: Bug: org-encrypt-entry fails [9.1.2 (9.1.2-elpa @ /Users/dmm/.emacs.d/elpa/org-20171004/)]

[Nicolas Goaziou]

Hello,

David Maslen <david.maslen@gmail.com> writes:

> I’m sorry I don’t know how to implement, or provide a patch, but I checked *messages* for a clue to what was going wrong.
> I now think this isn’t an org issue, but the epa functions worked, and the org-encrypt (which I read uses epg) failed silently, so I reported here.
>
> If the *messages* said something like “prompting for passphrase”, I’d
> have realised earlier that was not occurring.

Org Crypt never directly prompts for a passphrase. `epg-encrypt-string'
does. So I think this message should be sent from EPG library instead.

Regards,

-- 
Nicolas Goaziou

Re: Solved: Bug: org-encrypt-entry fails [9.1.2 (9.1.2-elpa @ /Users/dmm/.emacs.d/elpa/org-20171004/)]

[David Maslen]

Fair enough. When I get some time I’ll find out how to send this through as a Wishlist bug. Thank you for the direction.

> On 15 Oct 2017, at 7:37 pm, Nicolas Goaziou <mail@nicolasgoaziou.fr> wrote:
> 
> Hello,
> 
> David Maslen <david.maslen@gmail.com> writes:
> 
>> I’m sorry I don’t know how to implement, or provide a patch, but I checked *messages* for a clue to what was going wrong.
>> I now think this isn’t an org issue, but the epa functions worked, and the org-encrypt (which I read uses epg) failed silently, so I reported here.
>> 
>> If the *messages* said something like “prompting for passphrase”, I’d
>> have realised earlier that was not occurring.
> 
> Org Crypt never directly prompts for a passphrase. `epg-encrypt-string'
> does. So I think this message should be sent from EPG library instead.
> 
> Regards,
> 
> -- 
> Nicolas Goaziou