From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id yCtuG9yr/l4rGgAA0tVLHw (envelope-from ) for ; Fri, 03 Jul 2020 03:54:04 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id 2BlRF9yr/l6IJQAAB5/wlQ (envelope-from ) for ; Fri, 03 Jul 2020 03:54:04 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D76129409ED for ; Fri, 3 Jul 2020 03:54:03 +0000 (UTC) Received: from localhost ([::1]:41478 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jrCm1-0000Tu-75 for larch@yhetil.org; Thu, 02 Jul 2020 23:54:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51272) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jrClV-0000Tm-NY for emacs-orgmode@gnu.org; Thu, 02 Jul 2020 23:53:29 -0400 Received: from mail-pj1-x102f.google.com ([2607:f8b0:4864:20::102f]:36502) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jrClT-0006nK-Re for emacs-orgmode@gnu.org; Thu, 02 Jul 2020 23:53:29 -0400 Received: by mail-pj1-x102f.google.com with SMTP id h22so13406938pjf.1 for ; Thu, 02 Jul 2020 20:53:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:subject:in-reply-to:message-id:date :mime-version; bh=g9Ki74Vh3VnRmirlr5D413qXFntfdZRB+fsshF8Dygs=; b=bL8NMCNqIy8LNhYwQ0E6NeZzIH3qH/DKqniZiDyWrXzuJUv2A41Ix31ZF+0cUogffv 7rC4ec7rhuEVVq1h6JNhyJiQO2dKCTnT/OCSDSqw8VKf7S4gmPgVC2xc9aUO1TZYXcwK yLlqAQFt9hmM+if2VF5IGjWGMm+YCA2tjkhPkCmydIL1/FnxJ6G05JxOvdxUvn0Yl29z M9NRn0SIZdHue5H+peOqROJT1EjiDlN5yL5H852b3HdnXZaVEdSkuWCrjP2vL2ndcSKo +MCU1eETcyzvom3iGWnYQ4pKDlQYKzBXQVJAVwb/tcHz6/Hlm+paRJnQoftPxNgZch99 IuAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:subject :in-reply-to:message-id:date:mime-version; bh=g9Ki74Vh3VnRmirlr5D413qXFntfdZRB+fsshF8Dygs=; b=FzD9D25yxMu7RFnJKuLESvXKZgK0dB0qiOca1H79mhOuUAlfR0cRpFQES1FdYTkcHO AEPbreNqEi1tQGq7S9V7WpnwvJwu8jFVHxHozYhGZ1P03H6qPR4Swk8HjvDOQ5M4rDKm jRmz8uFJyYD4O0hYBxuw2FRN2f+2pLSOyPTYXBM6w5pRsNfMZgGZwt4m9oI66HFaYbaX aKRw4hd8qEoG8ZfHEFT5kCV+b+4FB43pVPBpo8l6TtlLZ3WEfwH3sbQ9Xu/D8weqCmEm 4tDRINfNohcr+5nicZxV63bBMdj9bn3V7GoyKimoO8SudviA0lgkQwwCd/IqagwXpmcf 9SyQ== X-Gm-Message-State: AOAM532ZNvYO8Y372GH4QenSibyA9JLexRZ///yxphgKoZiJ7b1W0Rtm 4kkr0hVS9Hkq1hmgsx0z73meIk2Y X-Google-Smtp-Source: ABdhPJxIFF/d+bKV49dzaeYodxNaN1chjQLzEm3lGeFGqQbK5KIs2MIsCjTYDLUrNP6DWcNJCnY/bA== X-Received: by 2002:a17:90a:35c:: with SMTP id 28mr26123474pjf.63.1593748405799; Thu, 02 Jul 2020 20:53:25 -0700 (PDT) Received: from tim-desktop (203-173-23-17.dyn.iinet.net.au. [203.173.23.17]) by smtp.gmail.com with ESMTPSA id u13sm8841484pjy.40.2020.07.02.20.53.24 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jul 2020 20:53:25 -0700 (PDT) References: <874kr6402z.fsf@gmail.com> <87y2o11ef5.fsf@gmail.com> User-agent: mu4e 1.5.4; emacs 27.0.91 From: Tim Cross To: emacs-orgmode@gnu.org Subject: Re: patch: ob-clojure improvements In-reply-to: <87y2o11ef5.fsf@gmail.com> Message-ID: <87eeptfe4u.fsf@gmail.com> Date: Fri, 03 Jul 2020 13:53:21 +1000 MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::102f; envelope-from=theophilusx@gmail.com; helo=mail-pj1-x102f.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=bL8NMCNq; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: -1.71 X-TUID: dZm3WiqNzPw5 I am also interested in ob-clojure and ob-clojurescript improvements. However, right now, I'm a tad busy and haven't had time to review what has been done. Hopefully, can make some time in the next month or so. Tim stardiviner writes: > agzam.ibragimov@gmail.com writes: > >> There seems to be a bit of lack of interest for these things. But I'm sure >> some people (myself included) would love to see these kinds of >> improvements. > > Yes, I rarely saw Clojurians in this mailing list. > >> As I said before, I have never participated in contributing >> to Org source, some guidance would be appreciated. > > Org Mode has contribution guide here http://orgmode.org/worg/org-contribute.html#patches > >> Should I keep building it and posting patches? Should I try to go >> incrementally, one small change at a time, or should I just get everything >> working first? If it turns out to be a bigger work, should I ask for >> permission to work in a branch and get access to pushing things to it? Maybe >> things just move slowly, because obviously you can't force maintainers to drop >> everything and concentrate effort to get your things in. Maybe I just have to >> be a little bit more patient? > > I think a complete work contains many patches should be better, Also write testing if necessary. > > I remember ob-clojure.el code are mostly reviewed by Bastien Guerry. I included him in Cc: in this email. > >> On Sat, Jun 20, 2020 at 1:23 AM stardiviner wrote: >> >>> >>> Glad to see your patch, really useful in some cases. Thanks. >>> >>> Ag Ibragimov writes: >>> >>> > Hi everyone, here's my attempt to add clojure CLI and babashka support >>> for ob-clojure.el >>> > >>> > - Adds a header parameter to override org-babel-clojure-backend >>> > - Adds :args param (right now only used for clojure-cli) >>> > >>> > I have tested it with these minimal cases: >>> > >>> > #+begin_src clojure :backend clj-cli :args "-Sdeps '{:deps {inflections >>> {:mvn/version \"0.13.2\"}}}'" >>> > (use 'inflections.core) >>> > (plural "word") >>> > #+end_src >>> > >>> > #+begin_src clojure :backend babashka :results output >>> > (range 10) >>> > #+end_src >>> > >>> > Please let me know what you think. Any advice is appreciated, since I >>> have never contributed before. Thank you. >>> >>> >>> -- >>> [ stardiviner ] >>> I try to make every word tell the meaning that I want to express. >>> >>> Blog: https://stardiviner.github.io/ >>> IRC(freenode): stardiviner, Matrix: stardiviner >>> GPG: F09F650D7D674819892591401B5DF1C95AE89AC3 >>> -- Tim Cross