From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id oKeSG7FptGJQ9wAAbAwnHQ (envelope-from ) for ; Thu, 23 Jun 2022 15:25:05 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id qFOEG7FptGLFCQEA9RJhRA (envelope-from ) for ; Thu, 23 Jun 2022 15:25:05 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0678D28E2E for ; Thu, 23 Jun 2022 15:25:05 +0200 (CEST) Received: from localhost ([::1]:58998 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o4MpQ-0001hA-6P for larch@yhetil.org; Thu, 23 Jun 2022 09:25:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37702) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o4MoZ-0001gj-WC for emacs-orgmode@gnu.org; Thu, 23 Jun 2022 09:24:08 -0400 Received: from mail-ot1-x32a.google.com ([2607:f8b0:4864:20::32a]:37439) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o4MoT-0004Vf-LK for emacs-orgmode@gnu.org; Thu, 23 Jun 2022 09:24:07 -0400 Received: by mail-ot1-x32a.google.com with SMTP id l9-20020a056830268900b006054381dd35so15333601otu.4 for ; Thu, 23 Jun 2022 06:24:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=s9C6P7HJtUUJ8gohGVkAaHYkMEsizl0cGgkkBPNbR2E=; b=nM1qb3HDzmhh8AnwUTUMTlj1vXTnZ7Nnghca3l4ghd4L2neZUdDg4Ie9IyrZHCXqaI YzH3BbxjrtBS0RoB/Cxxv9M3ysiOzzbaXnTB3DCEB5MYrQg7efFf3N262s4qkIi7QmNo KB7UOBg9nC4btVgzPcSWkhQqvSSDBZUtaiNKrHpXMMAVB4fxKtzHlbz/pIT+HVOFb/vc 9KVt1EKYcTG1RFbbPH8WFvwWtOAqdpJt9F8UsH3LjnMW/o5K77d3mKmwrwFXFoT3+dHz dU6DCQQVQhZBRAMemDONgEqruP44gJbY25atbFad265ZwvbLVaeQ4l3QayG3xnOLnjwa 3kow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=s9C6P7HJtUUJ8gohGVkAaHYkMEsizl0cGgkkBPNbR2E=; b=gQGEbrSgV8e2e99+jBUd++gruuUJ9DiCGnjtnpm6osIoz/UaGWkI+h9WKMWp6c+HZV HGKVnIgLaGaZFA7eWd58iUKqvv2fQw+Af+meisOyZZbOkVpmc9UWpTn+sv+ECq/RHtft 0MQVit1M+6MVPDlTABZHAO8MOPESL8DN7XsKplRiJlNe3UXRzuJ1A0K7KR0MHd2GrVrs hIkflqlbGKp8mJEKIqTTcMiD41euJCfIyaTQzmuMnKlFmx45gCTdnXCNCFE4vnOV5C6n GTol1rjSNRqbk2JoiQorJW+l3Anw0jC0NlD4+j4hzVrzsP7OdbdHiPpFFK5NDkg0QfoN Hgkg== X-Gm-Message-State: AJIora8H3hz6/5PgTOC/xRYOhvpnEw62EjVQbm/dhBAwbJdLmRtzffaL bX2H1Jy1CZRiD4KujWVcwms= X-Google-Smtp-Source: AGRyM1tH6Ns93ZQ2byvY/iMj9a9ClLOCaoYHWCUW7qzM7CLI0G+vAy+Kn8vH0XeZBrM7iQ8uXu1gyQ== X-Received: by 2002:a05:6830:34a7:b0:60c:458e:f3b2 with SMTP id c39-20020a05683034a700b0060c458ef3b2mr3769797otu.194.1655990640394; Thu, 23 Jun 2022 06:24:00 -0700 (PDT) Received: from localhost ([207.126.88.10]) by smtp.gmail.com with ESMTPSA id t8-20020a9d66c8000000b0060b0b638583sm12540904otm.13.2022.06.23.06.23.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jun 2022 06:23:59 -0700 (PDT) From: Ihor Radchenko To: David Lukes Cc: emacs-orgmode@gnu.org Subject: Re: [PATCH] oc-basic.el: Stringify year from CSL-JSON date-parts In-Reply-To: <20220621120458.154859-1-dafydd.lukes@gmail.com> References: <20220621120458.154859-1-dafydd.lukes@gmail.com> Date: Thu, 23 Jun 2022 21:25:11 +0800 Message-ID: <87edzfa4w8.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::32a; envelope-from=yantar92@gmail.com; helo=mail-ot1-x32a.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1655990705; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=s9C6P7HJtUUJ8gohGVkAaHYkMEsizl0cGgkkBPNbR2E=; b=u9xKB3JeFsUP2hXQ0nLGwcLbrGtsFnhvxOwoNnCkJ/+i5wlea/XjE0wPzNSCgZTt3ifani yCfnbRhlsmdu/e/RV4OUsFHg+J2pDH3bkI79aK5Q3A9T+im5VtCN6gvPWtCtSBc3b6egTJ DpXen68WAJHAfXSlX5bQCLQUPb4WecTfnk0Lf73lt25TX4umere7Vwq/5+fYawCpVzGEjF 0hTEF56CqgQrOy4w3TMfuH9bnqYb+Rhm/r6daB+S6+T+kebgdSdYRLLAJTidOIRg2rZRIC DogaJ0gXtWDHffQj6RC5vCatR/u0KfU25NyJRcMMLsE/f84E1XtMh/lXGaArlg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1655990705; a=rsa-sha256; cv=none; b=pipwi6F+N+R844vdaMamzOMUIs0/dSZgIHPcNv2KwC1yQUBhBpssEq8Ywz4OQ1Qr/E6tX1 GQT0t+gljYs3JBy4htb7mRO5ttY9KmegwnHeuIOEpV5UOF+KainvdP+jows0KmPBwPqAyY Ib8Iy8Oc9zQ0f7yZgGcz8n1TatW1+fwsEQVHY10nVBNRzSQuCPM9TkAlcoOigwV14/lBch AZfoTXBSCTMbwJQ7m5l538aXE8NI3MzpNGe9EKnuqTmhLu42BfOLMyaXLUUz992oJv0VgE kVUVnhuZXHjHmTqUTQV1V2eR9wJQ8j/f0INpvAgM1hZOID+Y+/xdOYNqt9KUXw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=nM1qb3HD; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.46 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=nM1qb3HD; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 0678D28E2E X-Spam-Score: -3.46 X-Migadu-Scanner: scn1.migadu.com X-TUID: 8ooSiSOscybx David Lukes writes: > * lisp/oc-basic.el (org-cite-basic--parse-json): Make sure year > extracted from date-parts is returned as string. Raise error if > original type other than number or string. Thanks! Applied onto bugfix via 05626952b. Note that the total LOC of your contributions is exceeding 20LOC (depending how to count). You may need to complete the copyright paperwork for future patches. See https://orgmode.org/worg/org-contribute.html#copyright Best, Ihor