From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id CnkxLj5RsmQEWAAASxT56A (envelope-from ) for ; Sat, 15 Jul 2023 09:56:46 +0200 Received: from aspmx1.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id cHFgLD5RsmTbSwEAG6o9tA (envelope-from ) for ; Sat, 15 Jul 2023 09:56:46 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 41E5D575DD for ; Sat, 15 Jul 2023 09:56:46 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=RgjA2IdL; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1689407806; a=rsa-sha256; cv=none; b=AoBcVdGguI5W/KOnzwhyidVXsEpjhsLlyKd5vhySurnrm819mHbAz/uzQH8QvQFoX91Tyx QOdyO+yQ00SaiqutliA+LDnhMXz7KJmeV4XX6RHmSw77LlFyblkq57ALE8oQ9XPCDKOAnD 9YUm3hrFLkNzt974D6fvRhEuqEas8yjwTrRCU+EKfsZEZnALOFi+1DgtdCiUrvLud/T0Bh DpeBtymtzOEOBjM+/jIAoPvGnrGF4EBL2GWFB3w4HTrJ6dkaV2fgOxNl/1LWcK1BIGxrmQ xV5idjO2W3YMEdybeCxMXw27utMnCc0PLtpble/49zHCpB4Y0JkjqSLAHcl8Jg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=RgjA2IdL; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1689407806; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=cxkQmr6ATZZtjEq6aj7NLdC0qU0d5oax6NqsaCI+4D4=; b=EepH7XvmkIWD4nJtqNYw7zThOC2eo8bKA4bbfiwm3KJsOr+oFltiYI80zUuGH2v6+CY5tJ WgloAkQGVgKBK5E2LcxngnqkgSQm/t9ImNvcJkP4hUC0Ghny/o4XQpxaJ039FXk1oRPTOA 5n8EvML4+dytXyJVdnW5lsOynB22aK7NdTtW6U+eLgGAV4Jn3HWzOvBR1rZln+Q/iVn4fm 9Z1nSlirG8j8ZWziAFuD4oMoWTj8A09MYVJYbMSW7cv4uhwyLMbYoyEXZwnI43K8vgt8DF Xx+D48ngBluBhNiV/tfanQoZQH8TLR7S1/3hcrTr/BrpgtXnQF2IpqGoOFbjTQ== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qKa8U-0007Gb-NR; Sat, 15 Jul 2023 03:56:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qKa8S-0007GD-JZ for emacs-orgmode@gnu.org; Sat, 15 Jul 2023 03:56:12 -0400 Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qKa8Q-0000es-RL for emacs-orgmode@gnu.org; Sat, 15 Jul 2023 03:56:12 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 06F2F240106 for ; Sat, 15 Jul 2023 09:56:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1689407769; bh=Bg//GNS9NtjSWGFqCt/dk9xMc/qJwjCblml5bm53cMM=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:From; b=RgjA2IdL6yeGoouDNGVppXPglPNZLs/d25AChYG71suMte9MjlDKMPlm49Cf6NOYr SnX4pO8u+0sbev26V8B2tH8qSb6FYch12xVw2Ra1f+nZHd2IOTdRT34d9q0Wl2xHnH E/5nll6xaInJsdJI4Xt/VwjxacZuCiF/4WnLXAvUscovuvtx6HeAIu2a73hwzYtDhn oBoUf+2aibq4T2agKkFD0KKwUJi8cgK9WX+/ezVneFXjt890cZgmgmAmMsA/RtTBHH i6m3rJoATs17ibV3cBs/4jPPdzDzsYoa5yxjxL04qhasosco0Rc6a39EwGm+neZtv1 /7EfLJOZ8BueQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4R30yv6bnMz9rxK; Sat, 15 Jul 2023 09:56:07 +0200 (CEST) From: Ihor Radchenko To: Max Nikulin Cc: Ilya Chernyshov , emacs-orgmode Subject: Re: [PATCH] testing: Delete duplicate tests In-Reply-To: <2e5004db-1c3c-1b5c-e665-1b538aad745c@gmail.com> References: <87cz0xndem.fsf@gmail.com> <2e5004db-1c3c-1b5c-e665-1b538aad745c@gmail.com> Date: Sat, 15 Jul 2023 07:56:16 +0000 Message-ID: <87edl9halb.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.66; envelope-from=yantar92@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -2.31 X-Migadu-Scanner: mx2.migadu.com X-Spam-Score: -2.31 X-Migadu-Queue-Id: 41E5D575DD X-TUID: 8ti1w9OH3DmM Max Nikulin writes: > The idea to find duplicated tests is bright. The code may be transformed > in a dedicated unit test. I would not drop existing tests blindly though. Very good idea indeed. One gotcha is that not every should form is next level after ert-deftest. And there are also "should-not" and "should-error" forms. So, we may compare only forms at the same sexp depth for equality, without restricting to "should". -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at