Re: [BUG] bug fix with inline figure generated by org-octave [9.7-pre (release_9.6.7-662-gb89bc5)]

[Ihor Radchenko <yantar92@posteo.net>]

Shervin Safavi <neuroprinciplist@gmail.com> writes:

> In "ob-octave.el" line 94, instead of
>
> (format "print -dpng %S\nans=%S" gfx-file gfx-file))
>
> should be
>
> (format "print -dpng %s" gfx-file))
>
> otherwise, the figure is not saved (and thus an empty inline figure will
> appear).

Thanks for the report and for the suggestion!
May you please explain us a bit why having ans=filename is a problem?
Looking at
https://docs.octave.org/v5.2.0/Printing-and-Saving-Plots.html, it should
be enough to call print.

> I already test it with MATLAB and can confirm it.
>
> By the way, it is my first bug report/fix for org-mode, so apologies if
> I miss something in my report.

It would be nice to provide an example demonstrating the problem.
Sometimes, what happens on your machine may not happen for other people.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>