From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id kFLbHiqR4GZLKQAA62LTzQ:P1 (envelope-from ) for ; Tue, 10 Sep 2024 18:34:18 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id kFLbHiqR4GZLKQAA62LTzQ (envelope-from ) for ; Tue, 10 Sep 2024 20:34:18 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=KkbjCyVq; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1725993258; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=s6aT70vDgHO2Dfggarwnao/oTV+9g3Cy2IK9uN/fgac=; b=OKVnZTME0gZraebFAbELdZInXDhAMhLq6uFZoBBybwYP2hmFsIMK7IsScI0pWcdUlupP0P MZ/x5v4m4hKJSMnX0+EHkxpmfh5FhEh+h9qCDU/AxnPUIEm+AXV41E8Wta0s1VrAR5zYal 0uENupARHtJ78IJhSAngUMtEzA/5MFgVmN3ORMRBpxCe4H+OOhUI3YQfURjgemDyypbswt n6Aj7oYFmUqzXDWjjvG8QVdO8hA3JOErTfkcpkWE2C/ObC3Yh6uNWrJ5hdPkBFMWrya+UL kw8hhyDOykVUARc4+++rz+I//lwAiMPiVV9X3SEG9zTek+oYCtLPO5TzqwDq5g== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1725993258; a=rsa-sha256; cv=none; b=MZqRfXDHA1YvvCpecYPUcmj1PePAfLmOFUvaaqr7AK1cIPDzvltx9uvTIq1VrpUodW7Yi5 imxtDxfZKt1D+K6+gIL/ntk2GsSJjjgkcMVbBzsbu52bInE4Dq5nu1AeNUZo4by0kNF/iA /F32HiOeqpbcm/UZCVayTeworY8BExtJomNh4maI8iCQNaz/dsQVVWR1GknZAQ6oUI80Vo myEKTMmWC0SPjTiPqdl0QoCi6UZJhD2DOyZKaOIMAwMbvgyUhl0hBDxqzsbSaS+sYuGzCx ezblUuEHFzscKiFvTkKwNzYj3BnrS+zbkPKPKT+yIqAeP4H53XTKDlmPRC+moQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=KkbjCyVq; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3808962E3F for ; Tue, 10 Sep 2024 20:34:18 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1so5fj-00052s-1y; Tue, 10 Sep 2024 14:33:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1so5fd-00052U-Hi for emacs-orgmode@gnu.org; Tue, 10 Sep 2024 14:32:57 -0400 Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1so5fb-0001lH-En for emacs-orgmode@gnu.org; Tue, 10 Sep 2024 14:32:57 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 747AA240101 for ; Tue, 10 Sep 2024 20:32:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1725993170; bh=1ZwN+LED4buqeX5ImcyBp2wvA2XflPFLp+S4sxrP0yA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type: From; b=KkbjCyVqNB4Xd5lhbd1lhffIjVdmUl5QdNPuPCKN8VKWFUwXLMXZHje2RziDD+cH3 uEKOyvib9zOZLl+bTGKQdZKSEECYEO3gYZHJtTDiRw+DOiOj+Scmw7fRwKQIt37feG ue3mARc74GJkKe2DC5Iqy77TbSI0eTR81LlwbOcmqvG0IR4XRJRh9X6bz1UBH4xuKQ ZAsXnG+adYbHztSZY3/XYa1rSgn5pZaL3Uvz1J/xq95xM4nuW+/447py3xTlyUp5bC jIFNhkkEvP9UjdBatZvB7PWKfQQxfgQlJJwfeYpMDho56ahVBOfhNA3PdOejJDKlH2 YJ5dRNDfBZSdA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4X3C4K416Zz6trs; Tue, 10 Sep 2024 20:32:49 +0200 (CEST) From: Ihor Radchenko To: Karthik Chikmagalur Cc: stardiviner , Org mode Subject: Re: [PATCH v3] Inline image display as part of a new org-link-preview system In-Reply-To: <87ttenxvbr.fsf@gmail.com> References: <6461a84b.a70a0220.b6d36.5d00@mx.google.com> <87v7zyyvm3.fsf@localhost> <87frr07xz8.fsf@gmail.com> <87cym38aj8.fsf@gmail.com> <87r0ajawgj.fsf@localhost> <87a5h77zb1.fsf@gmail.com> <87msl4wv8d.fsf@localhost> <875xrqg6cb.fsf@gmail.com> <874j70n559.fsf@localhost> <87msksabld.fsf@gmail.com> <87jzfwljkq.fsf@localhost> <87h6b09v4o.fsf@gmail.com> <878qwb8qw1.fsf@localhost> <878qw9ak6a.fsf@gmail.com> <87o74ypp3b.fsf@localhost> <87cyldzf3p.fsf@gmail.com> <87jzflqs2g.fsf@localhost> <8734m8zejw.fsf@gmail.com> <87ldzzo37o.fsf@localhost> <87ttenxvbr.fsf@gmail.com> Date: Tue, 10 Sep 2024 18:34:19 +0000 Message-ID: <87ed5rmk7o.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.66; envelope-from=yantar92@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Queue-Id: 3808962E3F X-Migadu-Scanner: mx12.migadu.com X-Migadu-Spam-Score: -9.71 X-Spam-Score: -9.71 X-TUID: RxOgyUd8tFzv Karthik Chikmagalur writes: >>> since the previews are place asynchronously. It always reports "no >>> images to display inline". Should I remove this messaging, or find a >>> way to run this from the final async chunk? The code gets a little >>> convoluted when I do the latter. >> >> I am a bit confused. Isn't `org-link-preview--get-overlays' counting >> overlays? And the overlays should be created before async preview is >> complete, right? Or do I miss something? > > Currently I only add the overlay to `org-link-preview-overlays' if/when > the preview is successful. `org-link-preview--get-overlays' counts > overlays in this buffer-local list. > ... Ok. The idea behind that message is mostly to make user aware if there are any/none images to be actually displayed. It does not have to count actual overlays. Instead, we may display something like "X images _will_ be displayed..." -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at