From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: [patch][ox-html] Stylistic changes Date: Sun, 16 Mar 2014 10:59:39 +0100 Message-ID: <87d2hmsbuc.fsf@gmail.com> References: <874n2z3ruf.fsf@gmx.us> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:56520) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WP83r-00025q-TP for emacs-orgmode@gnu.org; Sun, 16 Mar 2014 06:13:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WP83m-0007id-2M for emacs-orgmode@gnu.org; Sun, 16 Mar 2014 06:12:55 -0400 Received: from mail-we0-x22a.google.com ([2a00:1450:400c:c03::22a]:43185) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WP7qa-0003PD-A9 for emacs-orgmode@gnu.org; Sun, 16 Mar 2014 05:59:12 -0400 Received: by mail-we0-f170.google.com with SMTP id w61so3586611wes.15 for ; Sun, 16 Mar 2014 02:59:11 -0700 (PDT) In-Reply-To: <874n2z3ruf.fsf@gmx.us> (rasmus@gmx.us's message of "Sun, 16 Mar 2014 01:33:12 +0100") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Rasmus Cc: emacs-orgmode@gnu.org Hello, Rasmus writes: > Here's a couple of minor changes for ox-html. Thank you. > First, I dropped the references to HTML5 hgroup since apparently W3 > did the same=EF=BB=BF=C2=B9. Applied. > Second, for some reason ox-html replaces a couple of entities by > itself=E2=80=94rather than letting org-entities do it=E2=80=94but uses he= x references > (or whatever), rather than a "nice" HTML character entity. The second > patch fixes this. (I naively assume that there is not a reason for > not using the pretty references). According to the log of the commit introducing the changes, there is a reason: commit f2b2c8318fa8c2ce82208d717c649377c856802c Author: Jambunathan K Date: Sat Mar 2 11:00:46 2013 +0530 Add Freemind Mindmap Back-End for Org Export Engine =20=20=20=20=20=20 * contrib/lisp/ox-freemind.el: New file. =20=20=20=20=20=20 * lisp/ox-html.el (org-html--tags, org-html-format-headline) (org-html--format-toc-headline, org-html-checkbox) (org-html-table-cell, org-html-timestamp) (org-html-verse-block, org-html-special-string-regexps): Replace named HTML entities with their numeric counterparts. This keeps Freemind backend happy. So if the change is only stylistic, I see no reason to break compatibility with "ox-freemind.el". Regards, --=20 Nicolas Goaziou