From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rasmus Subject: Re: [PATCH] org-id-goto doesn't work if buffer is narrowed. Date: Sat, 24 Oct 2015 14:47:12 +0200 Message-ID: <87d1w4zb5b.fsf@gmx.us> References: <874mhh1u7s.fsf@gmx.us> <87oafpz65e.fsf@gmx.us> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:54650) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZpyEG-0002Re-6E for emacs-orgmode@gnu.org; Sat, 24 Oct 2015 08:47:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZpyEB-0001qw-6J for emacs-orgmode@gnu.org; Sat, 24 Oct 2015 08:47:24 -0400 Received: from mout.gmx.net ([212.227.15.15]:55113) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZpyEB-0001qq-07 for emacs-orgmode@gnu.org; Sat, 24 Oct 2015 08:47:19 -0400 In-Reply-To: (John Kitchin's message of "Sat, 24 Oct 2015 07:33:54 -0400") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: jkitchin@andrew.cmu.edu Cc: emacs-orgmode@gnu.org John Kitchin writes: > Maybe I am missing something here. I would expect org-id-goto to actually > get to the id entry when it is used independent of narrowing. When used in > a program, I would expect this behavior to be wrapped in save-restriction > type macros, so it wouldn't change your restriction. But when used > interactively, e.g. when I click on a link, I expect the point to end up = on > the id entry, with the buffer open in front of me, even if that means > widening. Is there some other expectation that makes sense? I feel like it > is up to me to decide if breaking the restriction is worth visiting the > link, and only by clicking on the link or running an interactive command > makes that happen. I prefer the behavior of C-c C-c on a footnote in a narrowed buffer. I.e. throw an error. > Is it possible to save a restriction in a variable? so that something like > C-c & could restore it? the save-restriction macro must do something like > that, but the code seems to be hidden in the C-source for me. I thought about that. I sort of like, but I also think it=E2=80=99s a pote= ntially big change... A poor man=E2=80=99s solution might be: (when (buffer-narrowed-p) (cons (point-min) (point-max))) Rasmus --=20 When the facts change, I change my mind. What do you do, sir?