From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: [PATCH] org-id-goto doesn't work if buffer is narrowed.
Date: Sat, 24 Oct 2015 13:57:07 +0200
Message-ID: <87d1w4cwdo.fsf@nicolasgoaziou.fr>
References: <CALnw1fRTyShwsk0_G0VMDzfC+6YCCiNxveua36y982LJFfeVNg@mail.gmail.com>
	<874mhh1u7s.fsf@gmx.us>
	<CALnw1fSycwXL-hBfm=x0ejrvSHGZVr6mxm2aV-+=Q4VFUXDkXg@mail.gmail.com>
	<87oafpz65e.fsf@gmx.us>
	<CALnw1fRk0a0SpfDASVz8G66iHH4sHGm24WnhkoW69ycBjrVnpQ@mail.gmail.com>
	<CAJ51ETry9SEzi3C+nw3LWf=1ejUV=rh+k+eZwMeBwqjfSXaEnQ@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45971)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1ZpxPx-0005DD-Oo
	for emacs-orgmode@gnu.org; Sat, 24 Oct 2015 07:55:26 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1ZpxPw-0005tQ-SI
	for emacs-orgmode@gnu.org; Sat, 24 Oct 2015 07:55:25 -0400
Received: from relay3-d.mail.gandi.net ([2001:4b98:c:538::195]:46887)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1ZpxPw-0005tJ-IA
	for emacs-orgmode@gnu.org; Sat, 24 Oct 2015 07:55:24 -0400
In-Reply-To: <CAJ51ETry9SEzi3C+nw3LWf=1ejUV=rh+k+eZwMeBwqjfSXaEnQ@mail.gmail.com>
	(John Kitchin's message of "Sat, 24 Oct 2015 07:33:54 -0400")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: John Kitchin <jkitchin@andrew.cmu.edu>
Cc: emacs-orgmode <emacs-orgmode@gnu.org>, Rasmus <rasmus@gmx.us>

Hello,

John Kitchin <jkitchin@andrew.cmu.edu> writes:

> Maybe I am missing something here. I would expect org-id-goto to actually
> get to the id entry when it is used independent of narrowing. When used in
> a program, I would expect this behavior to be wrapped in save-restriction
> type macros, so it wouldn't change your restriction. But when used
> interactively, e.g. when I click on a link, I expect the point to end up on
> the id entry, with the buffer open in front of me, even if that means
> widening. Is there some other expectation that makes sense? I feel like it
> is up to me to decide if breaking the restriction is worth visiting the
> link, and only by clicking on the link or running an interactive command
> makes that happen.
>
> An alternative might be to check if a restriction is in place somehow, and
> make org-id-goto not work or warn you somehow if it has to remove the
> restriction.

I agree that we should first widen the buffer unconditionally in order
to find the location. Once the issue is fixed, we can discuss about
a better UI.

Regards,

-- 
Nicolas Goaziou